fix test

Author: cathteng

migrations_lockfile.txt

@@ -39,4 +39,4 @@ tempest: 0001_squashed_0002_make_message_type_nullable
 
 uptime: 0048_delete_uptime_status_columns
 
-workflow_engine: 0098_detectorgroup_detector_set_null
+workflow_engine: 0099_backfill_metric_issue_detectorgroup

src/sentry/workflow_engine/migrations/0099_backfill_metric_issue_detectorgroup.py

@@ -13,7 +13,6 @@
 from sentry import eventstore
 from sentry.new_migrations.migrations import CheckedMigration
 from sentry.snuba.dataset import Dataset
-from sentry.utils.query import RangeQuerySetWrapper
 
 logger = logging.getLogger(__name__)
 
@@ -77,9 +76,7 @@ def backfill_metric_issue_detectorgroup(
     DetectorGroup = apps.get_model("workflow_engine", "DetectorGroup")
     Detector = apps.get_model("workflow_engine", "Detector")
 
-    for group in RangeQuerySetWrapper(
-        Group.objects.filter(type=8001, detectorgroup__isnull=True)
-    ):  # metric issues
+    for group in Group.objects.filter(type=8001, detectorgroup__isnull=True):  # metric issues
         # figure out the detector
         latest_event = get_oldest_or_latest_event(group, EventOrdering.LATEST)
         if not latest_event:
@@ -139,7 +136,7 @@ class Migration(CheckedMigration):
     is_post_deployment = True
 
     dependencies = [
-        ("sentry", "1003_group_history_prev_history_safe_removal"),
+        # ("sentry", "1003_group_history_prev_history_safe_removal"),
         ("workflow_engine", "0098_detectorgroup_detector_set_null"),
     ]
 
@@ -150,7 +147,7 @@ class Migration(CheckedMigration):
             hints={
                 "tables": [
                     "workflow_engine_detectorgroup",
-                    "sentry_group",
+                    "sentry_groupedmessage",
                 ]
             },
         ),

tests/sentry/workflow_engine/migrations/test_0099_backfill_metric_issue_detectorgroup.py

@@ -4,18 +4,15 @@
 from sentry.testutils.cases import TestMigrations
 from sentry.testutils.helpers.datetime import before_now
 from sentry.workflow_engine.models import Detector, DetectorGroup
-from tests.sentry.workflow_engine.test_base import BaseWorkflowTest
+from tests.sentry.issues.test_utils import OccurrenceTestMixin
 
 
-class BackfillMetricIssueDetectorGroupTest(TestMigrations, BaseWorkflowTest):
+class BackfillMetricIssueDetectorGroupTest(TestMigrations, OccurrenceTestMixin):
     migrate_from = "0098_detectorgroup_detector_set_null"
     migrate_to = "0099_backfill_metric_issue_detectorgroup"
     app = "workflow_engine"
 
     def setup_initial_state(self) -> None:
-        self.org = self.create_organization(name="test-org")
-        self.project = self.create_project(organization=self.org)
-
         self.detector = Detector.objects.create(
             project=self.project,
             name="Test Detector",
@@ -35,6 +32,12 @@ def setup_initial_state(self) -> None:
         assert group_info is not None
         self.metric_issue = group_info.group
 
+        deleted_detector = Detector.objects.create(
+            project=self.project,
+            name="Test Detector 2",
+            type=MetricIssue.slug,
+            config={"detection_type": AlertRuleDetectionType.STATIC.value},
+        )
         event = self.store_event(
             data={
                 "event_id": "b" * 32,
@@ -45,14 +48,15 @@ def setup_initial_state(self) -> None:
         occurrence_data = self.build_occurrence_data(
             event_id=event.event_id,
             project_id=self.project.id,
-            fingerprint=[f"detector-{123}"],
-            evidence_data={"detector_id": 123},
+            fingerprint=[f"detector-{deleted_detector.id}"],
+            evidence_data={"detector_id": deleted_detector.id},
             type=MetricIssue.type_id,
         )
 
         _, group_info = save_issue_occurrence(occurrence_data, event)
         assert group_info is not None
         self.metric_issue_deleted_detector = group_info.group
+        deleted_detector.delete()
 
         self.metric_issue_no_occurrence = self.create_group(
             project=self.project, type=MetricIssue.type_id