feat: Remove extrapolation modes from alerts translation (#103823)

Author: shruthilayaj

src/sentry/explore/translation/alerts_translation.py

@@ -1,5 +1,6 @@
 import logging
 
+import sentry_sdk
 from django.db import router, transaction
 
 from sentry import features
@@ -12,12 +13,7 @@
     handle_send_historical_data_to_seer,
 )
 from sentry.snuba.dataset import Dataset
-from sentry.snuba.models import (
-    ExtrapolationMode,
-    QuerySubscription,
-    SnubaQuery,
-    SnubaQueryEventType,
-)
+from sentry.snuba.models import QuerySubscription, SnubaQuery, SnubaQueryEventType
 from sentry.snuba.tasks import update_subscription_in_snuba
 from sentry.utils.db import atomic_transaction
 from sentry.workflow_engine.models.data_condition import DataCondition
@@ -79,6 +75,10 @@ def translate_detector_and_update_subscription_in_snuba(snuba_query: SnubaQuery)
     )
 
     if dropped_fields["selected_columns"]:
+        with sentry_sdk.isolation_scope() as scope:
+            scope.set_tag("dropped_fields", dropped_fields["selected_columns"])
+            scope.set_tag("snuba_query", snuba_query.id)
+            sentry_sdk.capture_message("Unsported column")
         return
 
     translated_aggregate = eap_query_parts["selected_columns"][0]
@@ -88,11 +88,6 @@ def translate_detector_and_update_subscription_in_snuba(snuba_query: SnubaQuery)
     snuba_query.query = translated_query
     snuba_query.dataset = Dataset.EventsAnalyticsPlatform.value
 
-    if snapshot["dataset"] == Dataset.PerformanceMetrics.value:
-        snuba_query.extrapolation_mode = ExtrapolationMode.SERVER_WEIGHTED.value
-    elif snapshot["dataset"] == Dataset.Transactions.value:
-        snuba_query.extrapolation_mode = ExtrapolationMode.NONE.value
-
     with atomic_transaction(
         using=(
             router.db_for_write(SnubaQuery),

tests/sentry/explore/translation/test_alerts_translation.py

@@ -4,9 +4,6 @@
 import orjson
 import pytest
 from sentry_protos.snuba.v1.request_common_pb2 import TraceItemType
-from sentry_protos.snuba.v1.trace_item_attribute_pb2 import (
-    ExtrapolationMode as RPCExtrapolationMode,
-)
 from sentry_protos.snuba.v1.trace_item_attribute_pb2 import Function
 from sentry_protos.snuba.v1.trace_item_filter_pb2 import ComparisonFilter
 from urllib3.response import HTTPResponse
@@ -28,7 +25,7 @@
     StoreDataResponse,
 )
 from sentry.snuba.dataset import Dataset
-from sentry.snuba.models import ExtrapolationMode, SnubaQuery, SnubaQueryEventType
+from sentry.snuba.models import SnubaQuery, SnubaQueryEventType
 from sentry.snuba.subscriptions import create_snuba_query, create_snuba_subscription
 from sentry.testutils.cases import SnubaTestCase, TestCase
 from sentry.testutils.helpers.features import with_feature
@@ -163,7 +160,6 @@ def test_translate_alert_rule_simple_count(self, mock_create_rpc) -> None:
         assert snuba_query.dataset == Dataset.EventsAnalyticsPlatform.value
         assert snuba_query.aggregate == "count(span.duration)"
         assert snuba_query.query == "(span.duration:>100) AND is_transaction:1"
-        assert snuba_query.extrapolation_mode == ExtrapolationMode.SERVER_WEIGHTED.value
 
         event_types = list(
             SnubaQueryEventType.objects.filter(snuba_query=snuba_query).values_list(
@@ -205,10 +201,6 @@ def test_translate_alert_rule_simple_count(self, mock_create_rpc) -> None:
         assert expression.aggregation.aggregate == Function.FUNCTION_COUNT
         assert expression.aggregation.key.name == "sentry.project_id"
         assert expression.aggregation.label == "count(span.duration)"
-        assert (
-            expression.aggregation.extrapolation_mode
-            == RPCExtrapolationMode.EXTRAPOLATION_MODE_SAMPLE_WEIGHTED
-        )
         assert expression.label == "count(span.duration)"
 
         assert len(rpc_time_series_request.group_by) == 0
@@ -264,7 +256,6 @@ def test_translate_alert_rule_p95(self, mock_create_rpc) -> None:
         assert snuba_query.dataset == Dataset.EventsAnalyticsPlatform.value
         assert snuba_query.aggregate == "p95(span.duration)"
         assert snuba_query.query == "(transaction.method:GET) AND is_transaction:1"
-        assert snuba_query.extrapolation_mode == ExtrapolationMode.NONE.value
 
         event_types = list(
             SnubaQueryEventType.objects.filter(snuba_query=snuba_query).values_list(
@@ -330,7 +321,6 @@ def test_translate_alert_rule_count_unique(self, mock_create_rpc) -> None:
         assert snuba_query.dataset == Dataset.EventsAnalyticsPlatform.value
         assert snuba_query.aggregate == "count_unique(user)"
         assert snuba_query.query == "(transaction:/api/*) AND is_transaction:1"
-        assert snuba_query.extrapolation_mode == ExtrapolationMode.SERVER_WEIGHTED.value
 
         assert mock_create_rpc.called
         call_args = mock_create_rpc.call_args
@@ -387,7 +377,6 @@ def test_translate_alert_rule_empty_query(self, mock_create_rpc) -> None:
         assert snuba_query.dataset == Dataset.EventsAnalyticsPlatform.value
         assert snuba_query.aggregate == "count(span.duration)"
         assert snuba_query.query == "is_transaction:1"
-        assert snuba_query.extrapolation_mode == ExtrapolationMode.NONE.value
 
         assert mock_create_rpc.called
         call_args = mock_create_rpc.call_args