From 4ca1321ea18ffe65527c483b9f6c40ddf6693a16 Mon Sep 17 00:00:00 2001 From: Billy Vong Date: Mon, 22 Apr 2024 21:55:04 -0400 Subject: [PATCH 1/2] fix: Change `maxCanvasSize` to be optional To keep this compatible with prior versions, this option should be optional --- packages/rrweb/src/record/observers/canvas/canvas-manager.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/rrweb/src/record/observers/canvas/canvas-manager.ts b/packages/rrweb/src/record/observers/canvas/canvas-manager.ts index 8f1b57df28..a3a163715e 100644 --- a/packages/rrweb/src/record/observers/canvas/canvas-manager.ts +++ b/packages/rrweb/src/record/observers/canvas/canvas-manager.ts @@ -47,7 +47,7 @@ export interface CanvasManagerConstructorOptions { blockClass: blockClass; blockSelector: string | null; unblockSelector: string | null; - maxCanvasSize: [number, number] | null; + maxCanvasSize?: [number, number] | null; mirror: Mirror; dataURLOptions: DataURLOptions; errorHandler?: ErrorHandler; From c76037efe113684d89a0dcbcead0c70ea41af7c2 Mon Sep 17 00:00:00 2001 From: Billy Vong Date: Mon, 22 Apr 2024 22:00:10 -0400 Subject: [PATCH 2/2] optional --- packages/rrweb/src/record/observers/canvas/canvas-manager.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/rrweb/src/record/observers/canvas/canvas-manager.ts b/packages/rrweb/src/record/observers/canvas/canvas-manager.ts index a3a163715e..42ef1207f0 100644 --- a/packages/rrweb/src/record/observers/canvas/canvas-manager.ts +++ b/packages/rrweb/src/record/observers/canvas/canvas-manager.ts @@ -177,7 +177,7 @@ export class CanvasManager implements CanvasManagerInterface { blockClass: blockClass, blockSelector: string | null, unblockSelector: string | null, - maxCanvasSize: [number, number] | null, + maxCanvasSize: [number, number] | null | undefined, options: { dataURLOptions: DataURLOptions; }, @@ -272,7 +272,7 @@ export class CanvasManager implements CanvasManagerInterface { blockClass: blockClass, blockSelector: string | null, unblockSelector: string | null, - maxCanvasSize: [number, number] | null, + maxCanvasSize: [number, number] | null | undefined, dataURLOptions: DataURLOptions, canvasElement?: HTMLCanvasElement, ) {