Skip to content

Commit b027172

Browse files
committed
Upgrade Ionide.ProjInfo to 0.74.1
1 parent ae0afe7 commit b027172

3 files changed

Lines changed: 18 additions & 7 deletions

File tree

Directory.Packages.props

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@
1313
<PackageVersion Include="Microsoft.Build.Framework" Version="" PrivateAssets="all" />
1414
<PackageVersion Include="Microsoft.Build.Utilities.Core" Version="" PrivateAssets="all" />
1515
<PackageVersion Include="Microsoft.Build.Tasks.Core" Version="" PrivateAssets="all" />
16-
<PackageVersion Include="Ionide.ProjInfo" Version="0.62.0" />
17-
<PackageVersion Include="Ionide.ProjInfo.Sln" Version="0.62.0" />
16+
<PackageVersion Include="Ionide.ProjInfo" Version="0.74.1" />
1817
<PackageVersion Include="Newtonsoft.Json" Version="13.0.3" />
1918
<PackageVersion Include="Suave" Version="2.6.2" />
2019
<PackageVersion Include="System.Memory" Version="4.5.5" />

src/fsdocs-tool/ProjectCracker.fs

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ open FSharp.Formatting.Templating
1212

1313
open Ionide.ProjInfo
1414
open Ionide.ProjInfo.Types
15+
open Microsoft.Build.Evaluation
1516

1617
[<AutoOpen>]
1718
module Utils =
@@ -295,8 +296,16 @@ module Crack =
295296
let cwd = System.Environment.CurrentDirectory |> System.IO.DirectoryInfo
296297
let dotnetExe = getDotnetHostPath () |> Option.map System.IO.FileInfo
297298
let _toolsPath = Init.init cwd dotnetExe
298-
ProjectLoader.getProjectInfo projectFile extraMsbuildProperties BinaryLogGeneration.Off customProperties
299-
//file |> Inspect.getProjectInfos loggedMessages.Enqueue msbuildExec [gp] []
299+
300+
let projectCollection = new ProjectCollection(dict extraMsbuildProperties)
301+
302+
match ProjectLoader.loadProject projectFile BinaryLogGeneration.Off projectCollection with
303+
| Ok loadedProject ->
304+
match ProjectLoader.getLoadedProjectInfo projectFile customProperties loadedProject with
305+
| Ok(ProjectLoader.LoadedProjectInfo.StandardProjectInfo projOptions) -> Ok projOptions
306+
| Ok _ -> Error $"project '%s{projectFile}' is not a standard project"
307+
| Error e -> Error e
308+
| Error e -> Error e
300309

301310
let msgs = (loggedMessages.ToArray() |> Array.toList)
302311

@@ -428,7 +437,7 @@ module Crack =
428437

429438
let getProjectsFromSlnFile (slnPath: string) =
430439
match InspectSln.tryParseSln slnPath with
431-
| Ok(_, slnData) -> InspectSln.loadingBuildOrder slnData
440+
| Ok slnData -> InspectSln.loadingBuildOrder slnData
432441

433442
//this.LoadProjects(projs, crosstargetingStrategy, useBinaryLogger, numberOfThreads)
434443
| Error e -> raise (exn ("cannot load the sln", e))
@@ -442,7 +451,10 @@ module Crack =
442451
let collectionName, projectFiles =
443452
match projects, ignoreProjects with
444453
| [], false ->
445-
match Directory.GetFiles(slnDir, "*.sln") with
454+
let slnFiles =
455+
[| yield! Directory.GetFiles(slnDir, "*.sln"); yield! Directory.GetFiles(slnDir, "*.slnx") |]
456+
457+
match slnFiles with
446458
| [| sln |] ->
447459
printfn "getting projects from solution file %s" sln
448460

src/fsdocs-tool/fsdocs-tool.fsproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
<PackageReference Include="FSharp.Core" />
5252
<PackageReference Include="CommandLineParser" />
5353
<PackageReference Include="Ionide.ProjInfo" />
54-
<PackageReference Include="Ionide.ProjInfo.Sln" />
54+
<PackageReference Include="Microsoft.Build" IncludeAssets="compile" ExcludeAssets="runtime" PrivateAssets="all" />
5555
<PackageReference Include="Suave" />
5656
</ItemGroup>
5757
</Project>

0 commit comments

Comments
 (0)