Remove deprecated Ruby File.exists? in helper script (#109428)

Author: jmagman

packages/flutter_tools/bin/podhelper.rb

@@ -14,12 +14,10 @@
 # target 'Runner' do
 # ...
 # end
-def flutter_ios_podfile_setup
-end
+def flutter_ios_podfile_setup; end
 
 # Same as flutter_ios_podfile_setup for macOS.
-def flutter_macos_podfile_setup
-end
+def flutter_macos_podfile_setup; end
 
 # Add iOS build settings to pod targets.
 #
@@ -60,13 +58,12 @@ def flutter_additional_ios_build_settings(target)
     # Profile can't be derived from the CocoaPods build configuration. Use release framework (for linking only).
     configuration_engine_dir = build_configuration.type == :debug ? debug_framework_dir : release_framework_dir
     Dir.new(configuration_engine_dir).each_child do |xcframework_file|
-      next if xcframework_file.start_with?(".") # Hidden file, possibly on external disk.
-      if xcframework_file.end_with?("-simulator") # ios-arm64_x86_64-simulator
+      next if xcframework_file.start_with?('.') # Hidden file, possibly on external disk.
+      if xcframework_file.end_with?('-simulator') # ios-arm64_x86_64-simulator
         build_configuration.build_settings['FRAMEWORK_SEARCH_PATHS[sdk=iphonesimulator*]'] = "\"#{configuration_engine_dir}/#{xcframework_file}\" $(inherited)"
-      elsif xcframework_file.start_with?("ios-") # ios-arm64
+      elsif xcframework_file.start_with?('ios-') # ios-arm64
         build_configuration.build_settings['FRAMEWORK_SEARCH_PATHS[sdk=iphoneos*]'] = "\"#{configuration_engine_dir}/#{xcframework_file}\" $(inherited)"
-      else
-        # Info.plist or another platform.
+       # else Info.plist or another platform.
       end
     end
     build_configuration.build_settings['OTHER_LDFLAGS'] = '$(inherited) -framework Flutter'
@@ -158,7 +155,7 @@ def flutter_install_all_macos_pods(macos_application_path = nil)
 #                                      Optional, defaults to the Podfile directory.
 def flutter_install_ios_engine_pod(ios_application_path = nil)
   # defined_in_file is set by CocoaPods and is a Pathname to the Podfile.
-  ios_application_path ||= File.dirname(defined_in_file.realpath) if self.respond_to?(:defined_in_file)
+  ios_application_path ||= File.dirname(defined_in_file.realpath) if respond_to?(:defined_in_file)
   raise 'Could not find iOS application path' unless ios_application_path
 
   podspec_directory = File.join(ios_application_path, 'Flutter')
@@ -167,7 +164,7 @@ def flutter_install_ios_engine_pod(ios_application_path = nil)
   # Generate a fake podspec to represent the Flutter framework.
   # This is only necessary because plugin podspecs contain `s.dependency 'Flutter'`, and if this Podfile
   # does not add a `pod 'Flutter'` CocoaPods will try to download it from the CocoaPods trunk.
-  File.open(copied_podspec_path, 'w') { |podspec|
+  File.open(copied_podspec_path, 'w') do |podspec|
     podspec.write <<~EOF
       #
       # NOTE: This podspec is NOT to be published. It is only used as a local source!
@@ -188,24 +185,24 @@ def flutter_install_ios_engine_pod(ios_application_path = nil)
         s.vendored_frameworks = 'path/to/nothing'
       end
     EOF
-  }
+  end
 
   # Keep pod path relative so it can be checked into Podfile.lock.
-  pod 'Flutter', :path => flutter_relative_path_from_podfile(podspec_directory)
+  pod 'Flutter', path: flutter_relative_path_from_podfile(podspec_directory)
 end
 
 # Same as flutter_install_ios_engine_pod for macOS.
 def flutter_install_macos_engine_pod(mac_application_path = nil)
   # defined_in_file is set by CocoaPods and is a Pathname to the Podfile.
-  mac_application_path ||= File.dirname(defined_in_file.realpath) if self.respond_to?(:defined_in_file)
+  mac_application_path ||= File.dirname(defined_in_file.realpath) if respond_to?(:defined_in_file)
   raise 'Could not find macOS application path' unless mac_application_path
 
   copied_podspec_path = File.expand_path('FlutterMacOS.podspec', File.join(mac_application_path, 'Flutter', 'ephemeral'))
 
   # Generate a fake podspec to represent the FlutterMacOS framework.
   # This is only necessary because plugin podspecs contain `s.dependency 'FlutterMacOS'`, and if this Podfile
   # does not add a `pod 'FlutterMacOS'` CocoaPods will try to download it from the CocoaPods trunk.
-  File.open(copied_podspec_path, 'w') { |podspec|
+  File.open(copied_podspec_path, 'w') do |podspec|
     podspec.write <<~EOF
       #
       # NOTE: This podspec is NOT to be published. It is only used as a local source!
@@ -226,10 +223,10 @@ def flutter_install_macos_engine_pod(mac_application_path = nil)
         s.vendored_frameworks = 'path/to/nothing'
       end
     EOF
-  }
+  end
 
   # Keep pod path relative so it can be checked into Podfile.lock.
-  pod 'FlutterMacOS', :path => File.join('Flutter', 'ephemeral')
+  pod 'FlutterMacOS', path: File.join('Flutter', 'ephemeral')
 end
 
 # Install Flutter plugin pods.
@@ -238,7 +235,7 @@ def flutter_install_macos_engine_pod(mac_application_path = nil)
 #                                   Optional, defaults to the Podfile directory.
 def flutter_install_plugin_pods(application_path = nil, relative_symlink_dir, platform)
   # defined_in_file is set by CocoaPods and is a Pathname to the Podfile.
-  application_path ||= File.dirname(defined_in_file.realpath) if self.respond_to?(:defined_in_file)
+  application_path ||= File.dirname(defined_in_file.realpath) if respond_to?(:defined_in_file)
   raise 'Could not find application path' unless application_path
 
   # Prepare symlinks folder. We use symlinks to avoid having Podfile.lock
@@ -256,23 +253,22 @@ def flutter_install_plugin_pods(application_path = nil, relative_symlink_dir, pl
     plugin_name = plugin_hash['name']
     plugin_path = plugin_hash['path']
     has_native_build = plugin_hash.fetch('native_build', true)
-    if (plugin_name && plugin_path && has_native_build)
-      symlink = File.join(symlink_plugins_dir, plugin_name)
-      File.symlink(plugin_path, symlink)
+    next unless plugin_name && plugin_path && has_native_build
+    symlink = File.join(symlink_plugins_dir, plugin_name)
+    File.symlink(plugin_path, symlink)
 
-      # Keep pod path relative so it can be checked into Podfile.lock.
-      relative = flutter_relative_path_from_podfile(symlink)
+    # Keep pod path relative so it can be checked into Podfile.lock.
+    relative = flutter_relative_path_from_podfile(symlink)
 
-      pod plugin_name, :path => File.join(relative, platform)
-    end
+    pod plugin_name, path: File.join(relative, platform)
   end
 end
 
 # .flutter-plugins-dependencies format documented at
 # https://flutter.dev/go/plugins-list-migration
 def flutter_parse_plugins_file(file, platform)
   file_path = File.expand_path(file)
-  return [] unless File.exists? file_path
+  return [] unless File.exist? file_path
 
   dependencies_file = File.read(file)
   dependencies_hash = JSON.parse(dependencies_file)

packages/flutter_tools/templates/module/ios/library/Flutter.tmpl/podhelper.rb.tmpl

@@ -67,7 +67,7 @@ def install_flutter_plugin_pods(flutter_application_path)
 
   # Keep pod path relative so it can be checked into Podfile.lock.
   relative = flutter_relative_path_from_podfile(ios_application_path)
-  pod 'FlutterPluginRegistrant', :path => File.join(relative, 'Flutter', 'FlutterPluginRegistrant'), :inhibit_warnings => true
+  pod 'FlutterPluginRegistrant', path: File.join(relative, 'Flutter', 'FlutterPluginRegistrant'), inhibit_warnings: true
 end
 
 # Install Flutter application pod.
@@ -87,27 +87,25 @@ def install_flutter_application_pod(flutter_application_path)
   # Keep script phase paths relative so they can be checked into source control.
   relative = flutter_relative_path_from_podfile(export_script_directory)
 
-  flutter_export_environment_path = File.join('${SRCROOT}', relative, 'flutter_export_environment.sh');
+  flutter_export_environment_path = File.join('${SRCROOT}', relative, 'flutter_export_environment.sh')
 
   # Compile App.framework and move it and Flutter.framework to "BUILT_PRODUCTS_DIR"
-  script_phase :name => 'Run Flutter Build {{projectName}} Script',
-    :script => "set -e\nset -u\nsource \"#{flutter_export_environment_path}\"\nexport VERBOSE_SCRIPT_LOGGING=1 && \"$FLUTTER_ROOT\"/packages/flutter_tools/bin/xcode_backend.sh build",
-    :execution_position => :before_compile
+  script_phase name: 'Run Flutter Build {{projectName}} Script',
+    script: "set -e\nset -u\nsource \"#{flutter_export_environment_path}\"\nexport VERBOSE_SCRIPT_LOGGING=1 && \"$FLUTTER_ROOT\"/packages/flutter_tools/bin/xcode_backend.sh build",
+    execution_position: :before_compile
 
   # Embed App.framework AND Flutter.framework.
-  script_phase :name => 'Embed Flutter Build {{projectName}} Script',
-    :script => "set -e\nset -u\nsource \"#{flutter_export_environment_path}\"\nexport VERBOSE_SCRIPT_LOGGING=1 && \"$FLUTTER_ROOT\"/packages/flutter_tools/bin/xcode_backend.sh embed_and_thin",
-    :execution_position => :after_compile
+  script_phase name: 'Embed Flutter Build {{projectName}} Script',
+    script: "set -e\nset -u\nsource \"#{flutter_export_environment_path}\"\nexport VERBOSE_SCRIPT_LOGGING=1 && \"$FLUTTER_ROOT\"/packages/flutter_tools/bin/xcode_backend.sh embed_and_thin",
+    execution_position: :after_compile
 end
 
 def flutter_root
   generated_xcode_build_settings_path = File.expand_path(File.join('..', '..', 'Flutter', 'Generated.xcconfig'), __FILE__)
-  unless File.exist?(generated_xcode_build_settings_path)
-    raise "#{generated_xcode_build_settings_path} must exist. If you're running pod install manually, make sure flutter pub get is executed first"
-  end
+  raise "#{generated_xcode_build_settings_path} must exist. If you're running pod install manually, make sure flutter pub get is executed first" unless File.exist?(generated_xcode_build_settings_path)
 
   File.foreach(generated_xcode_build_settings_path) do |line|
-    matches = line.match(/FLUTTER_ROOT\=(.*)/)
+    matches = line.match(/FLUTTER_ROOT=(.*)/)
     return matches[1].strip if matches
   end
   # This should never happen...
@@ -127,7 +125,7 @@ def flutter_post_install(installer, skip: false)
   return if skip
 
   installer.pods_project.targets.each do |target|
-    target.build_configurations.each do |build_configuration|
+    target.build_configurations.each do |_build_configuration|
       # flutter_additional_ios_build_settings is in Flutter root podhelper.rb
       flutter_additional_ios_build_settings(target)
     end