Bump Dart to 3.8 and reformat (#171703)

Bumps the Dart version to 3.8 across the repo (excluding
engine/src/flutter/third_party) and applies formatting updates from Dart
3.8.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Author: Piinks

dev/a11y_assessments/lib/main.dart

@@ -75,8 +75,8 @@ class HomePageState extends State<HomePage> {
         builder: (BuildContext context) {
           return TextButton(
             key: Key(useCase.name),
-            onPressed:
-                () => Navigator.of(context).pushNamed(useCase.route, arguments: useCase.name),
+            onPressed: () =>
+                Navigator.of(context).pushNamed(useCase.route, arguments: useCase.name),
             child: Text(useCase.name),
           );
         },

dev/a11y_assessments/lib/use_cases/app_bar.dart

@@ -36,58 +36,57 @@ class MainWidgetState extends State<MainWidget> {
   @override
   Widget build(BuildContext context) {
     return Scaffold(
-      appBar:
-          <PreferredSizeWidget>[
-            AppBar(
-              backgroundColor: Theme.of(context).colorScheme.inversePrimary,
-              title: Semantics(headingLevel: 1, child: const Text('AppBar')),
+      appBar: <PreferredSizeWidget>[
+        AppBar(
+          backgroundColor: Theme.of(context).colorScheme.inversePrimary,
+          title: Semantics(headingLevel: 1, child: const Text('AppBar')),
+        ),
+        AppBar(
+          backgroundColor: Theme.of(context).colorScheme.inversePrimary,
+          title: Semantics(headingLevel: 1, child: const Text('AppBar')),
+          actions: <Widget>[
+            IconButton(
+              icon: const Icon(Icons.add_alert),
+              tooltip: 'Show Snackbar',
+              onPressed: () {
+                ScaffoldMessenger.of(
+                  context,
+                ).showSnackBar(const SnackBar(content: Text('This is a snackbar')));
+              },
             ),
-            AppBar(
-              backgroundColor: Theme.of(context).colorScheme.inversePrimary,
-              title: Semantics(headingLevel: 1, child: const Text('AppBar')),
-              actions: <Widget>[
-                IconButton(
-                  icon: const Icon(Icons.add_alert),
-                  tooltip: 'Show Snackbar',
-                  onPressed: () {
-                    ScaffoldMessenger.of(
-                      context,
-                    ).showSnackBar(const SnackBar(content: Text('This is a snackbar')));
-                  },
-                ),
-                IconButton(
-                  icon: const Icon(Icons.navigate_next),
-                  tooltip: 'Go to the next page',
-                  onPressed: () {
-                    Navigator.push(
-                      context,
-                      MaterialPageRoute<void>(
-                        builder: (BuildContext context) {
-                          return Scaffold(
-                            appBar: AppBar(
-                              backgroundColor: Theme.of(context).colorScheme.inversePrimary,
-                              title: Semantics(headingLevel: 1, child: const Text('Next Page')),
-                            ),
-                            body: const Center(
-                              child: Text('This is the next page', style: TextStyle(fontSize: 24)),
-                            ),
-                          );
-                        },
-                      ),
-                    );
-                  },
-                ),
-              ],
+            IconButton(
+              icon: const Icon(Icons.navigate_next),
+              tooltip: 'Go to the next page',
+              onPressed: () {
+                Navigator.push(
+                  context,
+                  MaterialPageRoute<void>(
+                    builder: (BuildContext context) {
+                      return Scaffold(
+                        appBar: AppBar(
+                          backgroundColor: Theme.of(context).colorScheme.inversePrimary,
+                          title: Semantics(headingLevel: 1, child: const Text('Next Page')),
+                        ),
+                        body: const Center(
+                          child: Text('This is the next page', style: TextStyle(fontSize: 24)),
+                        ),
+                      );
+                    },
+                  ),
+                );
+              },
             ),
-            AppBar(
-              backgroundColor: Theme.of(context).colorScheme.inversePrimary,
-              title: Semantics(headingLevel: 1, child: const Text('AppBar')),
-              actions: <Widget>[
-                TextButton(onPressed: () {}, child: const Text('Action 1')),
-                TextButton(onPressed: () {}, child: const Text('Action 2')),
-              ],
-            ),
-          ][currentIndex],
+          ],
+        ),
+        AppBar(
+          backgroundColor: Theme.of(context).colorScheme.inversePrimary,
+          title: Semantics(headingLevel: 1, child: const Text('AppBar')),
+          actions: <Widget>[
+            TextButton(onPressed: () {}, child: const Text('Action 1')),
+            TextButton(onPressed: () {}, child: const Text('Action 2')),
+          ],
+        ),
+      ][currentIndex],
       body: ListView(
         children: <Widget>[
           RadioListTile<int>(

dev/a11y_assessments/lib/use_cases/badge.dart

@@ -36,7 +36,11 @@ class MainWidgetState extends State<MainWidget> {
       ),
       body: const Center(
         child: Badge(
-          label: Text('5', semanticsLabel: '5 new messages', style: TextStyle(color: Colors.white)),
+          label: Text(
+            '5',
+            semanticsLabel: '5 new messages',
+            style: TextStyle(color: Colors.white),
+          ),
           backgroundColor: Colors.green,
           child: Icon(Icons.mail, semanticLabel: 'Messages'),
         ),

dev/a11y_assessments/lib/use_cases/card.dart

@@ -40,7 +40,9 @@ class MainWidgetState extends State<MainWidget> {
         child: Column(
           mainAxisAlignment: MainAxisAlignment.center,
           children: <Widget>[
-            Card(child: Padding(padding: EdgeInsets.all(16), child: Text('Card'))),
+            Card(
+              child: Padding(padding: EdgeInsets.all(16), child: Text('Card')),
+            ),
           ],
         ),
       ),

dev/a11y_assessments/lib/use_cases/date_picker.dart

@@ -36,14 +36,13 @@ class _MainWidgetState extends State<_MainWidget> {
       ),
       body: Center(
         child: TextButton(
-          onPressed:
-              () => showDatePicker(
-                context: context,
-                initialEntryMode: DatePickerEntryMode.calendarOnly,
-                initialDate: DateTime.now(),
-                firstDate: DateTime.now().subtract(const Duration(days: 365)),
-                lastDate: DateTime.now().add(const Duration(days: 365)),
-              ),
+          onPressed: () => showDatePicker(
+            context: context,
+            initialEntryMode: DatePickerEntryMode.calendarOnly,
+            initialDate: DateTime.now(),
+            firstDate: DateTime.now().subtract(const Duration(days: 365)),
+            lastDate: DateTime.now().add(const Duration(days: 365)),
+          ),
           child: const Text('Show Date Picker'),
         ),
       ),

dev/a11y_assessments/lib/use_cases/dialog.dart

@@ -31,42 +31,40 @@ class _MainWidget extends StatelessWidget {
       ),
       body: Center(
         child: TextButton(
-          onPressed:
-              () => showDialog<String>(
-                context: context,
-                builder:
-                    (BuildContext context) => Dialog(
-                      child: Padding(
-                        padding: const EdgeInsets.all(8.0),
-                        child: Column(
-                          mainAxisSize: MainAxisSize.min,
-                          mainAxisAlignment: MainAxisAlignment.center,
-                          children: <Widget>[
-                            const Text('This is a typical dialog.'),
-                            const SizedBox(height: 15),
-                            Row(
-                              children: <Widget>[
-                                TextButton(
-                                  key: const Key('OK Button'),
-                                  autofocus: true,
-                                  onPressed: () {
-                                    Navigator.pop(context);
-                                  },
-                                  child: const Text('OK'),
-                                ),
-                                TextButton(
-                                  onPressed: () {
-                                    Navigator.pop(context);
-                                  },
-                                  child: const Text('Cancel'),
-                                ),
-                              ],
-                            ),
-                          ],
+          onPressed: () => showDialog<String>(
+            context: context,
+            builder: (BuildContext context) => Dialog(
+              child: Padding(
+                padding: const EdgeInsets.all(8.0),
+                child: Column(
+                  mainAxisSize: MainAxisSize.min,
+                  mainAxisAlignment: MainAxisAlignment.center,
+                  children: <Widget>[
+                    const Text('This is a typical dialog.'),
+                    const SizedBox(height: 15),
+                    Row(
+                      children: <Widget>[
+                        TextButton(
+                          key: const Key('OK Button'),
+                          autofocus: true,
+                          onPressed: () {
+                            Navigator.pop(context);
+                          },
+                          child: const Text('OK'),
                         ),
-                      ),
+                        TextButton(
+                          onPressed: () {
+                            Navigator.pop(context);
+                          },
+                          child: const Text('Cancel'),
+                        ),
+                      ],
                     ),
+                  ],
+                ),
               ),
+            ),
+          ),
           child: const Text('Show Dialog'),
         ),
       ),

dev/a11y_assessments/lib/use_cases/navigation_bar.dart

@@ -58,12 +58,11 @@ class MainWidgetState extends State<MainWidget> {
           ),
         ],
       ),
-      body:
-          <Widget>[
-            Container(alignment: Alignment.center, child: const Text('Page 1')),
-            Container(alignment: Alignment.center, child: const Text('Page 2')),
-            Container(alignment: Alignment.center, child: const Text('Page 3')),
-          ][currentPageIndex],
+      body: <Widget>[
+        Container(alignment: Alignment.center, child: const Text('Page 1')),
+        Container(alignment: Alignment.center, child: const Text('Page 2')),
+        Container(alignment: Alignment.center, child: const Text('Page 3')),
+      ][currentPageIndex],
     );
   }
 }

dev/a11y_assessments/lib/use_cases/navigation_rail.dart

@@ -47,25 +47,23 @@ class _NavRailExampleState extends State<NavRailExample> {
               });
             },
             labelType: labelType,
-            leading:
-                showLeading
-                    ? FloatingActionButton(
-                      elevation: 0,
-                      onPressed: () {
-                        // Add your onPressed code here!
-                      },
-                      child: const Icon(Icons.add),
-                    )
-                    : const SizedBox(),
-            trailing:
-                showTrailing
-                    ? IconButton(
-                      onPressed: () {
-                        // Add your onPressed code here!
-                      },
-                      icon: const Icon(Icons.more_horiz_rounded),
-                    )
-                    : const SizedBox(),
+            leading: showLeading
+                ? FloatingActionButton(
+                    elevation: 0,
+                    onPressed: () {
+                      // Add your onPressed code here!
+                    },
+                    child: const Icon(Icons.add),
+                  )
+                : const SizedBox(),
+            trailing: showTrailing
+                ? IconButton(
+                    onPressed: () {
+                      // Add your onPressed code here!
+                    },
+                    icon: const Icon(Icons.more_horiz_rounded),
+                  )
+                : const SizedBox(),
             destinations: const <NavigationRailDestination>[
               NavigationRailDestination(
                 icon: Icon(Icons.favorite_border),

dev/a11y_assessments/pubspec.yaml

@@ -3,7 +3,7 @@ description: A new Flutter project
 version: 5.0.0+5
 
 environment:
-  sdk: ^3.7.0-0
+  sdk: ^3.8.0-0
 
 resolution: workspace
 

dev/a11y_assessments/test/accessibility_guideline_test.dart

@@ -11,8 +11,9 @@ void main() {
   for (final UseCase useCase in useCases) {
     testWidgets('testing accessibility guideline for ${useCase.name}', (WidgetTester tester) async {
       await tester.pumpWidget(const App());
-      final ScrollController controller =
-          tester.state<HomePageState>(find.byType(HomePage)).scrollController;
+      final ScrollController controller = tester
+          .state<HomePageState>(find.byType(HomePage))
+          .scrollController;
       while (find.byKey(Key(useCase.name)).evaluate().isEmpty) {
         controller.jumpTo(controller.offset + 600);
         await tester.pumpAndSettle();