diff --git a/testing/run_tests.py b/testing/run_tests.py index 32b77d5397b04..f080cb2d48ad6 100755 --- a/testing/run_tests.py +++ b/testing/run_tests.py @@ -422,25 +422,27 @@ def make_test(name, flags=repeat_flags, extra_env={}): shuffle_flags, coverage=coverage ) + # TODO(117122): Re-enable impeller_unittests after shader compiler errors + # are addressed. # Impeller tests are only supported on macOS for now. - RunEngineExecutable( - build_dir, - 'impeller_unittests', - filter, - shuffle_flags, - coverage=coverage, - extra_env={ - # See https://developer.apple.com/documentation/metal/diagnosing_metal_programming_issues_early?language=objc - 'MTL_SHADER_VALIDATION': - '1', # Enables all shader validation tests. - 'MTL_SHADER_VALIDATION_GLOBAL_MEMORY': - '1', # Validates accesses to device and constant memory. - 'MTL_SHADER_VALIDATION_THREADGROUP_MEMORY': - '1', # Validates accesses to threadgroup memory. - 'MTL_SHADER_VALIDATION_TEXTURE_USAGE': - '1', # Validates that texture references are not nil. - } - ) + # RunEngineExecutable( + # build_dir, + # 'impeller_unittests', + # filter, + # shuffle_flags, + # coverage=coverage, + # extra_env={ + # # See https://developer.apple.com/documentation/metal/diagnosing_metal_programming_issues_early?language=objc + # 'MTL_SHADER_VALIDATION': + # '1', # Enables all shader validation tests. + # 'MTL_SHADER_VALIDATION_GLOBAL_MEMORY': + # '1', # Validates accesses to device and constant memory. + # 'MTL_SHADER_VALIDATION_THREADGROUP_MEMORY': + # '1', # Validates accesses to threadgroup memory. + # 'MTL_SHADER_VALIDATION_TEXTURE_USAGE': + # '1', # Validates that texture references are not nil. + # } + # ) def ParseImpellerVulkanFilter():