From cc5e883b7bbf874ca34815d32bb0c7a03faf0c6d Mon Sep 17 00:00:00 2001 From: Jason Simmons Date: Wed, 11 Dec 2019 11:13:42 -0800 Subject: [PATCH] Do not assume that createTypeface is called before getStyle in the AssetManagerFontStyleSet --- lib/ui/text/asset_manager_font_provider.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/ui/text/asset_manager_font_provider.cc b/lib/ui/text/asset_manager_font_provider.cc index 07a4a66f2f2f1..805376dd3131d 100644 --- a/lib/ui/text/asset_manager_font_provider.cc +++ b/lib/ui/text/asset_manager_font_provider.cc @@ -84,7 +84,10 @@ void AssetManagerFontStyleSet::getStyle(int index, SkString* name) { FML_DCHECK(index < static_cast(assets_.size())); if (style) { - *style = assets_[index].typeface->fontStyle(); + sk_sp typeface(createTypeface(index)); + if (typeface) { + *style = typeface->fontStyle(); + } } if (name) { *name = family_name_.c_str();