Skip to content

fix(flow-php/postgresql): count ParamRef nodes inside List expressions during AST traversal#2431

Merged
norberttech merged 1 commit into
1.xfrom
pagination-param-offset-bug
Jun 6, 2026
Merged

fix(flow-php/postgresql): count ParamRef nodes inside List expressions during AST traversal#2431
norberttech merged 1 commit into
1.xfrom
pagination-param-offset-bug

Conversation

@norberttech

Copy link
Copy Markdown
Member

Change Log


Added

Fixed

  • flow-php/postgresql - detect ParamRef nodes inside List expressions so BETWEEN/IN/VALUES placeholders are counted during keyset pagination offset.

Changed

Removed

Deprecated

Security

…s during AST traversal

- descend into PBList items so BETWEEN/IN/VALUES placeholders are
detected
- fixes keyset pagination param offset colliding with base query params
@norberttech norberttech added this to the 0.40.0 milestone Jun 6, 2026
@norberttech norberttech moved this from Todo to In Progress in Roadmap Jun 6, 2026
@norberttech norberttech merged commit a760492 into 1.x Jun 6, 2026
36 checks passed
@norberttech norberttech deleted the pagination-param-offset-bug branch June 6, 2026 16:03
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Roadmap Jun 6, 2026
@codecov

codecov Bot commented Jun 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.94%. Comparing base (4600612) to head (356fb72).
⚠️ Report is 4 commits behind head on 1.x.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##                1.x    #2431      +/-   ##
============================================
+ Coverage     84.73%   84.94%   +0.21%     
- Complexity    20649    20650       +1     
============================================
  Files          1570     1570              
  Lines         63537    63540       +3     
============================================
+ Hits          53839    53975     +136     
+ Misses         9698     9565     -133     
Components Coverage Δ
etl 89.34% <ø> (+0.97%) ⬆️
cli 89.40% <ø> (ø)
lib-array-dot 81.44% <ø> (ø)
lib-azure-sdk 64.44% <ø> (ø)
lib-doctrine-dbal-bulk 93.61% <ø> (ø)
lib-filesystem 85.03% <ø> (ø)
lib-types 91.98% <ø> (+1.70%) ⬆️
lib-parquet 68.89% <ø> (ø)
lib-parquet-viewer 82.26% <ø> (ø)
lib-snappy 90.26% <ø> (+1.32%) ⬆️
lib-dremel 0.00% <ø> (ø)
lib-postgresql 88.58% <100.00%> (+<0.01%) ⬆️
lib-telemetry 84.31% <ø> (ø)
bridge-filesystem-async-aws 92.74% <ø> (ø)
bridge-filesystem-azure 90.45% <ø> (ø)
bridge-monolog-http 97.86% <ø> (ø)
bridge-monolog-telemetry 94.11% <ø> (ø)
bridge-openapi-specification 92.07% <ø> (ø)
symfony-http-foundation 78.57% <ø> (ø)
bridge-psr18-telemetry 100.00% <ø> (ø)
bridge-psr3-telemetry 97.84% <ø> (ø)
bridge-psr7-telemetry 100.00% <ø> (ø)
bridge-telemetry-otlp 90.50% <ø> (ø)
bridge-symfony-http-foundation-telemetry 89.47% <ø> (ø)
bridge-symfony-filesystem-bundle 91.54% <ø> (ø)
bridge-symfony-filesystem-cache 98.14% <ø> (ø)
bridge-symfony-postgresql-bundle 94.55% <ø> (ø)
bridge-symfony-postgresql-cache 94.41% <ø> (ø)
bridge-symfony-postgresql-messenger 98.80% <ø> (ø)
bridge-symfony-postgresql-session 93.65% <ø> (ø)
bridge-symfony-telemetry-bundle 76.00% <ø> (ø)
adapter-chartjs 84.05% <ø> (ø)
adapter-csv 91.16% <ø> (ø)
adapter-doctrine 90.79% <ø> (ø)
adapter-elasticsearch 92.07% <ø> (ø)
adapter-google-sheet 99.18% <ø> (ø)
adapter-http 73.04% <ø> (+0.70%) ⬆️
adapter-json 88.63% <ø> (ø)
adapter-logger 50.00% <ø> (ø)
adapter-parquet 81.75% <ø> (ø)
adapter-text 74.13% <ø> (ø)
adapter-xml 83.40% <ø> (ø)
adapter-avro 0.00% <ø> (ø)
adapter-excel 94.21% <ø> (ø)
adapter-postgresql 90.89% <ø> (+0.33%) ⬆️
bridge-phpunit-postgresql 75.30% <ø> (ø)
bridge-phpunit-telemetry 80.09% <ø> (ø)
bridge-phpstan-types 0.00% <ø> (ø)
bridge-postgresql-valinor 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant