Do not show a tooltip when the stack index of the hovered sample is null, instead of crashing#4376
Conversation
…ull, instead of crashing Fixes firefox-devtools#4363
Codecov ReportBase: 88.35% // Head: 88.34% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4376 +/- ##
==========================================
- Coverage 88.35% 88.34% -0.01%
==========================================
Files 282 282
Lines 25383 25370 -13
Branches 6830 6830
==========================================
- Hits 22428 22414 -14
- Misses 2742 2743 +1
Partials 213 213
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
canova
left a comment
There was a problem hiding this comment.
Nice, thanks for the fix. It would be good to have a small test to make sure we don't regress this later too. But it might be hard to write a test for it. Do you have an idea?
|
I thought of that too: I spent about 1 hour to try to make one but couldn't make it fail on master... So in the end I thought it was better to push the fix without a test. |
Fixes #4363
This also fixes .#4309, but I'd like to keep that one open because there's an obvious bug in the active tab view.
production
deploy preview
The STR is: move the mouse over the filtered out part in the activity graph.