Skip to content

Do not show a tooltip when the stack index of the hovered sample is null, instead of crashing#4376

Merged
julienw merged 2 commits into
firefox-devtools:mainfrom
julienw:4363-sample-tooltip-crash
Dec 20, 2022
Merged

Do not show a tooltip when the stack index of the hovered sample is null, instead of crashing#4376
julienw merged 2 commits into
firefox-devtools:mainfrom
julienw:4363-sample-tooltip-crash

Conversation

@julienw
Copy link
Copy Markdown
Contributor

@julienw julienw commented Dec 15, 2022

Fixes #4363

This also fixes .#4309, but I'd like to keep that one open because there's an obvious bug in the active tab view.

production
deploy preview

The STR is: move the mouse over the filtered out part in the activity graph.

@julienw julienw requested a review from canova December 15, 2022 17:26
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 15, 2022

Codecov Report

Base: 88.35% // Head: 88.34% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (cbb2727) compared to base (f3cfe76).
Patch coverage: 50.00% of modified lines in pull request are covered.

❗ Current head cbb2727 differs from pull request most recent head 8c31162. Consider uploading reports for the commit 8c31162 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4376      +/-   ##
==========================================
- Coverage   88.35%   88.34%   -0.01%     
==========================================
  Files         282      282              
  Lines       25383    25370      -13     
  Branches     6830     6830              
==========================================
- Hits        22428    22414      -14     
- Misses       2742     2743       +1     
  Partials      213      213              
Impacted Files Coverage Δ
src/components/shared/thread/ActivityGraphFills.js 96.11% <50.00%> (-0.35%) ⬇️
src/profile-logic/marker-data.js 93.64% <0.00%> (-0.13%) ⬇️
src/selectors/publish.js 96.87% <0.00%> (ø)
src/components/tooltip/Marker.js 98.44% <0.00%> (ø)
src/profile-logic/marker-schema.js 89.18% <0.00%> (ø)
src/components/marker-table/index.js 88.40% <0.00%> (ø)
src/components/tooltip/TrackPower.js 100.00% <0.00%> (ø)
src/profile-logic/sanitize.js 96.55% <0.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Member

@canova canova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the fix. It would be good to have a small test to make sure we don't regress this later too. But it might be hard to write a test for it. Do you have an idea?

@julienw
Copy link
Copy Markdown
Contributor Author

julienw commented Dec 19, 2022

I thought of that too: I spent about 1 hour to try to make one but couldn't make it fail on master... So in the end I thought it was better to push the fix without a test.

@julienw julienw enabled auto-merge (squash) December 20, 2022 14:29
@julienw julienw merged commit 64cdd7e into firefox-devtools:main Dec 20, 2022
@julienw julienw mentioned this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The UI breaks when hovering the activity graph in this profile

2 participants