{zero}{one}
);
@@ -410,7 +408,7 @@ describe('ReactChildren', function() {
var instance = (
{
- [frag({
+ [ReactFragment.create({
firstHalfKey: [zero, one, two],
secondHalfKey: [three, four],
keyFive: five
@@ -438,7 +436,7 @@ describe('ReactChildren', function() {
return c;
});
for (var key in frag) {
- frag[key];
+ void frag[key];
break;
}
expect(console.error.calls.length).toBe(1);
@@ -447,8 +445,8 @@ describe('ReactChildren', function() {
var frag2 = ReactChildren.map([child, child], function(c) {
return c;
});
- for (var key in frag2) {
- frag2[key] = 123;
+ for (var key2 in frag2) {
+ frag2[key2] = 123;
break;
}
expect(console.error.calls.length).toBe(2);
diff --git a/src/isomorphic/classic/__tests__/ReactContextValidator-test.js b/src/isomorphic/classic/__tests__/ReactContextValidator-test.js
index 7f79c1fb10f..d7252a3f9c7 100644
--- a/src/isomorphic/classic/__tests__/ReactContextValidator-test.js
+++ b/src/isomorphic/classic/__tests__/ReactContextValidator-test.js
@@ -21,7 +21,6 @@ var React;
var ReactTestUtils;
var reactComponentExpect;
-var mocks;
describe('ReactContextValidator', function() {
beforeEach(function() {
@@ -30,7 +29,6 @@ describe('ReactContextValidator', function() {
React = require('React');
ReactTestUtils = require('ReactTestUtils');
reactComponentExpect = require('reactComponentExpect');
- mocks = require('mocks');
spyOn(console, 'error');
});
@@ -86,7 +84,7 @@ describe('ReactContextValidator', function() {
getChildContext: function() {
return {
foo: this.props.foo,
- bar: "bar"
+ bar: 'bar'
};
},
@@ -125,7 +123,7 @@ describe('ReactContextValidator', function() {
var instance = >';
var dateName = Date.name || '<>';
@@ -313,7 +313,7 @@ describe('ReactPropTypes', function() {
);
});
- it("should not warn for valid values", function() {
+ it('should not warn for valid values', function() {
function Person() {}
function Engineer() {}
Engineer.prototype = new Person();
@@ -325,12 +325,12 @@ describe('ReactPropTypes', function() {
typeCheckPass(PropTypes.instanceOf(RegExp), /please/);
});
- it("should be implicitly optional and not warn without values", function() {
+ it('should be implicitly optional and not warn without values', function() {
typeCheckPass(PropTypes.instanceOf(String), null);
typeCheckPass(PropTypes.instanceOf(String), undefined);
});
- it("should warn for missing required values", function() {
+ it('should warn for missing required values', function() {
typeCheckFail(
PropTypes.instanceOf(String).isRequired, null, requiredMessage
);
@@ -500,12 +500,12 @@ describe('ReactPropTypes', function() {
typeCheckPass(PropTypes.objectOf(PropTypes.number), {});
});
- it("should be implicitly optional and not warn without values", function() {
+ it('should be implicitly optional and not warn without values', function() {
typeCheckPass(PropTypes.objectOf(PropTypes.number), null);
typeCheckPass(PropTypes.objectOf(PropTypes.number), undefined);
});
- it("should warn for missing required values", function() {
+ it('should warn for missing required values', function() {
typeCheckFail(
PropTypes.objectOf(PropTypes.number).isRequired,
null,
@@ -520,7 +520,7 @@ describe('ReactPropTypes', function() {
});
describe('OneOf Types', function() {
- it("should fail for invalid argument", function() {
+ it('should fail for invalid argument', function() {
typeCheckFail(
PropTypes.oneOf('red', 'blue'),
'red',
@@ -528,7 +528,7 @@ describe('ReactPropTypes', function() {
);
});
- it("should warn for invalid strings", function() {
+ it('should warn for invalid strings', function() {
typeCheckFail(
PropTypes.oneOf(['red', 'blue']),
true,
@@ -555,17 +555,17 @@ describe('ReactPropTypes', function() {
);
});
- it("should not warn for valid values", function() {
+ it('should not warn for valid values', function() {
typeCheckPass(PropTypes.oneOf(['red', 'blue']), 'red');
typeCheckPass(PropTypes.oneOf(['red', 'blue']), 'blue');
});
- it("should be implicitly optional and not warn without values", function() {
+ it('should be implicitly optional and not warn without values', function() {
typeCheckPass(PropTypes.oneOf(['red', 'blue']), null);
typeCheckPass(PropTypes.oneOf(['red', 'blue']), undefined);
});
- it("should warn for missing required values", function() {
+ it('should warn for missing required values', function() {
typeCheckFail(
PropTypes.oneOf(['red', 'blue']).isRequired,
null,
@@ -580,7 +580,7 @@ describe('ReactPropTypes', function() {
});
describe('Union Types', function() {
- it("should fail for invalid argument", function() {
+ it('should fail for invalid argument', function() {
typeCheckFail(
PropTypes.oneOfType(PropTypes.string, PropTypes.number),
'red',
@@ -623,7 +623,7 @@ describe('ReactPropTypes', function() {
typeCheckPass(checker, {b: 1});
});
- it("should be implicitly optional and not warn without values", function() {
+ it('should be implicitly optional and not warn without values', function() {
typeCheckPass(
PropTypes.oneOfType([PropTypes.string, PropTypes.number]), null
);
@@ -632,7 +632,7 @@ describe('ReactPropTypes', function() {
);
});
- it("should warn for missing required values", function() {
+ it('should warn for missing required values', function() {
typeCheckFail(
PropTypes.oneOfType([PropTypes.string, PropTypes.number]).isRequired,
null,
@@ -647,7 +647,7 @@ describe('ReactPropTypes', function() {
});
describe('Shape Types', function() {
- it("should warn for non objects", function() {
+ it('should warn for non objects', function() {
typeCheckFail(
PropTypes.shape({}),
'some string',
@@ -662,25 +662,25 @@ describe('ReactPropTypes', function() {
);
});
- it("should not warn for empty values", function() {
+ it('should not warn for empty values', function() {
typeCheckPass(PropTypes.shape({}), undefined);
typeCheckPass(PropTypes.shape({}), null);
typeCheckPass(PropTypes.shape({}), {});
});
- it("should not warn for an empty object", function() {
+ it('should not warn for an empty object', function() {
typeCheckPass(PropTypes.shape({}).isRequired, {});
});
- it("should not warn for non specified types", function() {
+ it('should not warn for non specified types', function() {
typeCheckPass(PropTypes.shape({}), {key: 1});
});
- it("should not warn for valid types", function() {
+ it('should not warn for valid types', function() {
typeCheckPass(PropTypes.shape({key: PropTypes.number}), {key: 1});
});
- it("should warn for required valid types", function() {
+ it('should warn for required valid types', function() {
typeCheckFail(
PropTypes.shape({key: PropTypes.number.isRequired}),
{},
@@ -688,7 +688,7 @@ describe('ReactPropTypes', function() {
);
});
- it("should warn for the first required type", function() {
+ it('should warn for the first required type', function() {
typeCheckFail(
PropTypes.shape({
key: PropTypes.number.isRequired,
@@ -699,7 +699,7 @@ describe('ReactPropTypes', function() {
);
});
- it("should warn for invalid key types", function() {
+ it('should warn for invalid key types', function() {
typeCheckFail(PropTypes.shape({key: PropTypes.number}),
{key: 'abc'},
'Invalid prop `testProp.key` of type `string` supplied to `testComponent`, ' +
@@ -707,7 +707,7 @@ describe('ReactPropTypes', function() {
);
});
- it("should be implicitly optional and not warn without values", function() {
+ it('should be implicitly optional and not warn without values', function() {
typeCheckPass(
PropTypes.shape(PropTypes.shape({key: PropTypes.number})), null
);
@@ -716,7 +716,7 @@ describe('ReactPropTypes', function() {
);
});
- it("should warn for missing required values", function() {
+ it('should warn for missing required values', function() {
typeCheckFail(
PropTypes.shape({key: PropTypes.number}).isRequired,
null,
@@ -738,7 +738,7 @@ describe('ReactPropTypes', function() {
it('should have been called with the right params', function() {
var spy = jasmine.createSpy();
- var Component = React.createClass({
+ Component = React.createClass({
propTypes: {num: spy},
render: function() {
@@ -756,7 +756,7 @@ describe('ReactPropTypes', function() {
it('should have been called even if the prop is not present', function() {
var spy = jasmine.createSpy();
- var Component = React.createClass({
+ Component = React.createClass({
propTypes: {num: spy},
render: function() {
@@ -778,7 +778,7 @@ describe('ReactPropTypes', function() {
}
}
);
- var Component = React.createClass({
+ Component = React.createClass({
propTypes: {num: spy},
render: function() {
@@ -790,7 +790,8 @@ describe('ReactPropTypes', function() {
instance = ReactTestUtils.renderIntoDocument(instance);
expect(console.error.argsForCall.length).toBe(1);
expect(console.error.argsForCall[0][0]).toBe(
- 'Warning: Failed propType: num must be 5!');
+ 'Warning: Failed propType: num must be 5!'
+ );
});
it('should not warn if the validator returned null',
@@ -800,7 +801,7 @@ describe('ReactPropTypes', function() {
return null;
}
);
- var Component = React.createClass({
+ Component = React.createClass({
propTypes: {num: spy},
render: function() {
diff --git a/src/isomorphic/deprecated/__tests__/cloneWithProps-test.js b/src/isomorphic/deprecated/__tests__/cloneWithProps-test.js
index 9ef5d7fa123..6869fbcaaa9 100644
--- a/src/isomorphic/deprecated/__tests__/cloneWithProps-test.js
+++ b/src/isomorphic/deprecated/__tests__/cloneWithProps-test.js
@@ -15,8 +15,6 @@ require('mock-modules')
.dontMock('cloneWithProps')
.dontMock('emptyObject');
-var mocks = require('mocks');
-
var React;
var ReactTestUtils;
diff --git a/src/isomorphic/modern/class/__tests__/ReactClassEquivalence-test.js b/src/isomorphic/modern/class/__tests__/ReactClassEquivalence-test.js
index cd342ad4874..f38d2718c15 100644
--- a/src/isomorphic/modern/class/__tests__/ReactClassEquivalence-test.js
+++ b/src/isomorphic/modern/class/__tests__/ReactClassEquivalence-test.js
@@ -9,6 +9,8 @@
* @emails react-core
*/
+'use strict';
+
var MetaMatchers = require('MetaMatchers');
describe('ReactClassEquivalence', function() {
diff --git a/src/isomorphic/modern/element/__tests__/ReactJSXElement-test.js b/src/isomorphic/modern/element/__tests__/ReactJSXElement-test.js
index ddc319003c2..25a0b266805 100644
--- a/src/isomorphic/modern/element/__tests__/ReactJSXElement-test.js
+++ b/src/isomorphic/modern/element/__tests__/ReactJSXElement-test.js
@@ -11,8 +11,6 @@
'use strict';
-var mocks;
-
var React;
var ReactTestUtils;
@@ -22,12 +20,12 @@ describe('ReactJSXElement', function() {
beforeEach(function() {
require('mock-modules').dumpCache();
- mocks = require('mocks');
-
React = require('React');
ReactTestUtils = require('ReactTestUtils');
Component = class {
- render() { return ; }
+ render() {
+ return ;
+ }
};
});
@@ -145,7 +143,7 @@ describe('ReactJSXElement', function() {
expect(React.isValidElement(null)).toEqual(false);
expect(React.isValidElement(true)).toEqual(false);
expect(React.isValidElement({})).toEqual(false);
- expect(React.isValidElement("string")).toEqual(false);
+ expect(React.isValidElement('string')).toEqual(false);
expect(React.isValidElement(Component)).toEqual(false);
});
diff --git a/src/isomorphic/modern/element/__tests__/ReactJSXElementValidator-test.js b/src/isomorphic/modern/element/__tests__/ReactJSXElementValidator-test.js
index 1e15d2d3b95..47dde237640 100644
--- a/src/isomorphic/modern/element/__tests__/ReactJSXElementValidator-test.js
+++ b/src/isomorphic/modern/element/__tests__/ReactJSXElementValidator-test.js
@@ -29,7 +29,9 @@ describe('ReactJSXElementValidator', function() {
ReactTestUtils = require('ReactTestUtils');
Component = class {
- render() { return ; }
+ render() {
+ return ;
+ }
};
});
@@ -40,7 +42,7 @@ describe('ReactJSXElementValidator', function() {
it('warns for keys for arrays of elements in children position', function() {
spyOn(console, 'error');
- {[ ;
+ void {[ ;
expect(console.error.argsForCall.length).toBe(1);
expect(console.error.argsForCall[0][0]).toContain(
@@ -55,7 +57,7 @@ describe('ReactJSXElementValidator', function() {
render() {
return {this.props.childSet} ;
}
- };
+ }
class ComponentWrapper {
render() {
@@ -65,7 +67,7 @@ describe('ReactJSXElementValidator', function() {
/>
);
}
- };
+ }
ReactTestUtils.renderIntoDocument({iterable} ;
+ void {iterable} ;
expect(console.error.argsForCall.length).toBe(1);
expect(console.error.argsForCall[0][0]).toContain(
@@ -103,7 +105,7 @@ describe('ReactJSXElementValidator', function() {
it('does not warns for arrays of elements with keys', function() {
spyOn(console, 'error');
- {[ ;
+ void {[ ;
expect(console.error.argsForCall.length).toBe(0);
});
@@ -126,7 +128,7 @@ describe('ReactJSXElementValidator', function() {
}
};
- {iterable}
+ void {iterable} ;
expect(console.error.argsForCall.length).toBe(0);
});
@@ -134,7 +136,7 @@ describe('ReactJSXElementValidator', function() {
it('warns for numeric keys on objects as children', function() {
spyOn(console, 'error');
- {frag({1: ;
+ void {frag({1: ;
expect(console.error.argsForCall.length).toBe(1);
expect(console.error.argsForCall[0][0]).toContain(
@@ -158,7 +160,7 @@ describe('ReactJSXElementValidator', function() {
};
iterable.entries = iterable['@@iterator'];
- {iterable} ;
+ void {iterable} ;
expect(console.error.argsForCall.length).toBe(0);
});
@@ -166,7 +168,7 @@ describe('ReactJSXElementValidator', function() {
it('does not warn when the element is directly as children', function() {
spyOn(console, 'error');
- {[ {}, {} ]} ;
+ void {[ {}, {} ]} ;
expect(console.error.argsForCall.length).toBe(0);
});
@@ -215,10 +217,10 @@ describe('ReactJSXElementValidator', function() {
var Num = 123;
var Div = 'div';
spyOn(console, 'error');
-
;
}
});
@@ -88,7 +88,7 @@ describe('ReactCompositeComponentNestedState-state', function() {
var logger = mocks.getMockFunction();
- var instance = React.render(
+ void React.render(
,
diff --git a/src/renderers/dom/client/__tests__/ReactDOMIDOperations-test.js b/src/renderers/dom/client/__tests__/ReactDOMIDOperations-test.js
index 83ebbe03956..be744c7a5fd 100644
--- a/src/renderers/dom/client/__tests__/ReactDOMIDOperations-test.js
+++ b/src/renderers/dom/client/__tests__/ReactDOMIDOperations-test.js
@@ -18,8 +18,8 @@ describe('ReactDOMIDOperations', function() {
var keyOf = require('keyOf');
it('should disallow updating special properties', function() {
- spyOn(ReactMount, "getNode");
- spyOn(DOMPropertyOperations, "setValueForProperty");
+ spyOn(ReactMount, 'getNode');
+ spyOn(DOMPropertyOperations, 'setValueForProperty');
expect(function() {
ReactDOMIDOperations.updatePropertyByID(
@@ -40,7 +40,7 @@ describe('ReactDOMIDOperations', function() {
it('should update innerHTML and preserve whitespace', function() {
var stubNode = document.createElement('div');
- spyOn(ReactMount, "getNode").andReturn(stubNode);
+ spyOn(ReactMount, 'getNode').andReturn(stubNode);
var html = '\n \t \n testContent \t \n \t';
diff --git a/src/renderers/dom/client/__tests__/ReactMount-test.js b/src/renderers/dom/client/__tests__/ReactMount-test.js
index bba0ee9b4fa..e8c4e25d288 100644
--- a/src/renderers/dom/client/__tests__/ReactMount-test.js
+++ b/src/renderers/dom/client/__tests__/ReactMount-test.js
@@ -169,25 +169,27 @@ describe('ReactMount', function() {
);
});
- (WebComponents === undefined ? xit : it)
- ('should allow mounting/unmounting to document fragment container', function() {
- var shadowRoot;
- var proto = Object.create(HTMLElement.prototype, {
- createdCallback: {
- value: function() {
+ if (WebComponents !== undefined) {
+ it('should allow mounting/unmounting to document fragment container',
+ function() {
+ var shadowRoot;
+ var proto = Object.create(HTMLElement.prototype, {
+ createdCallback: {
+ value: function() {
shadowRoot = this.createShadowRoot();
React.render(![]()
, container);
+ React.render(![]()
, container);
expect(container.firstChild.hasAttribute('height')).toBe(true);
React.render(![]()
, container);
expect(container.firstChild.hasAttribute('height')).toBe(false);
});
- it("should remove properties", function() {
+ it('should remove properties', function() {
var container = document.createElement('div');
- React.render(, container);
+ React.render(, container);
expect(container.firstChild.className).toEqual('monkey');
React.render(, container);
expect(container.firstChild.className).toEqual('');
});
- it("should clear a single style prop when changing 'style'", function() {
+ it('should clear a single style prop when changing `style`', function() {
var styles = {display: 'none', color: 'red'};
var container = document.createElement('div');
React.render(, container);
@@ -203,7 +203,7 @@ describe('ReactDOMComponent', function() {
expect(stubStyle.color).toEqual('green');
});
- it("should clear all the styles when removing 'style'", function() {
+ it('should clear all the styles when removing `style`', function() {
var styles = {display: 'none', color: 'red'};
var container = document.createElement('div');
React.render(, container);
@@ -215,7 +215,7 @@ describe('ReactDOMComponent', function() {
expect(stubStyle.color).toEqual('');
});
- it("should update styles when 'style' changes from null to object", function() {
+ it('should update styles when `style` changes from null to object', function() {
var container = document.createElement('div');
var styles = {color: 'red'};
React.render(, container);
@@ -226,7 +226,7 @@ describe('ReactDOMComponent', function() {
expect(stubStyle.color).toEqual('red');
});
- it("should empty element when removing innerHTML", function() {
+ it('should empty element when removing innerHTML', function() {
var container = document.createElement('div');
React.render(, container);
@@ -235,7 +235,7 @@ describe('ReactDOMComponent', function() {
expect(container.firstChild.innerHTML).toEqual('');
});
- it("should transition from string content to innerHTML", function() {
+ it('should transition from string content to innerHTML', function() {
var container = document.createElement('div');
React.render(|
});
var Table = React.createClass({
- render: function() { return {this.props.children}
; }
+ render: function() {
+ return {this.props.children}
;
+ }
});
var FancyTable = React.createClass({
- render: function() { return {this.props.children}
; }
+ render: function() {
+ return {this.props.children}
;
+ }
});
var Viz1 = React.createClass({
@@ -833,7 +835,9 @@ describe('ReactDOMComponent', function() {
);
var Link = React.createClass({
- render: function() { return {this.props.children}; }
+ render: function() {
+ return {this.props.children};
+ }
});
ReactTestUtils.renderIntoDocument();
expect(console.error.calls.length).toBe(6);
diff --git a/src/renderers/shared/event/__tests__/EventPluginHub-test.js b/src/renderers/shared/event/__tests__/EventPluginHub-test.js
index 9a54b7b245d..9caf5896ad0 100644
--- a/src/renderers/shared/event/__tests__/EventPluginHub-test.js
+++ b/src/renderers/shared/event/__tests__/EventPluginHub-test.js
@@ -26,7 +26,7 @@ describe('EventPluginHub', function() {
isEventSupported.mockReturnValueOnce(false);
});
- it("should prevent non-function listeners", function() {
+ it('should prevent non-function listeners', function() {
expect(function() {
EventPluginHub.putListener(1, 'onClick', 'not a function');
}).toThrow(
diff --git a/src/renderers/shared/event/eventPlugins/__tests__/ResponderEventPlugin-test.js b/src/renderers/shared/event/eventPlugins/__tests__/ResponderEventPlugin-test.js
index 57ffd5d3233..fef18598670 100644
--- a/src/renderers/shared/event/eventPlugins/__tests__/ResponderEventPlugin-test.js
+++ b/src/renderers/shared/event/eventPlugins/__tests__/ResponderEventPlugin-test.js
@@ -13,10 +13,8 @@
var EventPluginHub;
var EventConstants;
-var EventPropagators;
var ReactInstanceHandles;
var ResponderEventPlugin;
-var SyntheticEvent;
var EventPluginUtils;
var GRANDPARENT_ID = '.0';
@@ -25,7 +23,6 @@ var CHILD_ID = '.0.0.0';
var CHILD_ID2 = '.0.0.1';
var topLevelTypes;
-var responderEventTypes;
var touch = function(nodeHandle, i) {
return {target: nodeHandle, identifier: i};
@@ -88,7 +85,7 @@ var _touchConfig =
),
topLevelType: topType,
target: targetNodeHandle,
- targetID: targetNodeHandle,
+ targetID: targetNodeHandle
};
};
@@ -180,13 +177,13 @@ var oneEventLoopTestConfig = function(readableIDToID) {
responderTerminationRequest: {},
// Non-negotiation
- responderReject: {}, // These do not bubble capture.
+ responderReject: {}, // These do not bubble capture.
responderGrant: {},
responderStart: {},
responderMove: {},
responderTerminate: {},
responderEnd: {},
- responderRelease: {},
+ responderRelease: {}
};
for (var eventName in ret) {
for (var readableNodeName in readableIDToID) {
@@ -218,23 +215,29 @@ var registerTestHandlers = function(eventTestConfig, readableIDToID) {
'\nFor event test config:\n' + JSON.stringify(eventTestConfig) + '\n'
);
};
+ /*eslint-disable no-loop-func, no-shadow */
var registerOneEventType = function(registrationName, eventTypeTestConfig) {
for (var readableID in eventTypeTestConfig) {
var nodeConfig = eventTypeTestConfig[readableID];
var id = readableIDToID[readableID];
var handler = nodeConfig.order === NA ? neverFire.bind(null, readableID, registrationName) :
- function(readableID, registrationName, nodeConfig, e) {
+ // We partially apply readableID and nodeConfig, as they change in the
+ // parent closure across iterations.
+ function(readableID, nodeConfig, e) {
expect(
readableID + '->' + registrationName + ' index:' + runs.dispatchCount++
).toBe(
readableID + '->' + registrationName + ' index:' + nodeConfig.order
);
- nodeConfig.assertEvent && nodeConfig.assertEvent(e);
+ if (nodeConfig.assertEvent) {
+ nodeConfig.assertEvent(e);
+ }
return nodeConfig.returnVal;
- }.bind(null, readableID, registrationName, nodeConfig);
+ }.bind(null, readableID, nodeConfig);
EventPluginHub.putListener(id, registrationName, handler);
}
};
+ /*eslint-enable no-loop-func, no-shadow */
for (var eventName in eventTestConfig) {
var oneEventTypeTestConfig = eventTestConfig[eventName];
var hasTwoPhase = !!oneEventTypeTestConfig.bubbled;
@@ -306,13 +309,13 @@ var run = function(config, hierarchyConfig, nativeEventConfig) {
var three = {
grandParent: GRANDPARENT_ID,
parent: PARENT_ID,
- child: CHILD_ID,
+ child: CHILD_ID
};
var siblings = {
parent: PARENT_ID,
childOne: CHILD_ID,
- childTwo: CHILD_ID2,
+ childTwo: CHILD_ID2
};
describe('ResponderEventPlugin', function() {
@@ -322,10 +325,8 @@ describe('ResponderEventPlugin', function() {
EventConstants = require('EventConstants');
EventPluginHub = require('EventPluginHub');
EventPluginUtils = require('EventPluginUtils');
- EventPropagators = require('EventPropagators');
ReactInstanceHandles = require('ReactInstanceHandles');
ResponderEventPlugin = require('ResponderEventPlugin');
- SyntheticEvent = require('SyntheticEvent');
EventPluginHub.injection.injectInstanceHandle(ReactInstanceHandles);
@@ -341,17 +342,16 @@ describe('ResponderEventPlugin', function() {
});
topLevelTypes = EventConstants.topLevelTypes;
- responderEventTypes = ResponderEventPlugin.eventTypes;
});
it('should do nothing when no one wants to respond', function() {
var config = oneEventLoopTestConfig(three);
config.startShouldSetResponder.captured.grandParent = {order: 0, returnVal: false};
- config.startShouldSetResponder.captured.parent = {order: 1, returnVal: false};
- config.startShouldSetResponder.captured.child = {order: 2, returnVal: false};
- config.startShouldSetResponder.bubbled.child = {order: 3, returnVal: false};
- config.startShouldSetResponder.bubbled.parent = {order: 4, returnVal: false};
- config.startShouldSetResponder.bubbled.grandParent = {order: 5, returnVal: false};
+ config.startShouldSetResponder.captured.parent = {order: 1, returnVal: false};
+ config.startShouldSetResponder.captured.child = {order: 2, returnVal: false};
+ config.startShouldSetResponder.bubbled.child = {order: 3, returnVal: false};
+ config.startShouldSetResponder.bubbled.parent = {order: 4, returnVal: false};
+ config.startShouldSetResponder.bubbled.grandParent = {order: 5, returnVal: false};
run(config, three, startConfig(three.child, [three.child], [0]));
expect(ResponderEventPlugin.getResponderID()).toBe(null);
diff --git a/src/renderers/shared/reconciler/__tests__/ReactComponent-test.js b/src/renderers/shared/reconciler/__tests__/ReactComponent-test.js
index 675672acb53..6b93a951d12 100644
--- a/src/renderers/shared/reconciler/__tests__/ReactComponent-test.js
+++ b/src/renderers/shared/reconciler/__tests__/ReactComponent-test.js
@@ -12,19 +12,15 @@
'use strict';
var React;
-var ReactInstanceMap;
var ReactTestUtils;
var mocks;
-var reactComponentExpect;
describe('ReactComponent', function() {
beforeEach(function() {
mocks = require('mocks');
React = require('React');
- ReactInstanceMap = require('ReactInstanceMap');
ReactTestUtils = require('ReactTestUtils');
- reactComponentExpect = require('reactComponentExpect');
});
it('should throw on invalid render targets', function() {
diff --git a/src/renderers/shared/reconciler/__tests__/ReactComponentLifeCycle-test.js b/src/renderers/shared/reconciler/__tests__/ReactComponentLifeCycle-test.js
index 7d61482da9c..9f1d426f26c 100644
--- a/src/renderers/shared/reconciler/__tests__/ReactComponentLifeCycle-test.js
+++ b/src/renderers/shared/reconciler/__tests__/ReactComponentLifeCycle-test.js
@@ -207,7 +207,7 @@ describe('ReactComponentLifeCycle', function() {
it('throws when accessing state in componentWillMount', function() {
var StatefulComponent = React.createClass({
componentWillMount: function() {
- this.state.yada;
+ void this.state.yada;
},
render: function() {
return (
@@ -271,7 +271,7 @@ describe('ReactComponentLifeCycle', function() {
expect(this.isMounted()).toBeTruthy();
},
render: function() {
- expect(this.isMounted()).toBeFalsy()
+ expect(this.isMounted()).toBeFalsy();
return ;
}
});
@@ -530,7 +530,7 @@ describe('ReactComponentLifeCycle', function() {
// Since `instance` is a root component, we can set its props. This also
// makes Tooltip rerender the tooltip component, which shouldn't throw.
- instance.setProps({text: "dos", tooltipText: "two"});
+ instance.setProps({text: 'dos', tooltipText: 'two'});
});
it('should not allow setProps() called on an unmounted element',
diff --git a/src/renderers/shared/reconciler/__tests__/ReactCompositeComponent-test.js b/src/renderers/shared/reconciler/__tests__/ReactCompositeComponent-test.js
index 20f238fdf48..5282a5fcee5 100644
--- a/src/renderers/shared/reconciler/__tests__/ReactCompositeComponent-test.js
+++ b/src/renderers/shared/reconciler/__tests__/ReactCompositeComponent-test.js
@@ -326,7 +326,7 @@ describe('ReactCompositeComponent', function() {
expect(() => {
this.setState({value: 2}, function() {
cbCalled = true;
- })
+ });
}).not.toThrow();
},
render: function() {
@@ -515,7 +515,7 @@ describe('ReactCompositeComponent', function() {
render: function() {
return
+ Hi, from within a WC!
, shadowRoot);
expect(shadowRoot.firstChild.tagName).toBe('DIV');
React.render(Hi, from within a WC!, shadowRoot);
expect(shadowRoot.firstChild.tagName).toBe('SPAN');
+ }
}
- }
+ });
+ proto.unmount = function() {
+ React.unmountComponentAtNode(shadowRoot);
+ };
+ document.registerElement('x-foo', {prototype: proto});
+ var element = document.createElement('x-foo');
+ element.unmount();
});
- proto.unmount = function() {
- React.unmountComponentAtNode(shadowRoot);
- };
- document.registerElement('x-foo', {prototype: proto});
- var element = document.createElement('x-foo');
- element.unmount();
- });
+ }
});
diff --git a/src/renderers/dom/client/__tests__/ReactMountDestruction-test.js b/src/renderers/dom/client/__tests__/ReactMountDestruction-test.js
index 9b510de5d32..d13071f547f 100644
--- a/src/renderers/dom/client/__tests__/ReactMountDestruction-test.js
+++ b/src/renderers/dom/client/__tests__/ReactMountDestruction-test.js
@@ -14,7 +14,7 @@
var React = require('React');
describe('ReactMount', function() {
- it("should destroy a react root upon request", function() {
+ it('should destroy a react root upon request', function() {
var mainContainerDiv = document.createElement('div');
document.body.appendChild(mainContainerDiv);
diff --git a/src/renderers/dom/client/__tests__/findDOMNode-test.js b/src/renderers/dom/client/__tests__/findDOMNode-test.js
index 75e797d8834..e0ae69e0fef 100644
--- a/src/renderers/dom/client/__tests__/findDOMNode-test.js
+++ b/src/renderers/dom/client/__tests__/findDOMNode-test.js
@@ -34,14 +34,18 @@ describe('findDOMNode', function() {
});
it('findDOMNode should reject random objects', function() {
- expect(function() {React.findDOMNode({foo: 'bar'});})
+ expect(function() {
+ React.findDOMNode({foo: 'bar'});
+ })
.toThrow('Invariant Violation: Element appears to be neither ' +
'ReactComponent nor DOMNode (keys: foo)'
);
});
it('findDOMNode should reject unmounted objects with render func', function() {
- expect(function() {React.findDOMNode({render: function() {}});})
+ expect(function() {
+ React.findDOMNode({render: function() {}});
+ })
.toThrow('Invariant Violation: Component (with keys: render) ' +
'contains `render` method but is not mounted in the DOM'
);
diff --git a/src/renderers/dom/client/eventPlugins/__tests__/AnalyticsEventPlugin-test.js b/src/renderers/dom/client/eventPlugins/__tests__/AnalyticsEventPlugin-test.js
index 64c04d1e934..51c8eb1a573 100644
--- a/src/renderers/dom/client/eventPlugins/__tests__/AnalyticsEventPlugin-test.js
+++ b/src/renderers/dom/client/eventPlugins/__tests__/AnalyticsEventPlugin-test.js
@@ -18,7 +18,6 @@ describe('AnalyticsEventPlugin', function() {
var EventPluginHub;
var EventPluginRegistry;
var React;
- var ReactBrowserEventEmitter;
var ReactTestUtils;
var DefaultEventPluginOrder;
@@ -32,7 +31,6 @@ describe('AnalyticsEventPlugin', function() {
EventPluginHub = require('EventPluginHub');
EventPluginRegistry = require('EventPluginRegistry');
React = require('React');
- ReactBrowserEventEmitter = require('ReactBrowserEventEmitter');
ReactTestUtils = require('ReactTestUtils');
EventPluginRegistry._resetEventPlugins();
@@ -65,7 +63,7 @@ describe('AnalyticsEventPlugin', function() {
return (
+ data-analytics-events="click,doubleClick">
Test
);
@@ -118,8 +116,8 @@ describe('AnalyticsEventPlugin', function() {
render: function() {
return (
+ data-analytics-id="test_invalid_events"
+ data-analytics-events="click,123">
Test
);
diff --git a/src/renderers/dom/client/wrappers/__tests__/ReactDOMInput-test.js b/src/renderers/dom/client/wrappers/__tests__/ReactDOMInput-test.js
index f67d43d1b8e..b4759a07aad 100644
--- a/src/renderers/dom/client/wrappers/__tests__/ReactDOMInput-test.js
+++ b/src/renderers/dom/client/wrappers/__tests__/ReactDOMInput-test.js
@@ -56,7 +56,7 @@ describe('ReactDOMInput', function() {
it('should display "foobar" for `defaultValue` of `objToString`', function() {
var objToString = {
toString: function() {
- return "foobar";
+ return 'foobar';
}
};
@@ -86,7 +86,7 @@ describe('ReactDOMInput', function() {
expect(node.value).toEqual('true');
});
- it("should allow setting `value` to `false`", function() {
+ it('should allow setting `value` to `false`', function() {
var stub = ;
stub = ReactTestUtils.renderIntoDocument(stub);
var node = React.findDOMNode(stub);
@@ -106,7 +106,7 @@ describe('ReactDOMInput', function() {
var objToString = {
toString: function() {
- return "foobar";
+ return 'foobar';
}
};
diff --git a/src/renderers/dom/client/wrappers/__tests__/ReactDOMSelect-test.js b/src/renderers/dom/client/wrappers/__tests__/ReactDOMSelect-test.js
index 3166d913a51..72543b3bce8 100644
--- a/src/renderers/dom/client/wrappers/__tests__/ReactDOMSelect-test.js
+++ b/src/renderers/dom/client/wrappers/__tests__/ReactDOMSelect-test.js
@@ -154,7 +154,7 @@ describe('ReactDOMSelect', function() {
});
it('should reset child options selected when they are changed and `value` is set', function() {
- var stub = ;
+ var stub = ;
stub = ReactTestUtils.renderIntoDocument(stub);
stub.setProps({
@@ -174,7 +174,7 @@ describe('ReactDOMSelect', function() {
it('should allow setting `value` with `objectToString`', function() {
var objectToString = {
- animal: "giraffe",
+ animal: 'giraffe',
toString: function() {
return this.animal;
}
@@ -194,7 +194,7 @@ describe('ReactDOMSelect', function() {
expect(node.options[2].selected).toBe(false); // gorilla
// Changing the `value` prop should change the selected options.
- objectToString.animal = "monkey";
+ objectToString.animal = 'monkey';
stub.forceUpdate();
expect(node.options[0].selected).toBe(true); // monkey
diff --git a/src/renderers/dom/client/wrappers/__tests__/ReactDOMTextarea-test.js b/src/renderers/dom/client/wrappers/__tests__/ReactDOMTextarea-test.js
index 902edd5e1ba..9cd4659237c 100644
--- a/src/renderers/dom/client/wrappers/__tests__/ReactDOMTextarea-test.js
+++ b/src/renderers/dom/client/wrappers/__tests__/ReactDOMTextarea-test.js
@@ -67,7 +67,7 @@ describe('ReactDOMTextarea', function() {
it('should display "foobar" for `defaultValue` of `objToString`', function() {
var objToString = {
toString: function() {
- return "foobar";
+ return 'foobar';
}
};
@@ -136,7 +136,7 @@ describe('ReactDOMTextarea', function() {
var objToString = {
toString: function() {
- return "foo";
+ return 'foo';
}
};
stub.replaceProps({value: objToString, onChange: emptyFunction});
@@ -186,7 +186,7 @@ describe('ReactDOMTextarea', function() {
spyOn(console, 'error');
var obj = {
toString: function() {
- return "sharkswithlasers";
+ return 'sharkswithlasers';
}
};
var node = React.findDOMNode(renderTextarea());
diff --git a/src/renderers/dom/server/__tests__/ReactServerRendering-test.js b/src/renderers/dom/server/__tests__/ReactServerRendering-test.js
index 1a9986dac95..05db7d78822 100644
--- a/src/renderers/dom/server/__tests__/ReactServerRendering-test.js
+++ b/src/renderers/dom/server/__tests__/ReactServerRendering-test.js
@@ -14,7 +14,6 @@
require('mock-modules')
.dontMock('ExecutionEnvironment')
.dontMock('React')
- .dontMock('ReactMount')
.dontMock('ReactServerRendering')
.dontMock('ReactTestUtils')
.dontMock('ReactMarkupChecksum');
@@ -24,7 +23,6 @@ var mocks = require('mocks');
var ExecutionEnvironment;
var React;
var ReactMarkupChecksum;
-var ReactMount;
var ReactReconcileTransaction;
var ReactTestUtils;
var ReactServerRendering;
@@ -36,7 +34,6 @@ describe('ReactServerRendering', function() {
require('mock-modules').dumpCache();
React = require('React');
ReactMarkupChecksum = require('ReactMarkupChecksum');
- ReactMount = require('ReactMount');
ReactTestUtils = require('ReactTestUtils');
ReactReconcileTransaction = require('ReactReconcileTransaction');
diff --git a/src/renderers/dom/shared/__tests__/DOMPropertyOperations-test.js b/src/renderers/dom/shared/__tests__/DOMPropertyOperations-test.js
index 27b57aed6db..c9711ee77e0 100644
--- a/src/renderers/dom/shared/__tests__/DOMPropertyOperations-test.js
+++ b/src/renderers/dom/shared/__tests__/DOMPropertyOperations-test.js
@@ -212,7 +212,11 @@ describe('DOMPropertyOperations', function() {
it('should convert attribute values to string first', function() {
// Browsers default to this behavior, but some test environments do not.
// This ensures that we have consistent behavior.
- var obj = {toString: function() { return ''; }};
+ var obj = {
+ toString: function() {
+ return '';
+ }
+ };
DOMPropertyOperations.setValueForProperty(stubNode, 'role', obj);
expect(stubNode.getAttribute('role')).toBe('');
});
diff --git a/src/renderers/dom/shared/__tests__/Danger-test.js b/src/renderers/dom/shared/__tests__/Danger-test.js
index 7d7ae4e2c51..811ab51c8e0 100644
--- a/src/renderers/dom/shared/__tests__/Danger-test.js
+++ b/src/renderers/dom/shared/__tests__/Danger-test.js
@@ -99,7 +99,7 @@ describe('Danger', function() {
'Invariant Violation: dangerouslyRenderMarkup(...): Missing markup.'
);
- spyOn(console, "error");
+ spyOn(console, 'error');
var renderedMarkup = Danger.dangerouslyRenderMarkup(['']);
var args = console.error.argsForCall[0];
diff --git a/src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js b/src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js
index e45ad0b08b3..dda078a441d 100644
--- a/src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js
+++ b/src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js
@@ -25,7 +25,7 @@ describe('ReactDOMComponent', function() {
ReactTestUtils = require('ReactTestUtils');
});
- it("should handle className", function() {
+ it('should handle className', function() {
var container = document.createElement('div');
React.render(, container);
@@ -37,7 +37,7 @@ describe('ReactDOMComponent', function() {
expect(container.firstChild.className).toEqual('');
});
- it("should gracefully handle various style value types", function() {
+ it('should gracefully handle various style value types', function() {
var container = document.createElement('div');
React.render(, container);
var stubStyle = container.firstChild.style;
@@ -59,7 +59,7 @@ describe('ReactDOMComponent', function() {
});
// TODO: (poshannessy) deprecate this pattern.
- it("should update styles when mutating style object", function() {
+ it('should update styles when mutating style object', function() {
// not actually used. Just to suppress the style mutation warning
spyOn(console, 'error');
@@ -138,7 +138,7 @@ describe('ReactDOMComponent', function() {
expect(console.error.argsForCall.length).toBe(2);
});
- it("should update styles if initially null", function() {
+ it('should update styles if initially null', function() {
var styles = null;
var container = document.createElement('div');
React.render(, container);
@@ -151,7 +151,7 @@ describe('ReactDOMComponent', function() {
expect(stubStyle.display).toEqual('block');
});
- it("should update styles if updated to null multiple times", function() {
+ it('should update styles if updated to null multiple times', function() {
var styles = null;
var container = document.createElement('div');
React.render(, container);
@@ -172,25 +172,25 @@ describe('ReactDOMComponent', function() {
expect(stubStyle.display).toEqual('');
});
- it("should remove attributes", function() {
+ it('should remove attributes', function() {
var container = document.createElement('div');
- React.render(hello
, container);
@@ -247,7 +247,7 @@ describe('ReactDOMComponent', function() {
expect(container.firstChild.innerHTML).toEqual('goodbye');
});
- it("should transition from innerHTML to string content", function() {
+ it('should transition from innerHTML to string content', function() {
var container = document.createElement('div');
React.render(
,
@@ -259,7 +259,7 @@ describe('ReactDOMComponent', function() {
expect(container.firstChild.innerHTML).toEqual('adieu');
});
- it("should not incur unnecessary DOM mutations", function() {
+ it('should not incur unnecessary DOM mutations', function() {
var container = document.createElement('div');
React.render(, container);
@@ -287,7 +287,7 @@ describe('ReactDOMComponent', function() {
var genMarkup;
function quoteRegexp(str) {
- return (str + '').replace(/([.?*+\^$\[\]\\(){}|-])/g, "\\$1");
+ return (str + '').replace(/([.?*+\^$\[\]\\(){}|-])/g, '\\$1');
}
beforeEach(function() {
@@ -315,7 +315,7 @@ describe('ReactDOMComponent', function() {
this.addMatchers({
toHaveAttribute: function(attr, value) {
var expected = '(?:^|\\s)' + attr + '=[\\\'"]';
- if (typeof value != 'undefined') {
+ if (typeof value !== 'undefined') {
expected += quoteRegexp(value) + '[\\\'"]';
}
return this.actual.match(new RegExp(expected));
@@ -323,13 +323,13 @@ describe('ReactDOMComponent', function() {
});
});
- it("should generate the correct markup with className", function() {
+ it('should generate the correct markup with className', function() {
expect(genMarkup({className: 'a'})).toHaveAttribute('class', 'a');
expect(genMarkup({className: 'a b'})).toHaveAttribute('class', 'a b');
expect(genMarkup({className: ''})).toHaveAttribute('class', '');
});
- it("should escape style names and values", function() {
+ it('should escape style names and values', function() {
expect(genMarkup({
style: {'b&ckground': '<3'}
})).toHaveAttribute('style', 'b&ckground:<3;');
@@ -340,7 +340,7 @@ describe('ReactDOMComponent', function() {
var genMarkup;
function quoteRegexp(str) {
- return (str + '').replace(/([.?*+\^$\[\]\\(){}|-])/g, "\\$1");
+ return (str + '').replace(/([.?*+\^$\[\]\\(){}|-])/g, '\\$1');
}
beforeEach(function() {
@@ -368,7 +368,7 @@ describe('ReactDOMComponent', function() {
});
});
- it("should handle dangerouslySetInnerHTML", function() {
+ it('should handle dangerouslySetInnerHTML', function() {
var innerHTML = {__html: 'testContent'};
expect(
genMarkup({dangerouslySetInnerHTML: innerHTML})
@@ -399,13 +399,13 @@ describe('ReactDOMComponent', function() {
var stubComponent = new StubNativeComponent({
type: StubNativeComponent,
props: props,
- _owner: null,
+ _owner: null
});
return stubComponent.mountComponent('test', transaction, {});
};
});
- it("should warn against children for void elements", function() {
+ it('should warn against children for void elements', function() {
spyOn(console, 'error');
var container = document.createElement('div');
@@ -416,7 +416,7 @@ describe('ReactDOMComponent', function() {
expect(console.error.argsForCall[0][0]).toContain('void element');
});
- it("should warn against dangerouslySetInnerHTML for void elements", function() {
+ it('should warn against dangerouslySetInnerHTML for void elements', function() {
spyOn(console, 'error');
var container = document.createElement('div');
@@ -430,7 +430,7 @@ describe('ReactDOMComponent', function() {
expect(console.error.argsForCall[0][0]).toContain('void element');
});
- it("should treat menuitem as a void element but still create the closing tag", function() {
+ it('should treat menuitem as a void element but still create the closing tag', function() {
spyOn(console, 'error');
var container = document.createElement('div');
@@ -445,7 +445,7 @@ describe('ReactDOMComponent', function() {
expect(console.error.argsForCall[0][0]).toContain('void element');
});
- it("should validate against multiple children props", function() {
+ it('should validate against multiple children props', function() {
expect(function() {
mountComponent({children: '', dangerouslySetInnerHTML: ''});
}).toThrow(
@@ -490,14 +490,14 @@ describe('ReactDOMComponent', function() {
}).not.toThrow();
});
- it("should warn about contentEditable and children", function() {
+ it('should warn about contentEditable and children', function() {
spyOn(console, 'error');
mountComponent({contentEditable: true, children: ''});
expect(console.error.argsForCall.length).toBe(1);
expect(console.error.argsForCall[0][0]).toContain('contentEditable');
});
- it("should validate against invalid styles", function() {
+ it('should validate against invalid styles', function() {
expect(function() {
mountComponent({style: 'display: none'});
}).toThrow(
@@ -507,8 +507,7 @@ describe('ReactDOMComponent', function() {
);
});
- it("should execute custom event plugin listening behavior", function() {
- var React = require('React');
+ it('should execute custom event plugin listening behavior', function() {
var SimpleEventPlugin = require('SimpleEventPlugin');
SimpleEventPlugin.didPutListener = mocks.getMockFunction();
@@ -527,8 +526,7 @@ describe('ReactDOMComponent', function() {
expect(SimpleEventPlugin.willDeleteListener.mock.calls.length).toBe(1);
});
- it("should handle null and missing properly with event hooks", function() {
- var React = require('React');
+ it('should handle null and missing properly with event hooks', function() {
var SimpleEventPlugin = require('SimpleEventPlugin');
SimpleEventPlugin.didPutListener = mocks.getMockFunction();
@@ -570,7 +568,7 @@ describe('ReactDOMComponent', function() {
container = document.createElement('div');
});
- it("should warn against children for void elements", function() {
+ it('should warn against children for void elements', function() {
spyOn(console, 'error');
React.render(, container);
@@ -580,7 +578,7 @@ describe('ReactDOMComponent', function() {
expect(console.error.argsForCall[0][0]).toContain('void element');
});
- it("should warn against dangerouslySetInnerHTML for void elements", function() {
+ it('should warn against dangerouslySetInnerHTML for void elements', function() {
spyOn(console, 'error');
React.render(, container);
@@ -593,7 +591,7 @@ describe('ReactDOMComponent', function() {
expect(console.error.argsForCall[0][0]).toContain('void element');
});
- it("should validate against multiple children props", function() {
+ it('should validate against multiple children props', function() {
React.render(, container);
expect(function() {
@@ -607,7 +605,7 @@ describe('ReactDOMComponent', function() {
);
});
- it("should warn about contentEditable and children", function() {
+ it('should warn about contentEditable and children', function() {
spyOn(console, 'error');
React.render(
,
@@ -617,7 +615,7 @@ describe('ReactDOMComponent', function() {
expect(console.error.argsForCall[0][0]).toContain('contentEditable');
});
- it("should validate against invalid styles", function() {
+ it('should validate against invalid styles', function() {
React.render(, container);
expect(function() {
@@ -629,7 +627,7 @@ describe('ReactDOMComponent', function() {
);
});
- it("should properly escape text content and attributes values", function() {
+ it('should properly escape text content and attributes values', function() {
expect(
React.renderToStaticMarkup(
React.DOM.div({
@@ -648,7 +646,7 @@ describe('ReactDOMComponent', function() {
});
describe('unmountComponent', function() {
- it("should clean up listeners", function() {
+ it('should clean up listeners', function() {
var React = require('React');
var ReactBrowserEventEmitter = require('ReactBrowserEventEmitter');
var ReactMount = require('ReactMount');
@@ -784,10 +782,14 @@ describe('ReactDOMComponent', function() {
render: () =>
{this.context.foo}
;
- },
+ }
});
var component = ReactTestUtils.renderIntoDocument({[span1, frag(map)]}
;
+ map[key] = s2;
+ return {[s1, frag(map)]}
;
}
});
@@ -132,7 +132,10 @@ describe('ReactIdentity', function() {
it('should allow any character as a key, in a detached parent', function() {
var detachedContainer = document.createElement('div');
- renderAComponentWithKeyIntoContainer("<'WEIRD/&\\key'>", detachedContainer);
+ renderAComponentWithKeyIntoContainer(
+ "<'WEIRD/&\\key'>",
+ detachedContainer
+ );
});
it('should allow any character as a key, in an attached parent', function() {
@@ -141,7 +144,10 @@ describe('ReactIdentity', function() {
var attachedContainer = document.createElement('div');
document.body.appendChild(attachedContainer);
- renderAComponentWithKeyIntoContainer("<'WEIRD/&\\key'>", attachedContainer);
+ renderAComponentWithKeyIntoContainer(
+ "<'WEIRD/&\\key'>",
+ attachedContainer
+ );
document.body.removeChild(attachedContainer);
});
diff --git a/src/renderers/shared/reconciler/__tests__/ReactInstanceHandles-test.js b/src/renderers/shared/reconciler/__tests__/ReactInstanceHandles-test.js
index 58a50cfc8e5..aedaed7672f 100644
--- a/src/renderers/shared/reconciler/__tests__/ReactInstanceHandles-test.js
+++ b/src/renderers/shared/reconciler/__tests__/ReactInstanceHandles-test.js
@@ -141,7 +141,7 @@ describe('ReactInstanceHandles', function() {
expect(function() {
ReactMount.findComponentRoot(
parentNode,
- ReactMount.getID(childNodeB) + ":junk"
+ ReactMount.getID(childNodeB) + ':junk'
);
}).toThrow(
'Invariant Violation: findComponentRoot(..., .0.1:0:junk): ' +
@@ -177,14 +177,14 @@ describe('ReactInstanceHandles', function() {
});
describe('traverseTwoPhase', function() {
- it("should not traverse when traversing outside DOM", function() {
+ it('should not traverse when traversing outside DOM', function() {
var targetID = '';
var expectedAggregation = [];
ReactInstanceHandles.traverseTwoPhase(targetID, argAggregator, ARG);
expect(aggregatedArgs).toEqual(expectedAggregation);
});
- it("should traverse two phase across component boundary", function() {
+ it('should traverse two phase across component boundary', function() {
var parent = renderParentIntoDocument();
var targetID = getNodeID(parent.refs.P_P1_C1.refs.DIV_1);
var expectedAggregation = [
@@ -202,7 +202,7 @@ describe('ReactInstanceHandles', function() {
expect(aggregatedArgs).toEqual(expectedAggregation);
});
- it("should traverse two phase at shallowest node", function() {
+ it('should traverse two phase at shallowest node', function() {
var parent = renderParentIntoDocument();
var targetID = getNodeID(parent.refs.P);
var expectedAggregation = [
@@ -215,7 +215,7 @@ describe('ReactInstanceHandles', function() {
});
describe('traverseEnterLeave', function() {
- it("should not traverse when enter/leaving outside DOM", function() {
+ it('should not traverse when enter/leaving outside DOM', function() {
var targetID = '';
var expectedAggregation = [];
ReactInstanceHandles.traverseEnterLeave(
@@ -224,7 +224,7 @@ describe('ReactInstanceHandles', function() {
expect(aggregatedArgs).toEqual(expectedAggregation);
});
- it("should not traverse if enter/leave the same node", function() {
+ it('should not traverse if enter/leave the same node', function() {
var parent = renderParentIntoDocument();
var leaveID = getNodeID(parent.refs.P_P1_C1.refs.DIV_1);
var enterID = getNodeID(parent.refs.P_P1_C1.refs.DIV_1);
@@ -235,7 +235,7 @@ describe('ReactInstanceHandles', function() {
expect(aggregatedArgs).toEqual(expectedAggregation);
});
- it("should traverse enter/leave to sibling - avoids parent", function() {
+ it('should traverse enter/leave to sibling - avoids parent', function() {
var parent = renderParentIntoDocument();
var leaveID = getNodeID(parent.refs.P_P1_C1.refs.DIV_1);
var enterID = getNodeID(parent.refs.P_P1_C1.refs.DIV_2);
@@ -250,7 +250,7 @@ describe('ReactInstanceHandles', function() {
expect(aggregatedArgs).toEqual(expectedAggregation);
});
- it("should traverse enter/leave to parent - avoids parent", function() {
+ it('should traverse enter/leave to parent - avoids parent', function() {
var parent = renderParentIntoDocument();
var leaveID = getNodeID(parent.refs.P_P1_C1.refs.DIV_1);
var enterID = getNodeID(parent.refs.P_P1_C1.refs.DIV);
@@ -263,7 +263,7 @@ describe('ReactInstanceHandles', function() {
expect(aggregatedArgs).toEqual(expectedAggregation);
});
- it("should enter from the window", function() {
+ it('should enter from the window', function() {
var parent = renderParentIntoDocument();
var leaveID = ''; // From the window or outside of the React sandbox.
var enterID = getNodeID(parent.refs.P_P1_C1.refs.DIV);
@@ -278,7 +278,7 @@ describe('ReactInstanceHandles', function() {
expect(aggregatedArgs).toEqual(expectedAggregation);
});
- it("should enter from the window to the shallowest", function() {
+ it('should enter from the window to the shallowest', function() {
var parent = renderParentIntoDocument();
var leaveID = ''; // From the window or outside of the React sandbox.
var enterID = getNodeID(parent.refs.P);
@@ -291,7 +291,7 @@ describe('ReactInstanceHandles', function() {
expect(aggregatedArgs).toEqual(expectedAggregation);
});
- it("should leave to the window", function() {
+ it('should leave to the window', function() {
var parent = renderParentIntoDocument();
var enterID = ''; // From the window or outside of the React sandbox.
var leaveID = getNodeID(parent.refs.P_P1_C1.refs.DIV);
@@ -306,7 +306,7 @@ describe('ReactInstanceHandles', function() {
expect(aggregatedArgs).toEqual(expectedAggregation);
});
- it("should leave to the window from the shallowest", function() {
+ it('should leave to the window from the shallowest', function() {
var parent = renderParentIntoDocument();
var enterID = ''; // From the window or outside of the React sandbox.
var leaveID = getNodeID(parent.refs.P_P1_C1.refs.DIV);
@@ -323,7 +323,7 @@ describe('ReactInstanceHandles', function() {
});
describe('getNextDescendantID', function() {
- it("should return next descendent from window", function() {
+ it('should return next descendent from window', function() {
var parent = renderParentIntoDocument();
expect(
ReactInstanceHandles._getNextDescendantID(
@@ -333,11 +333,11 @@ describe('ReactInstanceHandles', function() {
).toBe(getNodeID(parent.refs.P));
});
- it("should return window for next descendent towards window", function() {
+ it('should return window for next descendent towards window', function() {
expect(ReactInstanceHandles._getNextDescendantID('', '')).toBe('');
});
- it("should return self for next descendent towards self", function() {
+ it('should return self for next descendent towards self', function() {
var parent = renderParentIntoDocument();
expect(
ReactInstanceHandles._getNextDescendantID(
@@ -349,7 +349,7 @@ describe('ReactInstanceHandles', function() {
});
describe('getFirstCommonAncestorID', function() {
- it("should determine the first common ancestor correctly", function() {
+ it('should determine the first common ancestor correctly', function() {
var parent = renderParentIntoDocument();
var ancestors = [
// Common ancestor from window to deep element is ''.
diff --git a/src/renderers/shared/reconciler/__tests__/ReactUpdates-test.js b/src/renderers/shared/reconciler/__tests__/ReactUpdates-test.js
index b04d455a025..28eb389725e 100644
--- a/src/renderers/shared/reconciler/__tests__/ReactUpdates-test.js
+++ b/src/renderers/shared/reconciler/__tests__/ReactUpdates-test.js
@@ -530,7 +530,7 @@ describe('ReactUpdates', function() {
return {x: 0};
},
componentDidUpdate: function() {
- expect(React.findDOMNode(b).textContent).toBe("B1");
+ expect(React.findDOMNode(b).textContent).toBe('B1');
aUpdated = true;
},
render: function() {
@@ -698,7 +698,9 @@ describe('ReactUpdates', function() {
});
var Z = React.createClass({
- render: function() { return ; },
+ render: function() {
+ return ;
+ },
componentWillUpdate: function() {
x.go();
}
@@ -785,7 +787,6 @@ describe('ReactUpdates', function() {
return ;
},
componentDidUpdate: function() {
- var component = this;
ReactUpdates.asap(function() {
expect(this).toBe(component);
callbackCount++;
@@ -793,7 +794,7 @@ describe('ReactUpdates', function() {
callbackCount++;
});
expect(callbackCount).toBe(1);
- }, this);
+ }, component);
expect(callbackCount).toBe(0);
}
});
diff --git a/src/renderers/shared/reconciler/__tests__/refs-destruction-test.js b/src/renderers/shared/reconciler/__tests__/refs-destruction-test.js
index 20d32270c85..845b3fb305c 100644
--- a/src/renderers/shared/reconciler/__tests__/refs-destruction-test.js
+++ b/src/renderers/shared/reconciler/__tests__/refs-destruction-test.js
@@ -12,7 +12,6 @@
'use strict';
var React = require('React');
-var ReactTestUtils = require('ReactTestUtils');
var reactComponentExpect = require('reactComponentExpect');
var TestComponent = React.createClass({
@@ -34,7 +33,7 @@ describe('refs-destruction', function() {
require('mock-modules').dumpCache();
});
- it("should remove refs when destroying the parent", function() {
+ it('should remove refs when destroying the parent', function() {
var container = document.createElement('div');
var testInstance = React.render(