Skip to content

Commit 644c9c4

Browse files
trueadmBrian Vaughn
authored andcommitted
[Flare] useListener -> useResponder (#362)
1 parent 9727f4e commit 644c9c4

2 files changed

Lines changed: 22 additions & 14 deletions

File tree

src/backend/ReactDebugHooks.js

Lines changed: 17 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,11 @@
88

99
import ErrorStackParser from 'error-stack-parser';
1010

11-
import type { ReactContext, ReactEventResponder } from './types';
11+
import type {
12+
ReactContext,
13+
ReactEventResponder,
14+
ReactEventResponderListener,
15+
} from './types';
1216

1317
type Fiber = any;
1418
type Hook = any;
@@ -30,8 +34,6 @@ type HookLogEntry = {
3034
value: mixed,
3135
};
3236

33-
const emptyObject = {};
34-
3537
let hookLog: Array<HookLogEntry> = [];
3638

3739
// Primitives
@@ -216,19 +218,20 @@ function useMemo<T>(
216218
return value;
217219
}
218220

219-
function useListener(
221+
function useResponder(
220222
responder: ReactEventResponder<any, any>,
221-
hookProps: ?Object
222-
): void {
223+
listenerProps: Object
224+
): ReactEventResponderListener<any, any> {
225+
// Don't put the actual event responder object in, just its displayName
223226
const value = {
224-
responder: responder.displayName || 'EventComponent',
225-
props: hookProps || emptyObject,
227+
responder: responder.displayName || 'EventResponder',
228+
props: listenerProps,
229+
};
230+
hookLog.push({ primitive: 'Responder', stackError: new Error(), value });
231+
return {
232+
responder,
233+
props: listenerProps,
226234
};
227-
hookLog.push({
228-
primitive: 'Listener',
229-
stackError: new Error(),
230-
value,
231-
});
232235
}
233236

234237
const Dispatcher = {
@@ -243,7 +246,7 @@ const Dispatcher = {
243246
useReducer,
244247
useRef,
245248
useState,
246-
useListener,
249+
useResponder,
247250
};
248251

249252
// Inspect

src/backend/types.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -371,3 +371,8 @@ export type ReactEventResponder<E, C> = {
371371
| null
372372
| ((context: C, props: Object, state: Object) => void),
373373
};
374+
375+
export type ReactEventResponderListener<E, C> = {|
376+
props: Object,
377+
responder: ReactEventResponder<E, C>,
378+
|};

0 commit comments

Comments
 (0)