Fix Dimensions window values on Android < 15 (#47554)#52481
Closed
alanleedev wants to merge 1 commit into
Closed
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77906644 |
Contributor
Author
Contributor
|
@alanleedev I provided the fix to the crash on Android 7 here EDIT: I opened a PR on your fork to fix it https://github.com/alanleedev/react-native/pull/1 |
alanleedev
force-pushed
the
export-D77906644
branch
from
July 15, 2025 11:49
3b8b083 to
129f126
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77906644 |
alanleedev
force-pushed
the
export-D77906644
branch
from
July 15, 2025 11:55
129f126 to
e410580
Compare
Summary: This PR (initially created for edge-to-edge opt-in support, rebased multiple times) fixes the `Dimensions` API `window` values on Android < 15, when edge-to-edge is enabled. Currently the window height doesn't include the status and navigation bar heights (but it does on Android >= 15): <img width="300" alt="Screenshot 2025-06-27 at 16 23 02" src="https://github.com/user-attachments/assets/c7d11334-9298-4f7f-a75c-590df8cc2d8a" /> Using `WindowMetricsCalculator` from AndroidX: <img width="300" alt="Screenshot 2025-06-27 at 16 34 01" src="https://github.com/user-attachments/assets/7a4e3dc7-a83b-421b-8f6d-fd1344f5fe81" /> Fixes #47080 ## Changelog: [Android] [Fixed] Fix `Dimensions` `window` values on Android < 15 when edge-to-edge is enabled Test Plan: Run the example app on an Android < 15 device. Rollback Plan: Reviewed By: cortinico Differential Revision: D77906644 Pulled By: alanleedev
alanleedev
force-pushed
the
export-D77906644
branch
from
July 16, 2025 15:11
7874a3f to
b67622d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77906644 |
Collaborator
|
This pull request was successfully merged by @zoontek in 86994a6 When will my fix make it into a release? | How to file a pick request? |
cipolleschi
added a commit
that referenced
this pull request
Jul 21, 2025
This reverts commit 86994a6.
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 21, 2025
Summary: Commit 86994a6 breaks Android for API level 24. Since it has landed last week, we had CI red. reverting this change while we found a valid fix forward. ## Changelog: [Android][Changed] - Reverted fix `Dimensions` `window` values on Android < 15 when edge-to-edge is enabled Pull Request resolved: #52732 Test Plan: GHA is green.: https://github.com/facebook/react-native/actions/runs/16414048087/job/46377878366?pr=52732 https://github.com/facebook/react-native/actions/runs/16414048087/job/46377878383?pr=52732 Reviewed By: cortinico, rshest Differential Revision: D78657920 Pulled By: cipolleschi fbshipit-source-id: 396a48c9aa7bde3109e25200fe2decc9977efda4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR (initially created for edge-to-edge opt-in support, rebased multiple times) fixes the
DimensionsAPIwindowvalues on Android < 15, when edge-to-edge is enabled.Currently the window height doesn't include the status and navigation bar heights (but it does on Android >= 15):
Using
WindowMetricsCalculatorfrom AndroidX:Fixes #47080
Changelog:
[Android] [Fixed] Fix
Dimensionswindowvalues on Android < 15 when edge-to-edge is enabledTest Plan:
Run the example app on an Android < 15 device.
Rollback Plan:
Differential Revision: D77906644
Pulled By: alanleedev