Fixed incorrect opacity behaviour for <Text> component on iOS (#24435)

shergin · facebook-github-bot · commit d99e657e3909 · 2019-04-15T02:41:45.000-07:00
Summary: This PR fixes #24229. Seems currently `opacity` props for Text is being applied twice (one for text color and one for the whole view). This PR disables applying the prop to the text. [CATEGORY] [TYPE] - Fixed double applying opacity prop for Text Pull Request resolved: #24435 Differential Revision: D14932795 Pulled By: cpojer fbshipit-source-id: f9280fc75f788424cb5f1e42d2e79efdb354d645
diff --git a/Libraries/Text/Text/RCTTextShadowView.m b/Libraries/Text/Text/RCTTextShadowView.m
@@ -46,6 +46,7 @@ - (void)didSetProps:(NSArray<NSString *> *)changedProps
   // the RCTTextView backgroundColor to be used, without affecting nested Text
   // components.
   self.textAttributes.backgroundColor = nil;
+  self.textAttributes.opacity = NAN;
 }
 
 - (BOOL)isYogaLeafNode

Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,7 @@ - (void)didSetProps:(NSArray<NSString > )changedProps`
`46`	`46`	`// the RCTTextView backgroundColor to be used, without affecting nested Text`
`47`	`47`	`// components.`
`48`	`48`	`self.textAttributes.backgroundColor = nil;`
	`49`	`+ self.textAttributes.opacity = NAN;`
`49`	`50`	`}`
`50`	`51`
`51`	`52`	`- (BOOL)isYogaLeafNode`