Forward ACTION_SCROLL events to SwipeRefreshLayout children (#55097)

Summary:
Pull Request resolved: #55097

This change adds support for joystick and scrollwheel input devices to trigger pull-to-refresh in SwipeRefreshLayout.

Previously, `ACTION_SCROLL` events from non-touch input devices (joysticks, scrollwheels, etc.) were not being forwarded to child views wrapped in a SwipeRefreshLayout. This prevented child ScrollViews from receiving these events and handling pull-to-refresh gestures via nested scrolling.

The fix overrides `dispatchGenericMotionEvent` in ReactSwipeRefreshLayout to explicitly forward `ACTION_SCROLL` events to the first child view before falling back to the default behavior. This allows child views to process the scroll events and communicate with the SwipeRefreshLayout parent through the standard nested scrolling APIs.

Changelog: [Internal]

Reviewed By: mdvacca, javache

Differential Revision: D90209679

fbshipit-source-id: 48ce2f961b8bfe548f3b29f073ab99b1da19915d

Author: Abbondanzo

packages/react-native/ReactAndroid/api/ReactAndroid.api

@@ -6025,6 +6025,7 @@ public abstract interface class com/facebook/react/views/scroll/VirtualView {
 public final class com/facebook/react/views/swiperefresh/ReactSwipeRefreshLayout : androidx/swiperefreshlayout/widget/SwipeRefreshLayout {
 	public fun <init> (Lcom/facebook/react/bridge/ReactContext;)V
 	public fun canChildScrollUp ()Z
+	public fun dispatchGenericMotionEvent (Landroid/view/MotionEvent;)Z
 	public fun onInterceptTouchEvent (Landroid/view/MotionEvent;)Z
 	public fun onLayout (ZIIII)V
 	public fun onTouchEvent (Landroid/view/MotionEvent;)Z

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlags.kt

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<7a9f9d29e1d5f01df33a0893e143a6db>>
+ * @generated SignedSource<<8cca42a9160a8a0e307a00e53cad46e8>>
  */
 
 /**
@@ -384,6 +384,12 @@ public object ReactNativeFeatureFlags {
   @JvmStatic
   public fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean = accessor.overrideBySynchronousMountPropsAtMountingAndroid()
 
+  /**
+   * When enabled, ReactSwipeRefreshLayout will forward ACTION_SCROLL events to its child for proper handling.
+   */
+  @JvmStatic
+  public fun passScrollToSwipeRefreshChild(): Boolean = accessor.passScrollToSwipeRefreshChild()
+
   /**
    * Enable reporting Performance Issues (`detail.devtools.performanceIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
    */

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxAccessor.kt

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<a0dee36eb68677b468c991297f0e95f7>>
+ * @generated SignedSource<<2adb48ad6907058ba092af9703994a57>>
  */
 
 /**
@@ -79,6 +79,7 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
   private var fuseboxNetworkInspectionEnabledCache: Boolean? = null
   private var hideOffscreenVirtualViewsOnIOSCache: Boolean? = null
   private var overrideBySynchronousMountPropsAtMountingAndroidCache: Boolean? = null
+  private var passScrollToSwipeRefreshChildCache: Boolean? = null
   private var perfIssuesEnabledCache: Boolean? = null
   private var perfMonitorV2EnabledCache: Boolean? = null
   private var preparedTextCacheSizeCache: Double? = null
@@ -630,6 +631,15 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
     return cached
   }
 
+  override fun passScrollToSwipeRefreshChild(): Boolean {
+    var cached = passScrollToSwipeRefreshChildCache
+    if (cached == null) {
+      cached = ReactNativeFeatureFlagsCxxInterop.passScrollToSwipeRefreshChild()
+      passScrollToSwipeRefreshChildCache = cached
+    }
+    return cached
+  }
+
   override fun perfIssuesEnabled(): Boolean {
     var cached = perfIssuesEnabledCache
     if (cached == null) {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxInterop.kt

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<ebb2bd0f070345e71737dab60a788a88>>
+ * @generated SignedSource<<54ca4d2bf514ce152b2f566205716aa6>>
  */
 
 /**
@@ -146,6 +146,8 @@ public object ReactNativeFeatureFlagsCxxInterop {
 
   @DoNotStrip @JvmStatic public external fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean
 
+  @DoNotStrip @JvmStatic public external fun passScrollToSwipeRefreshChild(): Boolean
+
   @DoNotStrip @JvmStatic public external fun perfIssuesEnabled(): Boolean
 
   @DoNotStrip @JvmStatic public external fun perfMonitorV2Enabled(): Boolean

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<beceb761f215c0819c27da186138971e>>
+ * @generated SignedSource<<8f895394bc6263275f42c0bfa10674b4>>
  */
 
 /**
@@ -141,6 +141,8 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi
 
   override fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean = false
 
+  override fun passScrollToSwipeRefreshChild(): Boolean = false
+
   override fun perfIssuesEnabled(): Boolean = false
 
   override fun perfMonitorV2Enabled(): Boolean = false

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsLocalAccessor.kt

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<44f52bff0ecd0f26c2173581b09dccce>>
+ * @generated SignedSource<<45b7473c077eb6fd4c2b46712962ddbd>>
  */
 
 /**
@@ -83,6 +83,7 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
   private var fuseboxNetworkInspectionEnabledCache: Boolean? = null
   private var hideOffscreenVirtualViewsOnIOSCache: Boolean? = null
   private var overrideBySynchronousMountPropsAtMountingAndroidCache: Boolean? = null
+  private var passScrollToSwipeRefreshChildCache: Boolean? = null
   private var perfIssuesEnabledCache: Boolean? = null
   private var perfMonitorV2EnabledCache: Boolean? = null
   private var preparedTextCacheSizeCache: Double? = null
@@ -693,6 +694,16 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
     return cached
   }
 
+  override fun passScrollToSwipeRefreshChild(): Boolean {
+    var cached = passScrollToSwipeRefreshChildCache
+    if (cached == null) {
+      cached = currentProvider.passScrollToSwipeRefreshChild()
+      accessedFeatureFlags.add("passScrollToSwipeRefreshChild")
+      passScrollToSwipeRefreshChildCache = cached
+    }
+    return cached
+  }
+
   override fun perfIssuesEnabled(): Boolean {
     var cached = perfIssuesEnabledCache
     if (cached == null) {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsProvider.kt

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<2bc1b7c78ced990301722e1c1dcc2dcf>>
+ * @generated SignedSource<<d50ebf5805d13b4da427ce1318c6cabc>>
  */
 
 /**
@@ -141,6 +141,8 @@ public interface ReactNativeFeatureFlagsProvider {
 
   @DoNotStrip public fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean
 
+  @DoNotStrip public fun passScrollToSwipeRefreshChild(): Boolean
+
   @DoNotStrip public fun perfIssuesEnabled(): Boolean
 
   @DoNotStrip public fun perfMonitorV2Enabled(): Boolean

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/swiperefresh/ReactSwipeRefreshLayout.kt

@@ -12,11 +12,18 @@ import android.view.ViewConfiguration
 import android.view.ViewGroup
 import androidx.swiperefreshlayout.widget.SwipeRefreshLayout
 import com.facebook.react.bridge.ReactContext
+import com.facebook.react.internal.featureflags.ReactNativeFeatureFlags
 import com.facebook.react.uimanager.PixelUtil
 import com.facebook.react.uimanager.events.NativeGestureUtil
 import kotlin.math.abs
 
-/** Basic extension of [SwipeRefreshLayout] with ReactNative-specific functionality. */
+/**
+ * Basic extension of [SwipeRefreshLayout] with ReactNative-specific functionality.
+ *
+ * This component wraps a scrollable child (typically a ScrollView or RecyclerView) and provides
+ * pull-to-refresh functionality. It handles touch event interception for the refresh gesture while
+ * properly forwarding other events to its children.
+ */
 public class ReactSwipeRefreshLayout(reactContext: ReactContext) :
     SwipeRefreshLayout(reactContext) {
 
@@ -127,6 +134,31 @@ public class ReactSwipeRefreshLayout(reactContext: ReactContext) :
     return true
   }
 
+  /**
+   * Dispatches generic motion events to children.
+   *
+   * This override ensures that [MotionEvent.ACTION_SCROLL] events (from joystick, scrollwheel, or
+   * other pointing devices) are properly forwarded to child views.
+   */
+  public override fun dispatchGenericMotionEvent(ev: MotionEvent): Boolean {
+    // For ACTION_SCROLL events, dispatch to child for handling
+    // The child ScrollView will use nested scrolling APIs to communicate with this
+    // SwipeRefreshLayout
+    if (
+        ReactNativeFeatureFlags.passScrollToSwipeRefreshChild() &&
+            ev.actionMasked == MotionEvent.ACTION_SCROLL
+    ) {
+      val child = getChildAt(0)
+      if (child != null) {
+        val handled = child.dispatchGenericMotionEvent(ev)
+        if (handled) {
+          return true
+        }
+      }
+    }
+    return super.dispatchGenericMotionEvent(ev)
+  }
+
   private companion object {
     private const val DEFAULT_CIRCLE_TARGET = 64f
   }

packages/react-native/ReactAndroid/src/main/jni/react/featureflags/JReactNativeFeatureFlagsCxxInterop.cpp

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<89d63e717ae8634f32613243bcbe2c40>>
+ * @generated SignedSource<<77d79172d377c62d4d26ddd16dab56ec>>
  */
 
 /**
@@ -393,6 +393,12 @@ class ReactNativeFeatureFlagsJavaProvider
     return method(javaProvider_);
   }
 
+  bool passScrollToSwipeRefreshChild() override {
+    static const auto method =
+        getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("passScrollToSwipeRefreshChild");
+    return method(javaProvider_);
+  }
+
   bool perfIssuesEnabled() override {
     static const auto method =
         getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("perfIssuesEnabled");
@@ -806,6 +812,11 @@ bool JReactNativeFeatureFlagsCxxInterop::overrideBySynchronousMountPropsAtMounti
   return ReactNativeFeatureFlags::overrideBySynchronousMountPropsAtMountingAndroid();
 }
 
+bool JReactNativeFeatureFlagsCxxInterop::passScrollToSwipeRefreshChild(
+    facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
+  return ReactNativeFeatureFlags::passScrollToSwipeRefreshChild();
+}
+
 bool JReactNativeFeatureFlagsCxxInterop::perfIssuesEnabled(
     facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
   return ReactNativeFeatureFlags::perfIssuesEnabled();
@@ -1109,6 +1120,9 @@ void JReactNativeFeatureFlagsCxxInterop::registerNatives() {
       makeNativeMethod(
         "overrideBySynchronousMountPropsAtMountingAndroid",
         JReactNativeFeatureFlagsCxxInterop::overrideBySynchronousMountPropsAtMountingAndroid),
+      makeNativeMethod(
+        "passScrollToSwipeRefreshChild",
+        JReactNativeFeatureFlagsCxxInterop::passScrollToSwipeRefreshChild),
       makeNativeMethod(
         "perfIssuesEnabled",
         JReactNativeFeatureFlagsCxxInterop::perfIssuesEnabled),

packages/react-native/ReactAndroid/src/main/jni/react/featureflags/JReactNativeFeatureFlagsCxxInterop.h

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<1cf1c6d1d2a98a495db315e0e7edcc32>>
+ * @generated SignedSource<<35b3b4933e2c337c4d924c2cc545eac6>>
  */
 
 /**
@@ -207,6 +207,9 @@ class JReactNativeFeatureFlagsCxxInterop
   static bool overrideBySynchronousMountPropsAtMountingAndroid(
     facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);
 
+  static bool passScrollToSwipeRefreshChild(
+    facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);
+
   static bool perfIssuesEnabled(
     facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);