From ed36538a4b2f879b2c5c37605e4616daef4ed31f Mon Sep 17 00:00:00 2001 From: sebastienlorber Date: Sun, 8 Oct 2023 19:45:13 +0200 Subject: [PATCH 1/2] Avoid rendering empty search container if site has no search plugin --- .../src/theme/Navbar/Search/index.tsx | 2 +- .../src/theme/Navbar/Search/styles.module.css | 12 ++++++++++-- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/packages/docusaurus-theme-classic/src/theme/Navbar/Search/index.tsx b/packages/docusaurus-theme-classic/src/theme/Navbar/Search/index.tsx index 236d237aa082..a720cd733a9f 100644 --- a/packages/docusaurus-theme-classic/src/theme/Navbar/Search/index.tsx +++ b/packages/docusaurus-theme-classic/src/theme/Navbar/Search/index.tsx @@ -15,5 +15,5 @@ export default function NavbarSearch({ children, className, }: Props): JSX.Element { - return
{children}
; + return
{children}
; } diff --git a/packages/docusaurus-theme-classic/src/theme/Navbar/Search/styles.module.css b/packages/docusaurus-theme-classic/src/theme/Navbar/Search/styles.module.css index ca386bb12db9..4e0e3c3b5796 100644 --- a/packages/docusaurus-theme-classic/src/theme/Navbar/Search/styles.module.css +++ b/packages/docusaurus-theme-classic/src/theme/Navbar/Search/styles.module.css @@ -5,15 +5,23 @@ * LICENSE file in the root directory of this source tree. */ +/* +Workaround to avoid rendering empty search container +See https://github.com/facebook/docusaurus/pull/7990 +*/ +.navbarSearch:not(:has(> *)) { + display: none; +} + @media (max-width: 996px) { - .searchBox { + .navbarSearch { position: absolute; right: var(--ifm-navbar-padding-horizontal); } } @media (min-width: 997px) { - .searchBox { + .navbarSearch { padding: var(--ifm-navbar-item-padding-vertical) var(--ifm-navbar-item-padding-horizontal); } From 2b9031ed2f577a5253474d24aabf80f2fe6e0153 Mon Sep 17 00:00:00 2001 From: sebastienlorber Date: Sun, 8 Oct 2023 19:49:06 +0200 Subject: [PATCH 2/2] polish --- .../src/theme/Navbar/Search/index.tsx | 6 +++++- .../src/theme/Navbar/Search/styles.module.css | 8 ++++---- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/packages/docusaurus-theme-classic/src/theme/Navbar/Search/index.tsx b/packages/docusaurus-theme-classic/src/theme/Navbar/Search/index.tsx index a720cd733a9f..1bfc3d3ba036 100644 --- a/packages/docusaurus-theme-classic/src/theme/Navbar/Search/index.tsx +++ b/packages/docusaurus-theme-classic/src/theme/Navbar/Search/index.tsx @@ -15,5 +15,9 @@ export default function NavbarSearch({ children, className, }: Props): JSX.Element { - return
{children}
; + return ( +
+ {children} +
+ ); } diff --git a/packages/docusaurus-theme-classic/src/theme/Navbar/Search/styles.module.css b/packages/docusaurus-theme-classic/src/theme/Navbar/Search/styles.module.css index 4e0e3c3b5796..b4e81167aeb2 100644 --- a/packages/docusaurus-theme-classic/src/theme/Navbar/Search/styles.module.css +++ b/packages/docusaurus-theme-classic/src/theme/Navbar/Search/styles.module.css @@ -7,21 +7,21 @@ /* Workaround to avoid rendering empty search container -See https://github.com/facebook/docusaurus/pull/7990 +See https://github.com/facebook/docusaurus/pull/9385 */ -.navbarSearch:not(:has(> *)) { +.navbarSearchContainer:not(:has(> *)) { display: none; } @media (max-width: 996px) { - .navbarSearch { + .navbarSearchContainer { position: absolute; right: var(--ifm-navbar-padding-horizontal); } } @media (min-width: 997px) { - .navbarSearch { + .navbarSearchContainer { padding: var(--ifm-navbar-item-padding-vertical) var(--ifm-navbar-item-padding-horizontal); }