move the go compiler version to go.version

Author: evanw

.github/workflows/ci.yml

@@ -17,20 +17,24 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+
+      - name: Read go.version
+        run: |
+          echo "GO_VERSION=$(cat go.version)" >> $GITHUB_ENV
+
       - name: Set up Go 1.x
         uses: actions/setup-go@v3
         with:
-          go-version: 1.23.10
+          go-version: ${{ env.GO_VERSION }}
         id: go
 
       - name: Setup Node.js environment
         uses: actions/setup-node@v3
         with:
           node-version: 18
 
-      - name: Check out code into the Go module directory
-        uses: actions/checkout@v3
-
       - name: Ensure all platforms can be built
         run: make platform-all
 
@@ -47,20 +51,24 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+
+      - name: Read go.version
+        run: |
+          echo "GO_VERSION=$(cat go.version)" >> $GITHUB_ENV
+
       - name: Set up Go 1.x
         uses: actions/setup-go@v3
         with:
-          go-version: 1.23.10
+          go-version: ${{ env.GO_VERSION }}
         id: go
 
       - name: Setup Node.js environment
         uses: actions/setup-node@v3
         with:
           node-version: 16
 
-      - name: Check out code into the Go module directory
-        uses: actions/checkout@v3
-
       # Note: These tests break with node version 18. Something about WebAssembly.
       - name: Rollup Tests
         run: make test-rollup
@@ -79,10 +87,23 @@ jobs:
         os: [ubuntu-latest, macos-latest, windows-latest]
 
     steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+
+      - name: Read go.version (non-Windows)
+        if: matrix.os != 'windows-latest'
+        run: |
+          echo "GO_VERSION=$(cat go.version)" >> $GITHUB_ENV
+
+      - name: Read go.version (Windows)
+        if: matrix.os == 'windows-latest'
+        run: |
+          echo "GO_VERSION=$(cat go.version)" >> $Env:GITHUB_ENV
+
       - name: Set up Go 1.x
         uses: actions/setup-go@v3
         with:
-          go-version: 1.23.10
+          go-version: ${{ env.GO_VERSION }}
         id: go
 
       - name: Setup Node.js environment
@@ -95,9 +116,6 @@ jobs:
         with:
           deno-version: v1.40.0
 
-      - name: Check out code into the Go module directory
-        uses: actions/checkout@v3
-
       - name: go test
         run: go test -race ./internal/...
 
@@ -207,15 +225,15 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+
       - name: Set up Go 1.13 (the minimum required Go version for esbuild)
         uses: actions/setup-go@v3
         with:
           go-version: 1.13
         id: go
 
-      - name: Check out code into the Go module directory
-        uses: actions/checkout@v3
-
       - name: go build
         run: go build ./cmd/esbuild
 
@@ -271,10 +289,23 @@ jobs:
         os: [ubuntu-latest, windows-latest]
 
     steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+
+      - name: Read go.version (non-Windows)
+        if: matrix.os != 'windows-latest'
+        run: |
+          echo "GO_VERSION=$(cat go.version)" >> $GITHUB_ENV
+
+      - name: Read go.version (Windows)
+        if: matrix.os == 'windows-latest'
+        run: |
+          echo "GO_VERSION=$(cat go.version)" >> $Env:GITHUB_ENV
+
       - name: Set up Go 1.x
         uses: actions/setup-go@v3
         with:
-          go-version: 1.23.10
+          go-version: ${{ env.GO_VERSION }}
         id: go
 
       # Make sure esbuild works with old versions of Deno. Note: It's important
@@ -284,9 +315,6 @@ jobs:
         with:
           deno-version: v1.24.0
 
-      - name: Check out code into the Go module directory
-        uses: actions/checkout@v3
-
       - name: Deno Tests (non-Windows)
         if: matrix.os != 'windows-latest'
         run: make test-deno

.github/workflows/validate.yml

@@ -15,10 +15,14 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v3
 
+      - name: Read go.version
+        run: |
+          echo "GO_VERSION=$(cat go.version)" >> $GITHUB_ENV
+
       - name: Set up Go 1.x
         uses: actions/setup-go@v3
         with:
-          go-version: 1.23.10
+          go-version: ${{ env.GO_VERSION }}
         id: go
 
       - name: Validation checks

Makefile

@@ -1,4 +1,5 @@
 ESBUILD_VERSION = $(shell cat version.txt)
+GO_VERSION = $(shell cat go.version)
 
 # Strip debug info
 GO_FLAGS += "-ldflags=-s -w"
@@ -20,7 +21,7 @@ test-all:
 	@$(MAKE) --no-print-directory -j6 test-common test-deno ts-type-tests test-wasm-node test-wasm-browser lib-typecheck test-yarnpnp
 
 check-go-version:
-	@go version | grep ' go1\.23\.10 ' || (echo 'Please install Go version 1.23.10' && false)
+	@go version | grep -F " go$(GO_VERSION) " || (echo 'Please install Go version $(GO_VERSION)' && false)
 
 # Note: Don't add "-race" here by default. The Go race detector is currently
 # only supported on the following configurations:
@@ -50,7 +51,7 @@ fmt-go:
 
 no-filepath:
 	@! grep --color --include '*.go' -r '"path/filepath"' cmd internal pkg || ( \
-		echo 'error: Use of "path/filepath" is disallowed. See http://golang.org/issue/43768.' && false)
+		echo 'error: Use of "path/filepath" is disallowed. See https://golang.org/issue/43768' && false)
 
 # This uses "env -i" to run in a clean environment with no environment
 # variables. It then adds some environment variables back as needed.

go.version

@@ -0,0 +1 @@
+1.23.10