fix(core): fixed String::lastIndexOf bug (#9003)

Co-authored-by: Rodrigo Garcia <[email protected]>
Co-authored-by: Vojtěch Bartoška <[email protected]>

Author: 3 people

cores/esp32/WString.cpp

@@ -677,7 +677,10 @@ int String::lastIndexOf(char ch, unsigned int fromIndex) const {
     wbuffer()[fromIndex + 1] = tempchar;
     if(temp == NULL)
         return -1;
-    return temp - buffer();
+    const int rv = temp - buffer();
+    if(rv >= len())
+        return -1;
+    return rv;
 }
 
 int String::lastIndexOf(const String &s2) const {