Skip to content

Commit effcf97

Browse files
Reverts "[Impeller] Enable depth buffer clipping & Stencil-then-Cover path rendering. (flutter#51209)" (flutter#51217)
Reverts flutter/engine#51209 Initiated by: bdero Reason for reverting: Golden breakages on [engine roll](flutter#144647) https://flutter-gold.skia.org/search?issue=144647&crs=github&patchsets=5&corpus=flutter Original PR Author: bdero Reviewed By: {jonahwilliams, chinmaygarde} This change reverts the following previous change: Original Description: Turn the page, wash your hands. Addresses the following issues: * flutter#143077 * flutter#137714 * flutter#138460 * flutter#123671 * flutter#141961 * flutter#134432 Previous attempt: - flutter/engine#50856 - reverted with flutter/engine#51191 - fixed with flutter/engine#51198
1 parent 9e813c7 commit effcf97

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

impeller/entity/contents/content_context.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -408,7 +408,7 @@ class ContentContext {
408408
///
409409
// TODO(bdero): Remove this setting once StC is fully de-risked
410410
// https://github.com/flutter/flutter/issues/123671
411-
static constexpr bool kEnableStencilThenCover = true;
411+
static constexpr bool kEnableStencilThenCover = false;
412412

413413
#if IMPELLER_ENABLE_3D
414414
std::shared_ptr<scene::SceneContext> GetSceneContext() const;

0 commit comments

Comments
 (0)