From 1e9f18d316770ef2430c4d3b87d015e205f3de03 Mon Sep 17 00:00:00 2001 From: Sam Clegg Date: Thu, 13 Feb 2020 17:43:24 -0800 Subject: [PATCH 1/2] Document `npm install` post-checkout requirement in changelog This should have been part of #9989 but we somehow forgot to add it. --- ChangeLog.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ChangeLog.md b/ChangeLog.md index 086113cf4c716..c197031e5933b 100644 --- a/ChangeLog.md +++ b/ChangeLog.md @@ -24,6 +24,10 @@ Current Trunk v1.39.7: 02/03/2020 ------------------- +- The checked-in copy of closure compiler was removed in favor of getting it + from npm. This means that developers now need to run `npm install` checking + out emscripten if they want to use closure (--closure). emsdk users are not + effected because emsdk runs this as a post install step (#9989). - Added support for specifying JSDoc minification annotations for Closure in JS library, pre and post files. See https://github.com/google/closure-compiler/wiki/Annotating-JavaScript-for-the-Closure-Compiler From dc859bb289c51dd96fa565bdb35aa5e5f71d6f33 Mon Sep 17 00:00:00 2001 From: Sam Clegg Date: Thu, 13 Feb 2020 17:45:01 -0800 Subject: [PATCH 2/2] typo --- ChangeLog.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ChangeLog.md b/ChangeLog.md index c197031e5933b..16e7c123b1045 100644 --- a/ChangeLog.md +++ b/ChangeLog.md @@ -25,9 +25,9 @@ Current Trunk v1.39.7: 02/03/2020 ------------------- - The checked-in copy of closure compiler was removed in favor of getting it - from npm. This means that developers now need to run `npm install` checking - out emscripten if they want to use closure (--closure). emsdk users are not - effected because emsdk runs this as a post install step (#9989). + from npm. This means that developers now need to run `npm install` after + checking out emscripten if they want to use closure (--closure). emsdk users + are not effected because emsdk runs this as a post install step (#9989). - Added support for specifying JSDoc minification annotations for Closure in JS library, pre and post files. See https://github.com/google/closure-compiler/wiki/Annotating-JavaScript-for-the-Closure-Compiler