Skip to content

Remove impossible clause on DateTime.from_naive!/2 #8080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fertapric wants to merge 1 commit into from
Closed

Remove impossible clause on DateTime.from_naive!/2 #8080

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions lib/elixir/lib/calendar/datetime.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ defmodule DateTime do
@doc """
Converts the given `NaiveDateTime` to `DateTime`.

It expects a time zone to put the NaiveDateTime in.
It expects a time zone to put the `NaiveDateTime` in.
Currently it only supports "Etc/UTC" as time zone.

## Examples
Expand All @@ -230,14 +230,8 @@ defmodule DateTime do
@doc since: "1.4.0"
@spec from_naive!(NaiveDateTime.t(), Calendar.time_zone()) :: t
def from_naive!(naive_datetime, time_zone) do
case from_naive(naive_datetime, time_zone) do
{:ok, datetime} ->
datetime

{:error, reason} ->
raise ArgumentError,
"cannot parse #{inspect(naive_datetime)} to datetime, reason: #{inspect(reason)}"
end
{:ok, datetime} = from_naive(naive_datetime, time_zone)
datetime
end

@doc """
Expand Down