Skip to content

Commit ff7d296

Browse files
authored
Merge pull request #865 from elementary-data/ele-866-test-management-split-tags-and-owners-to
ELE-866 test management split tags and owners
2 parents b1d7353 + f6319b9 commit ff7d296

2 files changed

Lines changed: 8 additions & 9 deletions

File tree

elementary/monitor/fetchers/test_management/schema.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,9 @@ class TestModel(BaseModel):
3434
args: Optional[dict]
3535
severity: str
3636
owners: List[str] = Field(default_factory=list)
37+
model_owners: List[str] = Field(default_factory=list)
3738
tags: List[str] = Field(default_factory=list)
39+
model_tags: List[str] = Field(default_factory=list)
3840
description: Optional[str]
3941
is_singular: bool
4042
updated_at: str

elementary/monitor/fetchers/test_management/test_management.py

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -88,15 +88,10 @@ def get_tests(self) -> List[TestModel]:
8888
tests = []
8989
for test_result in test_results:
9090
meta = json.loads(test_result["meta"])
91-
owners = unpack_and_flatten_str_to_list(test_result["model_owners"])
92-
tags = list(
93-
set(
94-
[
95-
*json.loads(test_result["model_tags"]),
96-
*json.loads(test_result["tags"]),
97-
]
98-
)
99-
)
91+
owners = unpack_and_flatten_str_to_list(meta.get("owner"))
92+
model_owners = unpack_and_flatten_str_to_list(test_result["model_owners"])
93+
tags = list(set(json.loads(test_result["tags"])))
94+
model_tags = list(set(json.loads(test_result["model_tags"])))
10095
description = meta.get("description")
10196

10297
tests.append(
@@ -111,7 +106,9 @@ def get_tests(self) -> List[TestModel]:
111106
args=json.loads(test_result["test_params"]),
112107
severity=test_result["severity"],
113108
owners=owners,
109+
model_owners=model_owners,
114110
tags=tags,
111+
model_tags=model_tags,
115112
description=description,
116113
is_singular=test_result["is_singular"],
117114
updated_at=test_result["generated_at"],

0 commit comments

Comments
 (0)