fix: replace || with concat() for T-SQL compatibility in CLI dbt macros

SQL Server / T-SQL does not support the || operator for string
concatenation. Replace all occurrences with the cross-database
concat() function which is supported by all target databases.

Co-Authored-By: Itamar Hartstein <haritamar@gmail.com>

Author: devin-ai-integration[bot]

elementary/monitor/dbt_project/macros/alerts/population/test_alerts.sql

@@ -128,12 +128,12 @@
     select distinct
         failed_tests.alert_id,
         {# Generate elementary unique id which is used to identify between tests, and set it as alert_class_id #}
-        coalesce(failed_tests.test_unique_id, 'None') || '.' || coalesce(failed_tests.column_name, 'None') || '.' || coalesce(failed_tests.sub_type, 'None') as alert_class_id,
+        concat(coalesce(failed_tests.test_unique_id, 'None'), '.', coalesce(failed_tests.column_name, 'None'), '.', coalesce(failed_tests.sub_type, 'None')) as alert_class_id,
         case
             when failed_tests.test_type = 'schema_change' then failed_tests.test_unique_id
             {# In old versions of elementary, elementary_test_results doesn't contain test_short_name, so we use dbt_test short_name. #}
             when tests.short_name = 'dimension_anomalies' then failed_tests.test_unique_id
-            else coalesce(failed_tests.test_unique_id, 'None') || '.' || coalesce(failed_tests.column_name, 'None') || '.' || coalesce(failed_tests.sub_type, 'None')
+            else concat(coalesce(failed_tests.test_unique_id, 'None'), '.', coalesce(failed_tests.column_name, 'None'), '.', coalesce(failed_tests.sub_type, 'None'))
         end as elementary_unique_id,
         failed_tests.data_issue_id,
         failed_tests.test_execution_id,

elementary/monitor/dbt_project/macros/base_queries/current_tests_run_results_query.sql

@@ -49,7 +49,7 @@
             when elementary_test_results.test_type = 'schema_change' then elementary_test_results.test_unique_id
             {# In old versions of elementary, elementary_test_results doesn't contain test_short_name, so we use dbt_test short_name. #}
             when dbt_tests.short_name = 'dimension_anomalies' then elementary_test_results.test_unique_id
-            else coalesce(elementary_test_results.test_unique_id, 'None') || '.' || coalesce(nullif(elementary_test_results.column_name, ''), 'None') || '.' || coalesce(elementary_test_results.test_sub_type, 'None')
+            else concat(coalesce(elementary_test_results.test_unique_id, 'None'), '.', coalesce(nullif(elementary_test_results.column_name, ''), 'None'), '.', coalesce(elementary_test_results.test_sub_type, 'None'))
         end as elementary_unique_id,
         elementary_test_results.invocation_id,
         elementary_test_results.data_issue_id,

elementary/monitor/dbt_project/macros/get_test_results.sql

@@ -162,7 +162,7 @@
         CASE
             WHEN etr.test_type = 'schema_change' THEN etr.test_unique_id
             WHEN dt.short_name = 'dimension_anomalies' THEN etr.test_unique_id
-            ELSE coalesce(etr.test_unique_id, 'None') || '.' || coalesce(nullif(etr.column_name, ''), 'None') || '.' || coalesce(etr.test_sub_type, 'None')
+            ELSE concat(coalesce(etr.test_unique_id, 'None'), '.', coalesce(nullif(etr.column_name, ''), 'None'), '.', coalesce(etr.test_sub_type, 'None'))
         END AS elementary_unique_id,
         etr.detected_at,
         etr.database_name,
@@ -266,4 +266,4 @@
     {%- endfor -%}
 
     {% do return(test_results) %}
-{%- endmacro -%}
+{%- endmacro -%}