Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Commit 2b377c5

Browse files
codebytereMarshallOfSound
authored andcommitted
chore: remove unused private RuntimeAgent member env
Removed in nodejs/node#28036; this patch can be removed when we update to v12.5.0
1 parent 80f1175 commit 2b377c5

File tree

5 files changed

+9
-5
lines changed

5 files changed

+9
-5
lines changed

filenames.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -307,6 +307,7 @@
307307
"src/node_env_var.cc",
308308
"src/node_errors.cc",
309309
"src/node_file.cc",
310+
"src/node_snapshot_stub.cc",
310311
"src/node_http_parser_llhttp.cc",
311312
"src/node_http_parser_traditional.cc",
312313
"src/node_http2.cc",

src/inspector/BUILD.gn

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ _protocol_generated = [
1010
"protocol/NodeWorker.h",
1111
"protocol/NodeTracing.cpp",
1212
"protocol/NodeTracing.h",
13+
"protocol/NodeRuntime.cpp",
14+
"protocol/NodeRuntime.h"
1315
]
1416

1517
# These are from node_protocol_config.json
@@ -41,6 +43,8 @@ source_set("inspector") {
4143
"worker_agent.h",
4244
"worker_inspector.cc",
4345
"worker_inspector.h",
46+
"runtime_agent.cc",
47+
"runtime_agent.h",
4448
]
4549
sources += rebase_path(_protocol_generated,
4650
".",

src/inspector/runtime_agent.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ namespace node {
77
namespace inspector {
88
namespace protocol {
99

10-
RuntimeAgent::RuntimeAgent(Environment* env)
11-
: notify_when_waiting_for_disconnect_(false), env_(env) {}
10+
RuntimeAgent::RuntimeAgent()
11+
: notify_when_waiting_for_disconnect_(false) {}
1212

1313
void RuntimeAgent::Wire(UberDispatcher* dispatcher) {
1414
frontend_ = std::make_unique<NodeRuntime::Frontend>(dispatcher->channel());

src/inspector/runtime_agent.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ namespace protocol {
1212

1313
class RuntimeAgent : public NodeRuntime::Backend {
1414
public:
15-
explicit RuntimeAgent(Environment* env);
15+
explicit RuntimeAgent();
1616

1717
void Wire(UberDispatcher* dispatcher);
1818

@@ -23,7 +23,6 @@ class RuntimeAgent : public NodeRuntime::Backend {
2323
private:
2424
std::shared_ptr<NodeRuntime::Frontend> frontend_;
2525
bool notify_when_waiting_for_disconnect_;
26-
Environment* env_;
2726
};
2827
} // namespace protocol
2928
} // namespace inspector

src/inspector_agent.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ class ChannelImpl final : public v8_inspector::V8Inspector::Channel,
239239
tracing_agent_->Wire(node_dispatcher_.get());
240240
worker_agent_ = std::make_unique<protocol::WorkerAgent>(worker_manager);
241241
worker_agent_->Wire(node_dispatcher_.get());
242-
runtime_agent_ = std::make_unique<protocol::RuntimeAgent>(env);
242+
runtime_agent_ = std::make_unique<protocol::RuntimeAgent>();
243243
runtime_agent_->Wire(node_dispatcher_.get());
244244
}
245245

0 commit comments

Comments
 (0)