Skip to content
This repository was archived by the owner on Apr 6, 2026. It is now read-only.

feat!: add support for WSL2 - #71

Merged
malept merged 11 commits into
masterfrom
malept/feat/wsl2
Dec 14, 2020
Merged

feat!: add support for WSL2#71
malept merged 11 commits into
masterfrom
malept/feat/wsl2

Conversation

@malept

@malept malept commented Dec 10, 2020

Copy link
Copy Markdown
Member

Adds support for WSL2 while at the same time fixing all known issues with WSL1 support. Uses a new module, cross-spawn-windows-exe, to execute rcedit.exe correctly in any given environment (including WSL1/WSL2). It should be noted that the module itself is tested in CI with WSL1, so I decided not to add it here.

Since the new module requires Node 10, I updated any other (dev)Dependencies that also require Node 10.

BREAKING CHANGE: requires Node 10 (drops support for Node < 10).

Fixes #65.

Closes #66.

@malept
malept requested a review from a team December 10, 2020 19:41
@malept
malept merged commit 080feca into master Dec 14, 2020
@malept
malept deleted the malept/feat/wsl2 branch December 14, 2020 16:48
@electron-bot

Copy link
Copy Markdown

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@andreineculau

Copy link
Copy Markdown
Contributor

Thanks! Haven't tested it yet but it looks sound to outsource that logic.

@malept

malept commented Dec 14, 2020

Copy link
Copy Markdown
Member Author

Thanks! Haven't tested it yet but it looks sound to outsource that logic.

Turns out the logic is also needed in electron-winstaller (although I can't use it in the Squirrel code itself), PR for that coming soon-ish

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong path with WSL

3 participants