fix: Validate required schema fields when no input is provided#125
Merged
Conversation
When a command has a Zod input schema but the user provides no input
(no --input-file, no stdin, no CLI args), inputValue remained undefined
and validation was skipped entirely. This caused literal {param}
placeholders to be sent in URLs to Elasticsearch.
Default inputValue to {} when undefined so Zod validation always runs,
catching missing required fields before the handler executes.
Closes #96
Closes #103
flobernd
approved these changes
Apr 13, 2026
JoshMock
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--input-file, no stdin, no CLI args),inputValueremainedundefinedand validation was skipped entirely. This caused literal{param}placeholders to be sent in URLs to Elasticsearch.inputValueto{}whenundefinedso Zod validation always runs, catching missing required fields before the handler executes.Closes #96
Closes #103
Test plan
elastic es cluster info,elastic es delete,elastic es indexall return clear validation errors instead of sending literal placeholders