Apply suggestions from code review

Co-authored-by: Manuel Warum <[email protected]>
Co-authored-by: Copilot <[email protected]>

Author: 3 people

src/authentication/dynatrace-clients.ts

@@ -8,7 +8,7 @@ import { requestTokenForClientCredentials } from './dynatrace-oauth-client-crede
 
 /**
  * Create a Dynatrace Http Client (from the http-client SDK) based on the provided authentication credentials
- * Supports Platform Token, Oauth Client Credentials Flow, and OAuth Authorization Code Flow (interactive)
+ * Supports Platform Token, OAuth Client Credentials Flow, and OAuth Authorization Code Flow (interactive)
  * @param environmentUrl
  * @param scopes
  * @param clientId
@@ -67,7 +67,7 @@ const createPlatformTokenHttpClient = async (environmentUrl: string, dtPlatformT
 };
 
 /**
- * Create an Oauth Client based on clientId, clientSecret, environmentUrl and scopes
+ * Create an OAuth Client based on clientId, clientSecret, environmentUrl and scopes
  * This uses a client-credentials flow to request a token from the SSO endpoint.
  * Note: We do not refresh the token here, we always request a new one on each client creation.
  */

src/authentication/dynatrace-oauth-auth-code-flow.ts

@@ -40,7 +40,8 @@ export function createAuthorizationUrl(ssoBaseURL: string, config: OAuthAuthoriz
 
   const queryString = queryParts.join('&');
 
-  const finalUrl = `${authUrl.origin}${authUrl.pathname}?${queryString}`; // What??? Why???
+  // Manually construct the final URL to ensure exact parameter order and encoding required by some OAuth implementations.
+  const finalUrl = `${authUrl.origin}${authUrl.pathname}?${queryString}`;
 
   return {
     authorizationUrl: finalUrl,

src/authentication/dynatrace-oauth-client-credentials.ts

@@ -4,7 +4,7 @@ import { OAuthTokenResponse } from './types';
 /**
  * Uses the provided oauth Client ID and Secret and requests a token via client-credentials flow
  * @param clientId - OAuth Client ID for Dynatrace
- * @param clientSecret - Oauth Client Secret for Dynatrace
+ * @param clientSecret - OAuth Client Secret for Dynatrace
  * @param ssoBaseURL - SSO Base URL (e.g., sso.dynatrace.com)
  * @param scopes - List of requested scopes
  * @returns Response of the OAuth Endpoint (which, in the best case includes a token)