From 63b5ccbe3075a98046c901540faef8e3079df2b7 Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Sat, 9 Jul 2022 04:35:34 -0400 Subject: [PATCH 1/6] [wasm] Disable tests failing on HighResourceAOT job - Disabling `FunctionalTests/System.Text.RegularExpressions.Tests` this test for HighResourceAOT - Also, ensure that the HighResourceAOT tests are run for regular library tests, and EAT. Issue: https://github.com/dotnet/runtime/issues/71848 --- src/libraries/tests.proj | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index ed1e67f8d1c19a..d347c06037bc7a 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -28,7 +28,8 @@ - + + @@ -68,6 +69,8 @@ + + @@ -564,7 +567,7 @@ - From 54c3c7117f69506cd7b38e2b60b13301d3b7b15d Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Sat, 9 Jul 2022 05:58:14 -0400 Subject: [PATCH 2/6] Disable for EAT also --- src/libraries/tests.proj | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index d347c06037bc7a..0ebc23f231a8db 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -65,6 +65,12 @@ + + + + + + From 7f4339ab1117997f24a1fe65a4bb83a0507b8c47 Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Mon, 11 Jul 2022 20:39:08 +0000 Subject: [PATCH 3/6] [wasm] Disable some STJ.Serialization tests failing due to linker issues This seems to be hit only with `EnableAggressiveTrimming=true`, and `RunAOTCompilation=true`. All the traces are similar to: ``` [FAIL] System.Text.Json.Serialization.Tests.CollectionTestsDynamic_AsyncStreamWithSmallBuffer.InvalidPropertyNameFail(policyType: typeof(System.Text.Json.Serialization.Tests.CollectionTests+KeyNameNullPolicy), offendingProperty: "Key") Assert.Throws() Failure Expected: typeof(System.InvalidOperationException) Actual: typeof(System.NotSupportedException): Metadata for type 'System.Collections.Generic.KeyValuePair`2[System.String,System.String]' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically. ---- System.NotSupportedException : Metadata for type 'System.Collections.Generic.KeyValuePair`2[System.String,System.String]' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically. at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken ) at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options) at System.Text.Json.Serialization.Tests.StreamingJsonSerializerWrapper.d__11`1[[System.Collections.Generic.KeyValuePair`2[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].MoveNext() at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken ) at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options) at System.Text.Json.Serialization.Tests.CollectionTests.<>c__DisplayClass377_0.<b__0>d.MoveNext() --- End of stack trace from previous location --- at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken ) at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options) ----- Inner Stack Trace ----- at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken ) at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options) at System.Text.Json.Serialization.Tests.StreamingJsonSerializerWrapper.d__11`1[[System.Collections.Generic.KeyValuePair`2[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].MoveNext() at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken ) at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options) at System.Text.Json.Serialization.Tests.CollectionTests.<>c__DisplayClass377_0.<b__0>d.MoveNext() --- End of stack trace from previous location --- at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken ) at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options) ``` Issue: https://github.com/dotnet/runtime/issues/71838 --- .../CollectionTests.KeyValuePair.cs | 1 + .../ConstructorTests.AttributePresence.cs | 1 + .../ConstructorTests.Exceptions.cs | 1 + .../tests/Common/ExtensionDataTests.cs | 5 ++++- .../tests/Common/PropertyNameTests.cs | 3 +++ .../PropertyVisibilityTests.NonPublicAccessors.cs | 1 + .../tests/Common/PropertyVisibilityTests.cs | 15 ++++++++++++++- .../Serialization/PropertyVisibilityTests.cs | 1 + .../Serialization/InvalidTypeTests.cs | 1 + 9 files changed, 27 insertions(+), 2 deletions(-) diff --git a/src/libraries/System.Text.Json/tests/Common/CollectionTests/CollectionTests.KeyValuePair.cs b/src/libraries/System.Text.Json/tests/Common/CollectionTests/CollectionTests.KeyValuePair.cs index 76c2676c8f7efd..5d5be680918552 100644 --- a/src/libraries/System.Text.Json/tests/Common/CollectionTests/CollectionTests.KeyValuePair.cs +++ b/src/libraries/System.Text.Json/tests/Common/CollectionTests/CollectionTests.KeyValuePair.cs @@ -396,6 +396,7 @@ private class TrailingAngleBracketPolicy : JsonNamingPolicy [Theory] [InlineData(typeof(KeyNameNullPolicy), "Key")] [InlineData(typeof(ValueNameNullPolicy), "Value")] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task InvalidPropertyNameFail(Type policyType, string offendingProperty) { var options = new JsonSerializerOptions diff --git a/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.AttributePresence.cs b/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.AttributePresence.cs index 11fbed0776d1cf..a4f44686dc8571 100644 --- a/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.AttributePresence.cs +++ b/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.AttributePresence.cs @@ -115,6 +115,7 @@ public async Task PublicParameterlessCtor_MultiplePublicParameterizedCtors_WithA #if !BUILDING_SOURCE_GENERATOR_TESTS // These are compile-time warnings from the source generator. [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task MultipleAttributes_NotSupported() { async Task RunTestAsync() diff --git a/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.Exceptions.cs b/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.Exceptions.cs index de47537732bf00..18b618127dc62d 100644 --- a/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.Exceptions.cs +++ b/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.Exceptions.cs @@ -317,6 +317,7 @@ public async Task CaseInsensitiveFails() #if BUILDING_SOURCE_GENERATOR_TESTS [ActiveIssue("Multi-dim arrays not supported.")] #endif + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task ClassWithUnsupportedCollectionTypes() { Exception e; diff --git a/src/libraries/System.Text.Json/tests/Common/ExtensionDataTests.cs b/src/libraries/System.Text.Json/tests/Common/ExtensionDataTests.cs index d3a6548226d71b..7f91c4d7236d84 100644 --- a/src/libraries/System.Text.Json/tests/Common/ExtensionDataTests.cs +++ b/src/libraries/System.Text.Json/tests/Common/ExtensionDataTests.cs @@ -324,6 +324,7 @@ public class ClassWithTwoExtensionProperties #if BUILDING_SOURCE_GENERATOR_TESTS [ActiveIssue("https://github.com/dotnet/runtime/issues/58945")] #endif + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task InvalidExtensionPropertyFail() { // Baseline @@ -798,7 +799,7 @@ public async Task DeserializeIntoJsonObjectProperty() #if BUILDING_SOURCE_GENERATOR_TESTS [ActiveIssue("https://github.com/dotnet/runtime/issues/58945")] #endif - + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task DeserializeIntoSystemObjectProperty() { string json = @"{""MyDict"":{""Property1"":1}}"; @@ -1088,6 +1089,7 @@ public class ClassWithInvalidExtensionPropertyStringJsonNode #if BUILDING_SOURCE_GENERATOR_TESTS [ActiveIssue("https://github.com/dotnet/runtime/issues/58945")] #endif + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task ExtensionProperty_InvalidDictionary() { var obj1 = new ClassWithInvalidExtensionPropertyStringString(); @@ -1147,6 +1149,7 @@ public class ClassWithMultipleDictionaries #if BUILDING_SOURCE_GENERATOR_TESTS [ActiveIssue("https://github.com/dotnet/runtime/issues/58945")] #endif + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task DeserializeIntoImmutableDictionaryProperty() { // baseline diff --git a/src/libraries/System.Text.Json/tests/Common/PropertyNameTests.cs b/src/libraries/System.Text.Json/tests/Common/PropertyNameTests.cs index 568357a5088b1d..25463ad21c410a 100644 --- a/src/libraries/System.Text.Json/tests/Common/PropertyNameTests.cs +++ b/src/libraries/System.Text.Json/tests/Common/PropertyNameTests.cs @@ -64,6 +64,7 @@ public async Task CustomNamePolicy() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task NullNamePolicy() { var options = new JsonSerializerOptions(); @@ -127,6 +128,7 @@ public async Task JsonPropertyNameAttribute() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task JsonNameAttributeDuplicateDesignTimeFail() { { @@ -141,6 +143,7 @@ public async Task JsonNameAttributeDuplicateDesignTimeFail() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task JsonNameConflictOnCamelCasingFail() { { diff --git a/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.NonPublicAccessors.cs b/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.NonPublicAccessors.cs index b43f622dce0aeb..70935daaf5c148 100644 --- a/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.NonPublicAccessors.cs +++ b/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.NonPublicAccessors.cs @@ -325,6 +325,7 @@ public class ClassWithMixedPropertyAccessors_PropertyAttributes [InlineData(typeof(ClassWithPrivate_InitOnlyProperty_WithJsonIncludeProperty))] [InlineData(typeof(ClassWithInternal_InitOnlyProperty_WithJsonIncludeProperty))] [InlineData(typeof(ClassWithProtected_InitOnlyProperty_WithJsonIncludeProperty))] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public virtual async Task NonPublicProperty_WithJsonInclude_Invalid(Type type) { InvalidOperationException ex = await Assert.ThrowsAsync(async () => await Serializer.DeserializeWrapper("{}", type)); diff --git a/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs b/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs index 85a4f81ddfe164..aa50a6732152c0 100644 --- a/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs +++ b/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs @@ -339,6 +339,7 @@ public async Task Ignore_PublicProperty_ConflictWithPublicDuePolicy() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task Throw_PublicProperty_ConflictDueAttributes() { // Serialize @@ -353,6 +354,7 @@ await Assert.ThrowsAsync( } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task Throw_PublicPropertyAndField_ConflictDueAttributes() { // Serialize @@ -367,6 +369,7 @@ await Assert.ThrowsAsync( } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task Throw_PublicProperty_ConflictDueAttributes_SingleInheritance() { // Serialize @@ -390,6 +393,7 @@ await Assert.ThrowsAsync( } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task Throw_PublicPropertyAndField_ConflictDueAttributes_SingleInheritance() { // Serialize @@ -413,6 +417,7 @@ await Assert.ThrowsAsync( } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task Throw_PublicProperty_ConflictDueAttributes_DoubleInheritance() { // Serialize @@ -437,6 +442,7 @@ await Assert.ThrowsAsync( } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task Throw_PublicPropertyAndField_ConflictDueAttributes_DoubleInheritance() { // Serialize @@ -461,6 +467,7 @@ await Assert.ThrowsAsync( } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task Throw_PublicProperty_ConflictDuePolicy() { var options = new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase }; @@ -477,6 +484,7 @@ await Assert.ThrowsAsync( } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task Throw_PublicPropertyAndField_ConflictDuePolicy() { var options = new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase }; @@ -493,6 +501,7 @@ await Assert.ThrowsAsync( } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task Throw_PublicProperty_ConflictDuePolicy_SingleInheritance() { var options = new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase }; @@ -519,6 +528,7 @@ await Assert.ThrowsAsync( } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task Throw_PublicPropertyAndField_ConflictDuePolicy_SingleInheritance() { var options = new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase }; @@ -545,6 +555,7 @@ await Assert.ThrowsAsync( } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task Throw_PublicProperty_ConflictDuePolicy_DobuleInheritance() { var options = new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase }; @@ -572,6 +583,7 @@ await Assert.ThrowsAsync( } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task Throw_PublicPropertyAndField_ConflictDuePolicy_DobuleInheritance() { var options = new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase }; @@ -1178,7 +1190,7 @@ public async Task JsonIgnoreAttribute_UnsupportedCollection() var dictionary = new Dictionary(); // Uri is an unsupported dictionary key. - dictionary.Add(new Uri("http://foo"), "bar"); + dictionary.Add(new Uri("http://typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]"), "bar"); var concurrentDictionary = new ConcurrentDictionary(dictionary); @@ -2745,6 +2757,7 @@ public async Task JsonIgnoreCondition_Polymorphic() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task SerializationMetadataNotComputedWhenMemberIgnored() { string janePayload = @"{""Name"":""Jane Doe""}"; diff --git a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/Serialization/PropertyVisibilityTests.cs b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/Serialization/PropertyVisibilityTests.cs index 5a0861ef7f1872..2845373272ac7f 100644 --- a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/Serialization/PropertyVisibilityTests.cs +++ b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/Serialization/PropertyVisibilityTests.cs @@ -300,6 +300,7 @@ public PropertyVisibilityTests_Default() [InlineData(typeof(ClassWithPrivate_InitOnlyProperty_WithJsonIncludeProperty))] [InlineData(typeof(ClassWithInternal_InitOnlyProperty_WithJsonIncludeProperty))] [InlineData(typeof(ClassWithProtected_InitOnlyProperty_WithJsonIncludeProperty))] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public override async Task NonPublicProperty_WithJsonInclude_Invalid(Type type) { // Exception messages direct users to use JsonSourceGenerationMode.Metadata to see a more detailed error. diff --git a/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/InvalidTypeTests.cs b/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/InvalidTypeTests.cs index 88e371435571f2..13da7fd8d95904 100644 --- a/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/InvalidTypeTests.cs +++ b/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/InvalidTypeTests.cs @@ -58,6 +58,7 @@ public void DeserializeInvalidType(Type type) [Theory] [MemberData(nameof(TypesWithInvalidMembers_WithMembers))] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task TypeWithInvalidMember(Type classType, Type invalidMemberType, string invalidMemberName) { static void ValidateException(InvalidOperationException ex, Type classType, Type invalidMemberType, string invalidMemberName) From 7be15f865ab4adcc52851baeb3cc72688d182dd0 Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Mon, 11 Jul 2022 18:40:41 -0400 Subject: [PATCH 4/6] Disable System.Text.Json.Serialization.Tests.PropertyNameTestsDynamic.JsonNameConflictOnCaseInsensitiveFail also --- .../System.Text.Json.Tests/Serialization/PropertyNameTests.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/PropertyNameTests.cs b/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/PropertyNameTests.cs index 6da381d144dab7..60dd6e27ac76a1 100644 --- a/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/PropertyNameTests.cs +++ b/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/PropertyNameTests.cs @@ -22,6 +22,7 @@ public async Task JsonNullNameAttribute() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task JsonNameConflictOnCaseInsensitiveFail() { string json = @"{""myInt"":1,""MyInt"":2}"; From e0899145c64ac4ccf70af1a9d584ea5f0599b3b9 Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Mon, 11 Jul 2022 19:05:52 -0400 Subject: [PATCH 5/6] Disable another STJ failing test - https://github.com/dotnet/runtime/issues/71981 --- .../System.Text.Json/tests/Common/PropertyVisibilityTests.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs b/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs index aa50a6732152c0..5e0f0555a24ba8 100644 --- a/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs +++ b/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs @@ -1150,6 +1150,7 @@ public async Task JsonIgnoreAttribute() // Needs support for more collections. [ActiveIssue("https://github.com/dotnet/runtime/issues/53393")] #endif + [ActiveIssue("https://github.com/dotnet/runtime/issues/71981")] public async Task JsonIgnoreAttribute_UnsupportedCollection() { string json = From 31f9887cd026fb9634a858a2ade815a3e781985b Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Mon, 11 Jul 2022 22:49:13 -0400 Subject: [PATCH 6/6] [wasm] Disable two more tests failing due to #71838 --- .../System.Text.Json/tests/Common/PropertyVisibilityTests.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs b/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs index 5e0f0555a24ba8..66ee85118fcb19 100644 --- a/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs +++ b/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs @@ -2426,6 +2426,7 @@ public class ClassWithThingsToIgnore_PerProperty [Theory] [InlineData(typeof(ClassWithBadIgnoreAttribute))] [InlineData(typeof(StructWithBadIgnoreAttribute))] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public virtual async Task JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail(Type type) { InvalidOperationException ex = await Assert.ThrowsAsync(async () => await Serializer.DeserializeWrapper("{}", type)); @@ -2446,6 +2447,7 @@ public virtual async Task JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail(T [Theory] [InlineData(typeof(ClassWithBadIgnoreAttribute))] [InlineData(typeof(StructWithBadIgnoreAttribute))] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public virtual async Task JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson(Type type) { InvalidOperationException ex = await Assert.ThrowsAsync(async () => await Serializer.DeserializeWrapper("", type));