From 9f1bf830ef2a722a3da4596b725de9695a9b35e5 Mon Sep 17 00:00:00 2001 From: Levi Broderick Date: Thu, 8 Jul 2021 13:42:44 -0700 Subject: [PATCH 1/2] Update EnumerateLines docs --- .../src/System/MemoryExtensions.Globalization.cs | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/libraries/System.Private.CoreLib/src/System/MemoryExtensions.Globalization.cs b/src/libraries/System.Private.CoreLib/src/System/MemoryExtensions.Globalization.cs index 9fd5bed5d6aea3..8c781dd274e1f0 100644 --- a/src/libraries/System.Private.CoreLib/src/System/MemoryExtensions.Globalization.cs +++ b/src/libraries/System.Private.CoreLib/src/System/MemoryExtensions.Globalization.cs @@ -385,8 +385,9 @@ public static SpanRuneEnumerator EnumerateRunes(this Span span) /// Returns an enumeration of lines over the provided span. /// /// - /// See the documentation for for more information - /// on how newline sequences are detected. + /// It is not recommended that protocol parsers utilize this API. See the documentation + /// for for more information on how newline + /// sequences are detected. /// public static SpanLineEnumerator EnumerateLines(this ReadOnlySpan span) { @@ -397,8 +398,9 @@ public static SpanLineEnumerator EnumerateLines(this ReadOnlySpan span) /// Returns an enumeration of lines over the provided span. /// /// - /// See the documentation for for more information - /// on how newline sequences are detected. + /// It is not recommended that protocol parsers utilize this API. See the documentation + /// for for more information on how newline + /// sequences are detected. /// public static SpanLineEnumerator EnumerateLines(this Span span) { From ad7c35a3af591266f9030fea4018af42ec2354a7 Mon Sep 17 00:00:00 2001 From: Levi Broderick Date: Thu, 22 Jul 2021 10:59:25 -0700 Subject: [PATCH 2/2] PR feedback --- .../src/System/MemoryExtensions.Globalization.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libraries/System.Private.CoreLib/src/System/MemoryExtensions.Globalization.cs b/src/libraries/System.Private.CoreLib/src/System/MemoryExtensions.Globalization.cs index 8c781dd274e1f0..66596fa0e8a155 100644 --- a/src/libraries/System.Private.CoreLib/src/System/MemoryExtensions.Globalization.cs +++ b/src/libraries/System.Private.CoreLib/src/System/MemoryExtensions.Globalization.cs @@ -385,7 +385,7 @@ public static SpanRuneEnumerator EnumerateRunes(this Span span) /// Returns an enumeration of lines over the provided span. /// /// - /// It is not recommended that protocol parsers utilize this API. See the documentation + /// It is recommended that protocol parsers not utilize this API. See the documentation /// for for more information on how newline /// sequences are detected. /// @@ -398,7 +398,7 @@ public static SpanLineEnumerator EnumerateLines(this ReadOnlySpan span) /// Returns an enumeration of lines over the provided span. /// /// - /// It is not recommended that protocol parsers utilize this API. See the documentation + /// It is recommended that protocol parsers not utilize this API. See the documentation /// for for more information on how newline /// sequences are detected. ///