Skip to content

Commit de883e3

Browse files
trylektrylek
authored
Remove XUnit reference metadata from tests I switched over last week (#61691)
During code review of my latest PR Bruce raised the concern that hard-coding public key values and version ID for the xunit.core reference will cause enormous maintenance pain if we decide to upgrade to a newer version of the module in the future. As Jeremy verified that the metadata is not really needed, I'm deleting it from all tests I switched over last week. Thanks Tomas
1 parent c03f4ec commit de883e3

2,421 files changed

Lines changed: 2421 additions & 16947 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎src/tests/JIT/Methodical/Arrays/huge/huge_b.il‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,7 @@
2626

2727

2828
}
29-
.assembly extern xunit.core
30-
{
31-
.publickeytoken = (
32-
8d 05 b1 bb 7a 6f db 6c
33-
)
34-
.ver 2:4:2:0
35-
}
29+
.assembly extern xunit.core {}
3630
.module 'test.exe'
3731
.namespace JitTest
3832
{

‎src/tests/JIT/Methodical/Arrays/huge/huge_i4.il‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,7 @@
2626

2727

2828
}
29-
.assembly extern xunit.core
30-
{
31-
.publickeytoken = (
32-
8d 05 b1 bb 7a 6f db 6c
33-
)
34-
.ver 2:4:2:0
35-
}
29+
.assembly extern xunit.core {}
3630
.module 'test.exe'
3731
.namespace JitTest
3832
{

‎src/tests/JIT/Methodical/Arrays/huge/huge_objref.il‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,7 @@
1818
.assembly 'test'
1919
{
2020
}
21-
.assembly extern xunit.core
22-
{
23-
.publickeytoken = (
24-
8d 05 b1 bb 7a 6f db 6c
25-
)
26-
.ver 2:4:2:0
27-
}
21+
.assembly extern xunit.core {}
2822
.module 'test.exe'
2923
.namespace JitTest
3024
{

‎src/tests/JIT/Methodical/Arrays/huge/huge_r4.il‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,7 @@
2626

2727

2828
}
29-
.assembly extern xunit.core
30-
{
31-
.publickeytoken = (
32-
8d 05 b1 bb 7a 6f db 6c
33-
)
34-
.ver 2:4:2:0
35-
}
29+
.assembly extern xunit.core {}
3630
.module 'test.exe'
3731
.namespace JitTest
3832
{

‎src/tests/JIT/Methodical/Arrays/huge/huge_r8.il‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,7 @@
2626

2727

2828
}
29-
.assembly extern xunit.core
30-
{
31-
.publickeytoken = (
32-
8d 05 b1 bb 7a 6f db 6c
33-
)
34-
.ver 2:4:2:0
35-
}
29+
.assembly extern xunit.core {}
3630
.module 'test.exe'
3731
.namespace JitTest
3832
{

‎src/tests/JIT/Methodical/Arrays/huge/huge_struct.il‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,7 @@
2626

2727

2828
}
29-
.assembly extern xunit.core
30-
{
31-
.publickeytoken = (
32-
8d 05 b1 bb 7a 6f db 6c
33-
)
34-
.ver 2:4:2:0
35-
}
29+
.assembly extern xunit.core {}
3630
.module 'test.exe'
3731
.namespace JitTest
3832
{

‎src/tests/JIT/Methodical/Arrays/huge/huge_u8.il‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,7 @@
2626

2727

2828
}
29-
.assembly extern xunit.core
30-
{
31-
.publickeytoken = (
32-
8d 05 b1 bb 7a 6f db 6c
33-
)
34-
.ver 2:4:2:0
35-
}
29+
.assembly extern xunit.core {}
3630
.module 'test.exe'
3731
.namespace JitTest
3832
{

‎src/tests/JIT/Methodical/Arrays/huge_struct.il‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,7 @@
2020

2121

2222
}
23-
.assembly extern xunit.core
24-
{
25-
.publickeytoken = (
26-
8d 05 b1 bb 7a 6f db 6c
27-
)
28-
.ver 2:4:2:0
29-
}
23+
.assembly extern xunit.core {}
3024
.module 'huge_strcut.exe'
3125
// MVID: {23E3D49B-6CFD-4DA0-8C9D-A611CE0BA103}
3226
.namespace JitTest

‎src/tests/JIT/Methodical/Arrays/lcs/lcs_ldlen.il‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,7 @@
2121

2222

2323
}
24-
.assembly extern xunit.core
25-
{
26-
.publickeytoken = (
27-
8d 05 b1 bb 7a 6f db 6c
28-
)
29-
.ver 2:4:2:0
30-
}
24+
.assembly extern xunit.core {}
3125
.module 'lcs.exe'
3226
// MVID: {52ED7FCA-78F1-42F6-8DE5-7388302AFAA6}
3327
.namespace JitTest

‎src/tests/JIT/Methodical/Arrays/misc/address.il‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,7 @@
1919
.assembly 'test'
2020
{
2121
}
22-
.assembly extern xunit.core
23-
{
24-
.publickeytoken = (
25-
8d 05 b1 bb 7a 6f db 6c
26-
)
27-
.ver 2:4:2:0
28-
}
22+
.assembly extern xunit.core {}
2923
.module 'test.exe'
3024
.namespace JitTest
3125
{

0 commit comments

Comments
 (0)