Fix UnobservedTaskException on Http2's SendPingAsync (#64494)

shubhanshu02 · web-flow · commit ce15dc7d1416 · 2022-01-29T19:20:30.000-08:00
Wrap the SendPingAsync function with LogExceptions in Http2Connection.cs to avoid any exception here being caught as an UnobservedTaskException. Fix #64450 Signed-off-by: Shubhanshu Saxena <shubhanshu.e01@gmail.com>
diff --git a/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Connection.cs b/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Connection.cs
@@ -2038,7 +2038,7 @@ private void VerifyKeepAlive()
                         _keepAlivePingTimeoutTimestamp = now + _keepAlivePingTimeout;
 
                         long pingPayload = Interlocked.Increment(ref _keepAlivePingPayload);
-                        SendPingAsync(pingPayload);
+                        LogExceptions(SendPingAsync(pingPayload));
                         return;
                     }
                     break;

Original file line number	Diff line number	Diff line change
`@@ -2038,7 +2038,7 @@ private void VerifyKeepAlive()`
`2038`	`2038`	`_keepAlivePingTimeoutTimestamp = now + _keepAlivePingTimeout;`
`2039`	`2039`
`2040`	`2040`	`long pingPayload = Interlocked.Increment(ref _keepAlivePingPayload);`
`2041`		`- SendPingAsync(pingPayload);`
	`2041`	`+ LogExceptions(SendPingAsync(pingPayload));`
`2042`	`2042`	`return;`
`2043`	`2043`	`}`
`2044`	`2044`	`break;`