renaming clrcompression --> System.IO.Compression.Native (#45713)

* renaming `clrcompression` --> `System.IO.Compression.Native`

* rename `clrcompression.def` file

* exclude `System.*.Native.dll` when creating managed shims

* static library should be `System.IO.Compression.Native.lib` on Windows. Same as Globalization - without `lib` prefix

* revert change to the resource string in tests

* move consts to src/Interop, remove `lib` prefix on Windows

* Delete what used to be System.IO.Compression.clrcompression package

* Preserve old PlatformManifestFileEntry for clrcompression.dll

* partially revert the src\Interop change

* Adjust projects for removal of `Interop\Interop.Libraries.cs`

revert 1

* Undo entire System.IO.Compression.csproj to get rid of an invisible edit.

Author: VSadov

docs/coding-guidelines/interop-guidelines.md

@@ -56,7 +56,7 @@
 parser.add_argument("-max_size", help="Max size of each partition in MB")
 is_windows = platform.system() == "Windows"
 native_binaries_to_ignore = [
-    "clrcompression.dll",
+    "System.IO.Compression.Native.dll",
     "clretwrc.dll",
     "clrgc.dll",
     "clrjit.dll",

src/coreclr/scripts/superpmi-setup.py

@@ -14,10 +14,16 @@ extern "C" const void* GlobalizationResolveDllImport(const char* name);
 
 static PInvokeOverrideFn* s_overrideImpl = nullptr;
 
+#if defined(_WIN32)
+#define GLOBALIZATION_DLL_NAME "System.Globalization.Native"
+#else
+#define GLOBALIZATION_DLL_NAME "libSystem.Globalization.Native"
+#endif
+
 // here we handle PInvokes whose implementation is always statically linked (even in .so/.dll case)
 static const void* DefaultResolveDllImport(const char* libraryName, const char* entrypointName)
 {
-    if (strcmp(libraryName, "libSystem.Globalization.Native") == 0)
+    if (strcmp(libraryName, GLOBALIZATION_DLL_NAME) == 0)
     {
         return GlobalizationResolveDllImport(entrypointName);
     }

src/coreclr/vm/pinvokeoverride.cpp

@@ -119,7 +119,7 @@ if(CLR_CMAKE_TARGET_WIN32)
     set(CORECLR_LIBRARIES
         ${CORECLR_STATIC_LIB_LOCATION}/coreclr_static.lib
         ${CORECLR_STATIC_LIB_LOCATION}/System.Globalization.Native.lib
-        ${CORECLR_STATIC_LIB_LOCATION}/libclrcompression.lib
+        ${CORECLR_STATIC_LIB_LOCATION}/System.IO.Compression.Native.lib
         kernel32.lib
         advapi32.lib
         ole32.lib

src/installer/corehost/cli/apphost/static/CMakeLists.txt

@@ -47,7 +47,7 @@ namespace
     extern "C" const void* CompressionResolveDllImport(const char* name);
 
 #if defined(_WIN32)
-#define COMPRESSION_DLL_NAME "clrcompression"
+#define COMPRESSION_DLL_NAME "System.IO.Compression.Native"
 #else
 #define COMPRESSION_DLL_NAME "libSystem.IO.Compression.Native"
 #endif

src/installer/corehost/cli/hostpolicy/hostpolicy_context.cpp

@@ -177,6 +177,7 @@
     <PlatformManifestFileEntry Include="API-MS-Win-core-xstate-l2-1-0.dll" IsNative="true" FallbackFileVersion="$(WindowsForwarderFileVersion)" />
     <PlatformManifestFileEntry Include="ucrtbase.dll" IsNative="true" />
     <PlatformManifestFileEntry Include="clrcompression.dll" IsNative="true" />
+    <PlatformManifestFileEntry Include="System.IO.Compression.Native.dll" IsNative="true" />
     <PlatformManifestFileEntry Include="createdump.exe" IsNative="true" />
     <PlatformManifestFileEntry Include="createdump" IsNative="true" />
     <PlatformManifestFileEntry Include="libcoreclrtraceptprovider.so" IsNative="true" />

src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props

@@ -10,6 +10,7 @@ internal static partial class Libraries
         internal const string NetSecurityNative = "libSystem.Net.Security.Native";
         internal const string CryptoNative = "libSystem.Security.Cryptography.Native.OpenSsl";
         internal const string CompressionNative = "libSystem.IO.Compression.Native";
+        internal const string GlobalizationNative = "libSystem.Globalization.Native";
         internal const string IOPortsNative = "libSystem.IO.Ports.Native";
         internal const string Libdl = "libdl";
         internal const string HostPolicy = "libhostpolicy";

src/libraries/Common/src/Interop/Interop.Libraries.cs

@@ -31,7 +31,8 @@ internal static partial class Libraries
         internal const string Wldap32 = "wldap32.dll";
         internal const string Ws2_32 = "ws2_32.dll";
         internal const string Wtsapi32 = "wtsapi32.dll";
-        internal const string CompressionNative = "clrcompression";
+        internal const string CompressionNative = "System.IO.Compression.Native";
+        internal const string GlobalizationNative = "System.Globalization.Native";
         internal const string MsQuic = "msquic.dll";
         internal const string HostPolicy = "hostpolicy.dll";
     }

src/libraries/Common/src/Interop/Unix/Interop.Libraries.cs

@@ -7,7 +7,7 @@
 
 #ifdef  _WIN32
     #define c_static_assert(e) static_assert((e),"")
-    #include "../../Windows/clrcompression/zlib/zlib.h"
+    #include "../../Windows/System.IO.Compression.Native/zlib/zlib.h"
 #else
     #include "pal_utilities.h"
     #include <zlib.h>