Skip to content

Commit 960e7b3

Browse files
authored
Disable tests blocking CI (#55446)
* Turn off test FlushAsync_ThrowsIfWriterReaderWithException * Turn off System.Net.NameResolution.Tests.GetHost* tests for SLES
1 parent 2eb0071 commit 960e7b3

3 files changed

Lines changed: 33 additions & 6 deletions

File tree

src/libraries/System.IO.Pipelines/tests/FlushAsyncTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public void FlushAsync_ReturnsCompletedTaskWhenMaxSizeIfZero()
2222
}
2323

2424
[Fact]
25-
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
25+
[ActiveIssue("https://github.com/dotnet/runtime/issues/55435")]
2626
public async Task FlushAsync_ThrowsIfWriterReaderWithException()
2727
{
2828
void ThrowTestException()

src/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostByNameTest.cs

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
#pragma warning disable 0618 // use of obsolete methods
55

66
using System.Net.Sockets;
7+
8+
using Microsoft.DotNet.XUnitExtensions;
79
using Xunit;
810

911
namespace System.Net.NameResolution.Tests
@@ -106,17 +108,28 @@ public void DnsObsoleteGetHostByName_IPv6String_ReturnsOnlyGivenIP()
106108
[ActiveIssue("https://github.com/dotnet/runtime/issues/51377", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
107109
public void DnsObsoleteGetHostByName_EmptyString_ReturnsHostName()
108110
{
111+
if (PlatformDetection.IsSLES)
112+
{
113+
// See https://github.com/dotnet/runtime/issues/55271
114+
throw new SkipTestException("SLES Tests environment is not configured for this test to work.");
115+
}
109116
IPHostEntry entry = Dns.GetHostByName("");
110117

111118
// DNS labels should be compared as case insensitive for ASCII characters. See RFC 4343.
112119
Assert.Contains(Dns.GetHostName(), entry.HostName, StringComparison.OrdinalIgnoreCase);
113120
}
114121

115-
[ActiveIssue("https://github.com/dotnet/runtime/issues/1488", TestPlatforms.OSX)]
116122
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotArm64Process), nameof(PlatformDetection.IsThreadingSupported))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/27622")]
123+
[ActiveIssue("https://github.com/dotnet/runtime/issues/1488", TestPlatforms.OSX)]
117124
[ActiveIssue("https://github.com/dotnet/runtime/issues/51377", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
118125
public void DnsObsoleteBeginEndGetHostByName_EmptyString_ReturnsHostName()
119126
{
127+
if (PlatformDetection.IsSLES)
128+
{
129+
// See https://github.com/dotnet/runtime/issues/55271
130+
throw new SkipTestException("SLES Tests environment is not configured for this test to work.");
131+
}
132+
120133
IPHostEntry entry = Dns.EndGetHostByName(Dns.BeginGetHostByName("", null, null));
121134

122135
// DNS labels should be compared as case insensitive for ASCII characters. See RFC 4343.

src/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostEntryTest.cs

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
using System.Threading;
88
using System.Threading.Tasks;
99

10+
using Microsoft.DotNet.XUnitExtensions;
1011
using Xunit;
1112

1213
namespace System.Net.NameResolution.Tests
@@ -21,13 +22,18 @@ public async Task Dns_GetHostEntryAsync_IPAddress_Ok()
2122
}
2223

2324
[ActiveIssue("https://github.com/dotnet/runtime/issues/1488", TestPlatforms.OSX)]
24-
25+
[ActiveIssue("https://github.com/dotnet/runtime/issues/51377", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
2526
[ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsNotArm64Process))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/27622")]
2627
[InlineData("")]
2728
[InlineData(TestSettings.LocalHost)]
28-
[ActiveIssue("https://github.com/dotnet/runtime/issues/51377", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
2929
public async Task Dns_GetHostEntry_HostString_Ok(string hostName)
3030
{
31+
if (PlatformDetection.IsSLES)
32+
{
33+
// See https://github.com/dotnet/runtime/issues/55271
34+
throw new SkipTestException("SLES Tests environment is not configured for this test to work.");
35+
}
36+
3137
try
3238
{
3339
await TestGetHostEntryAsync(() => Task.FromResult(Dns.GetHostEntry(hostName)));
@@ -72,12 +78,20 @@ public async Task Dns_GetHostEntry_HostString_Ok(string hostName)
7278
}
7379

7480
[ActiveIssue("https://github.com/dotnet/runtime/issues/1488", TestPlatforms.OSX)]
81+
[ActiveIssue("https://github.com/dotnet/runtime/issues/51377", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
7582
[ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsNotArm64Process))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/27622")]
7683
[InlineData("")]
7784
[InlineData(TestSettings.LocalHost)]
78-
[ActiveIssue("https://github.com/dotnet/runtime/issues/51377", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
79-
public async Task Dns_GetHostEntryAsync_HostString_Ok(string hostName) =>
85+
public async Task Dns_GetHostEntryAsync_HostString_Ok(string hostName)
86+
{
87+
if (PlatformDetection.IsSLES)
88+
{
89+
// See https://github.com/dotnet/runtime/issues/55271
90+
throw new SkipTestException("SLES Tests environment is not configured for this test to work.");
91+
}
92+
8093
await TestGetHostEntryAsync(() => Dns.GetHostEntryAsync(hostName));
94+
}
8195

8296
[Fact]
8397
public async Task Dns_GetHostEntryAsync_IPString_Ok() =>

0 commit comments

Comments
 (0)