Code Review Feedback

Author: cshung

src/coreclr/gc/gc.cpp

@@ -46323,9 +46323,9 @@ void GCHeap::GetMemoryInfo(uint64_t* highMemLoadThresholdBytes,
 #endif //_DEBUG
 }
 
-uint64_t GCHeap::GetTotalPauseDuration()
+int64_t GCHeap::GetTotalPauseDuration()
 {
-    return gc_heap::total_suspended_time;
+    return (int64_t)(gc_heap::total_suspended_time * 10);
 }
 
 uint32_t GCHeap::GetMemoryLoad()

src/coreclr/gc/gcimpl.h

@@ -182,8 +182,7 @@ class GCHeap : public IGCHeapInternal
                        uint64_t* pauseInfoRaw,
                        int kind);
 
-    // AndrewTodo: Does the order of methods in this interface matters?
-    uint64_t GetTotalPauseDuration();
+    int64_t GetTotalPauseDuration();
 
     uint32_t GetMemoryLoad();
 

src/coreclr/gc/gcinterface.h

@@ -652,10 +652,6 @@ class IGCHeap {
     // Get the last memory load in percentage observed by the last GC.
     virtual uint32_t GetMemoryLoad() = 0;
 
-    // Get the total paused duration 
-    // AndrewTodo: Does the order of methods in this interface matters?
-    virtual uint64_t GetTotalPauseDuration() = 0;
-
     // Gets the current GC latency mode.
     virtual int GetGcLatencyMode() = 0;
 
@@ -927,6 +923,9 @@ class IGCHeap {
 
     virtual unsigned int GetGenerationWithRange(Object* object, uint8_t** ppStart, uint8_t** ppAllocated, uint8_t** ppReserved) = 0;
 
+    // Get the total paused duration 
+    virtual int64_t GetTotalPauseDuration() = 0;
+
     IGCHeap() {}
     virtual ~IGCHeap() {}
 };

src/coreclr/nativeaot/Runtime/GCHelpers.cpp

@@ -342,5 +342,5 @@ EXTERN_C REDHAWK_API void RhAllocateNewObject(MethodTable* pEEType, uint32_t fla
 
 COOP_PINVOKE_HELPER(int64_t, RhGetTotalPauseDuration, ())
 {
-    return (int64_t)(GCHeapUtilities::GetGCHeap()->GetTotalPauseDuration() * 10);
+    return GCHeapUtilities::GetGCHeap()->GetTotalPauseDuration();
 }

src/coreclr/vm/comutilnative.cpp

@@ -674,18 +674,13 @@ UINT64   GCInterface::m_remPressure[MEM_PRESSURE_COUNT] = {0, 0, 0, 0};   // his
 // (m_iteration % MEM_PRESSURE_COUNT) is used as an index into m_addPressure and m_remPressure
 UINT     GCInterface::m_iteration = 0;
 
-FCIMPL0(INT64, GCInterface::_GetTotalPauseDuration)
+FCIMPL0(INT64, GCInterface::GetTotalPauseDuration)
 {
     FCALL_CONTRACT;
 
     FC_GC_POLL_NOT_NEEDED();
 
-    // Unsigned to signed conversion happened here
-
-    // GetTotalPauseDuration returned microseconds, but the TimeSpan constructor requires
-    // 100 nanosecond unit.
-    
-    return (int64_t)(GCHeapUtilities::GetGCHeap()->GetTotalPauseDuration() * 10);
+    return GCHeapUtilities::GetGCHeap()->GetTotalPauseDuration();
 }
 FCIMPLEND
 

src/coreclr/vm/comutilnative.h

@@ -134,7 +134,7 @@ class GCInterface {
     static FORCEINLINE UINT64 InterlockedAdd(UINT64 *pAugend, UINT64 addend);
     static FORCEINLINE UINT64 InterlockedSub(UINT64 *pMinuend, UINT64 subtrahend);
 
-    static FCDECL0(INT64,   _GetTotalPauseDuration);
+    static FCDECL0(INT64,   GetTotalPauseDuration);
     static FCDECL2(void,    GetMemoryInfo, Object* objUNSAFE, int kind);
     static FCDECL0(UINT32,  GetMemoryLoad);
     static FCDECL0(int,     GetGcLatencyMode);

src/coreclr/vm/ecalllist.h

@@ -475,7 +475,7 @@ FCFuncStart(gGCInterfaceFuncs)
     FCFuncElement("_WaitForFullGCComplete", GCInterface::WaitForFullGCComplete)
     FCFuncElement("_CollectionCount", GCInterface::CollectionCount)
     FCFuncElement("GetMemoryInfo", GCInterface::GetMemoryInfo)
-    FCFuncElement("_GetTotalPauseDuration", GCInterface::_GetTotalPauseDuration)
+    FCFuncElement("_GetTotalPauseDuration", GCInterface::GetTotalPauseDuration)
     FCFuncElement("GetMemoryLoad", GCInterface::GetMemoryLoad)
     FCFuncElement("GetSegmentSize", GCInterface::GetSegmentSize)
     FCFuncElement("GetLastGCPercentTimeInGC", GCInterface::GetLastGCPercentTimeInGC)