Address review feedback: drop IsPrivilegedProcess from NTFS guard, simplify ConditionalFact for not-ready drive tests

Co-authored-by: jozkee <16040868+jozkee@users.noreply.github.com>

Author: Copilot

src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/Directory/CreateDirectory.cs

@@ -519,7 +519,7 @@ public void SubdirectoryOnNonExistentDriveAsPath_ThrowsDirectoryNotFoundExceptio
             });
         }
 
-        [ConditionalFact(nameof(HasNotReadyDrive))]
+        [ConditionalFact]
         [PlatformSpecific(TestPlatforms.Windows)] // testing drive labels
         public void NotReadyDriveAsPath_ThrowsDirectoryNotFoundException()
         {   // Behavior is suspect, should really have thrown IOException similar to the SubDirectory case
@@ -531,7 +531,7 @@ public void NotReadyDriveAsPath_ThrowsDirectoryNotFoundException()
             });
         }
 
-        [ConditionalFact(nameof(HasNotReadyDrive))]
+        [ConditionalFact]
         [PlatformSpecific(TestPlatforms.Windows)] // testing drive labels
         public void SubdirectoryOnNotReadyDriveAsPath_ThrowsIOException()
         {
@@ -545,7 +545,6 @@ public void SubdirectoryOnNotReadyDriveAsPath_ThrowsIOException()
         }
 
         private static readonly string? s_notReadyDrive = IOServices.GetNotReadyDrive();
-        private static bool HasNotReadyDrive => s_notReadyDrive is not null;
 
 #if !TEST_WINRT // Cannot set current directory to root from appcontainer with it's default ACL
         /*

src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/Directory/Delete_MountVolume.cs

@@ -24,10 +24,10 @@ public class Directory_Delete_MountVolume
         private delegate void ExceptionCode();
         private static bool s_pass = true;
 
-        private static bool IsPrivilegedAndNtfs =>
-            PlatformDetection.IsPrivilegedProcess && FileSystemDebugInfo.IsCurrentDriveNTFS();
+        private static bool IsNtfs =>
+            FileSystemDebugInfo.IsCurrentDriveNTFS();
 
-        [ConditionalFact(nameof(IsPrivilegedAndNtfs))]
+        [ConditionalFact(nameof(IsNtfs))]
         [PlatformSpecific(TestPlatforms.Windows)] // testing volumes / mounts / drive letters
         public static void RunTest()
         {

src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/Directory/Exists.cs

@@ -302,7 +302,7 @@ public void DirectoryWithComponentLongerThanMaxComponentAsPath_ReturnsFalse(stri
             Assert.False(Exists(component));
         }
 
-        [ConditionalFact(nameof(HasNotReadyDrive))]
+        [ConditionalFact]
         [PlatformSpecific(TestPlatforms.Windows)] // drive labels
         public void NotReadyDriveAsPath_ReturnsFalse()
         {
@@ -313,7 +313,7 @@ public void NotReadyDriveAsPath_ReturnsFalse()
             Assert.False(result);
         }
 
-        [ConditionalFact(nameof(HasNotReadyDrive))]
+        [ConditionalFact]
         [PlatformSpecific(TestPlatforms.Windows)] // drive labels
         public void SubdirectoryOnNotReadyDriveAsPath_ReturnsFalse()
         {
@@ -325,7 +325,6 @@ public void SubdirectoryOnNotReadyDriveAsPath_ReturnsFalse()
         }
 
         private static readonly string? s_notReadyDrive = IOServices.GetNotReadyDrive();
-        private static bool HasNotReadyDrive => s_notReadyDrive is not null;
 
         // Not all drives may be accessible (locked, no rights, etc.), and as such would return false.
         // eg. Create a new volume, bitlocker it, and lock it. This new volume is no longer accessible

src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/Directory/ReparsePoints_MountVolume.cs

@@ -20,10 +20,10 @@ public class Directory_ReparsePoints_MountVolume
         private delegate void ExceptionCode();
         private static bool s_pass = true;
 
-        private static bool IsPrivilegedAndNtfs =>
-            PlatformDetection.IsPrivilegedProcess && FileSystemDebugInfo.IsCurrentDriveNTFS();
+        private static bool IsNtfs =>
+            FileSystemDebugInfo.IsCurrentDriveNTFS();
 
-        [ConditionalFact(nameof(IsPrivilegedAndNtfs))]
+        [ConditionalFact(nameof(IsNtfs))]
         [PlatformSpecific(TestPlatforms.Windows)] // testing mounting volumes and reparse points
         public static void runTest()
         {