Skip to content

Commit 59e343b

Browse files
authored
Update tests to deserialize char so that they align better with the (#32636)
behavior being tested.
1 parent 0fdd938 commit 59e343b

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

src/libraries/System.Text.Json/tests/Serialization/Null.ReadTests.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -161,10 +161,11 @@ public static void NullAcceptsLeadingAndTrailingTrivia()
161161
public static void NullReadTestChar()
162162
{
163163
Assert.Throws<JsonException>(() => JsonSerializer.Deserialize<char>("null"));
164-
Assert.Throws<JsonException>(() => JsonSerializer.Deserialize<char>(""));
165-
Assert.Throws<JsonException>(() => JsonSerializer.Deserialize<char>("1234"));
164+
Assert.Throws<JsonException>(() => JsonSerializer.Deserialize<char>("\"\""));
165+
Assert.Throws<JsonException>(() => JsonSerializer.Deserialize<char>("")); // Empty JSON is invalid
166+
Assert.Throws<JsonException>(() => JsonSerializer.Deserialize<char>("1234")); // Can't convert a JSON number to JSON string/char
166167
Assert.Throws<JsonException>(() => JsonSerializer.Deserialize<char>("\"stringTooLong\""));
167-
Assert.Throws<JsonException>(() => JsonSerializer.Deserialize<char>("\"\u0059\"B"));
168+
Assert.Throws<JsonException>(() => JsonSerializer.Deserialize<char>("\"\u0059B\""));
168169
Assert.Throws<JsonException>(() => JsonSerializer.Deserialize<char>("\"\uD800\uDC00\""));
169170
Assert.Equal('a', JsonSerializer.Deserialize<char>("\"a\""));
170171
Assert.Equal('Y', JsonSerializer.Deserialize<char>("\"\u0059\""));

0 commit comments

Comments
 (0)