Skip to content

Commit 2ed931d

Browse files
radicalakoeplinger
andauthored
CI: Fix helix test results reporting (#74788)
* CI: Fix helix test results reporting PR #73060 broke uploading of helix test results. This was caused by the change: ```xml <HelixPostCommands>@(HelixPostCommand)</HelixPostCommands> ``` This is overwriting the existing value of `$(HelixPostCommands)`, which gets set to have the upload script invocation in https://github.com/dotnet/arcade/blob/34dff939b4a91e4693f78a856e0e055c1a3f3fba/src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/AzurePipelines.MonoQueue.targets#L8-L15 at evaluation time. Fix by *appending* to the property. Thanks to ChadNedzlek for finding the cause! Fixes #74699 . * Disable failing tests, see #74781 Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
1 parent e00bd40 commit 2ed931d

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -848,6 +848,7 @@ public void VectorSingleEqualsNaNTest()
848848
}
849849

850850
[Fact]
851+
[ActiveIssue("https://github.com/dotnet/runtime/issues/74781", TestRuntimes.Mono)]
851852
public void VectorDoubleEqualsNonCanonicalNaNTest()
852853
{
853854
// max 8 bit exponent, just under half max mantissa
@@ -872,6 +873,7 @@ public void VectorDoubleEqualsNonCanonicalNaNTest()
872873
}
873874

874875
[Fact]
876+
[ActiveIssue("https://github.com/dotnet/runtime/issues/74781", TestRuntimes.Mono)]
875877
public void VectorSingleEqualsNonCanonicalNaNTest()
876878
{
877879
// max 11 bit exponent, just under half max mantissa

src/libraries/sendtohelixhelp.proj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,8 +172,8 @@
172172
</PropertyGroup>
173173

174174
<PropertyGroup>
175-
<HelixPreCommands>@(HelixPreCommand)</HelixPreCommands>
176-
<HelixPostCommands>@(HelixPostCommand)</HelixPostCommands>
175+
<HelixPreCommands>$(HelixPreCommands);@(HelixPreCommand)</HelixPreCommands>
176+
<HelixPostCommands>$(HelixPostCommands);@(HelixPostCommand)</HelixPostCommands>
177177
<HelixCommandPrefix Condition="'$(WindowsShell)' == 'true' and @(HelixCommandPrefixItem->Count()) > 0" >$(HelixCommandPrefix) @(HelixCommandPrefixItem -> 'set &quot;%(Identity)&quot;', ' &amp; ')</HelixCommandPrefix>
178178
<HelixCommandPrefix Condition="'$(WindowsShell)' != 'true' and @(HelixCommandPrefixItem->Count()) > 0 ">$(HelixCommandPrefix) @(HelixCommandPrefixItem, ' ')</HelixCommandPrefix>
179179
<IncludeHelixCorrelationPayload Condition="'$(IncludeHelixCorrelationPayload)' == '' and '$(HelixCorrelationPayload)' != ''">true</IncludeHelixCorrelationPayload>

0 commit comments

Comments
 (0)