Skip to content

Commit 024a727

Browse files
authored
[wasm] Add comments with linker fixes made for running aot tests in (#52006)
1 parent 50639b8 commit 024a727

5 files changed

Lines changed: 37 additions & 1 deletion

File tree

eng/testing/ILLinkDescriptors/ILLink.Descriptors.Serialization.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
<type fullname="System.Xml.Linq.XElement" />
44
</assembly>
55
<assembly fullname="System.Private.DataContractSerialization">
6+
7+
<!-- Issue: https://github.com/dotnet/runtime/issues/50730 -->
68
<type fullname="System.Runtime.Serialization.KeyValuePairAdapter`2" />
79
</assembly>
810
</linker>

src/libraries/Microsoft.Extensions.Logging/tests/ILLink.Descriptors.xml

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,22 @@
11
<linker>
22
<assembly fullname="System.Diagnostics.TraceSource">
3+
<!--
4+
fail: [FAIL] Microsoft.Extensions.Logging.Test.TraceSourceLoggerTest.Log_Shoud_Add_Exception_To_Message_Whether_Formatter_Is_Null_Or_Not(shouldFormatterBeNull: True)
5+
info: Castle.DynamicProxy.InvalidProxyConstructorArgumentsException : Can not instantiate proxy of class: System.Diagnostics.TraceListener.
6+
info: Could not find a parameterless constructor.
7+
info: at Castle.DynamicProxy.ProxyGenerator.CreateClassProxyInstance(Type proxyType, List`1 proxyArguments, Type classToProxy, Object[] constructorArguments)
8+
info: at Castle.DynamicProxy.ProxyGenerator.CreateClassProxy(Type classToProxy, Type[] additionalInterfacesToProxy, ProxyGenerationOptions options, Object[] constructorArguments, IInterceptor[] interceptors)
9+
info: at Moq.CastleProxyFactory.CreateProxy(Type mockType, IInterceptor interceptor, Type[] interfaces, Object[] arguments)
10+
info: at Moq.Mock`1[[System.Diagnostics.TraceListener, System.Diagnostics.TraceSource, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]].InitializeInstance()
11+
info: at Moq.Mock`1[[System.Diagnostics.TraceListener, System.Diagnostics.TraceSource, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]].OnGetObject()
12+
info: at Moq.Mock.get_Object()
13+
info: at Moq.Mock`1[[System.Diagnostics.TraceListener, System.Diagnostics.TraceSource, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]].get_Object()
14+
info: at Microsoft.Extensions.Logging.Test.TraceSourceLoggerTest.<>c__DisplayClass2_0.<Log_Shoud_Add_Exception_To_Message_Whether_Formatter_Is_Null_Or_Not>b__0(ILoggingBuilder builder)
15+
info: at Microsoft.Extensions.DependencyInjection.LoggingServiceCollectionExtensions.AddLogging(IServiceCollection services, Action`1 configure)
16+
info: at Microsoft.Extensions.Logging.Test.TestLoggerBuilder.Create(Action`1 configure)
17+
info: at Microsoft.Extensions.Logging.Test.TraceSourceLoggerTest.Log_Shoud_Add_Exception_To_Message_Whether_Formatter_Is_Null_Or_Not(Boolean shouldFormatterBeNull)
18+
info: at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
19+
-->
320
<type fullname="System.Diagnostics.TraceListener">
421
<method signature="System.Void .ctor()" />
522
</type>
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
<linker>
2+
<!--
3+
System.Reflection.Tests.MetadataLoadContextTests.RelocatableAssembly load `mscorlib.dll` by name
4+
`string mscorLibPath = Path.Combine(coreDirectory, "mscorlib.dll");`
5+
Linker completely completely trims it out. So, preserve it explicitly.
6+
-->
27
<assembly fullname="mscorlib" />
38
</linker>

src/libraries/System.Reflection/tests/ILLink.Descriptors.xml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,15 @@
11
<linker>
2+
<!--
3+
IList` implementation on `ArrayList` was getting trimmed
4+
5+
```
6+
fail: [FAIL] System.Reflection.Tests.TypeInfoTests.IsAssignable(type: typeof(System.Collections.IList), c: typeof(System.Collections.ArrayList), expected: True)
7+
info: Assert.Equal() Failure
8+
info: Expected: True
9+
info: Actual: False
10+
info: at System.Reflection.Tests.TypeInfoTests.IsAssignable(Type type, Type c, Boolean expected) in /Users/radical/dev/r3/src/libraries/System.Reflection/tests/TypeInfoTests.cs:line 580
11+
info: at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture) in /Users/radical/dev/r3/src/mono/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs:line 378
12+
-->
213
<assembly fullname="System.Private.CoreLib">
314
<type fullname="System.Collections.ArrayList" />
415
</assembly>

src/libraries/System.Text.Json/tests/System.Text.Json.Tests/System.Text.Json.Tests.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
<!-- SYSLIB0020: JsonSerializerOptions.IgnoreNullValues is obsolete -->
66
<NoWarn>$(NoWarn);SYSLIB0020</NoWarn>
77

8-
<!-- these tests depend on the pdb files -->
8+
<!-- these tests depend on the pdb files. Causes test failures like:
9+
[FAIL] System.Text.Json.Tests.DebuggerTests.DefaultJsonElement -->
910
<DebuggerSupport Condition="'$(DebuggerSupport)' == '' and '$(TargetOS)' == 'Browser'">true</DebuggerSupport>
1011
<WasmXHarnessArgs>$(WasmXHarnessArgs) --timeout=1800</WasmXHarnessArgs>
1112
</PropertyGroup>

0 commit comments

Comments
 (0)