Remove unused useSyntaxTreeCache option (#17768)

Author: majocha

docs/builder-caches.md

@@ -11,6 +11,7 @@
 ### Changed
 
 * Make ILTypeDef interface impls calculation lazy. ([PR #17392](https://github.com/dotnet/fsharp/pull/17392))
+* Remove non-functional useSyntaxTreeCache option. ([PR #17768](https://github.com/dotnet/fsharp/pull/17768))
 * Better ranges for CE `let!` and `use!` error reporting. ([PR #17712](https://github.com/dotnet/fsharp/pull/17712))
 * Better ranges for CE `do!` error reporting. ([PR #17779](https://github.com/dotnet/fsharp/pull/17779))
 * Better ranges for CE `match!`. ([PR #17789](https://github.com/dotnet/fsharp/pull/17789))

docs/release-notes/.FSharp.Compiler.Service/9.0.200.md

@@ -6,6 +6,7 @@
 
 ### Changed
 * Fix unwanted navigation on hover [PR #17592](https://github.com/dotnet/fsharp/pull/17592))
+* Remove non-functional useSyntaxTreeCache option. ([PR #17768](https://github.com/dotnet/fsharp/pull/17768))
 
 
 ### Breaking Changes

docs/release-notes/.VisualStudio/17.12.md

@@ -266,8 +266,7 @@ type internal BackgroundCompiler
         parallelReferenceResolution,
         captureIdentifiersWhenParsing,
         getSource: (string -> Async<ISourceText option>) option,
-        useChangeNotifications,
-        useSyntaxTreeCache
+        useChangeNotifications
     ) as self =
 
     let beforeFileChecked = Event<string * FSharpProjectOptions>()
@@ -403,8 +402,7 @@ type internal BackgroundCompiler
                     parallelReferenceResolution,
                     captureIdentifiersWhenParsing,
                     getSource,
-                    useChangeNotifications,
-                    useSyntaxTreeCache
+                    useChangeNotifications
                 )
 
             match builderOpt with

src/Compiler/Service/BackgroundCompiler.fs

@@ -235,8 +235,7 @@ type internal BackgroundCompiler =
         parallelReferenceResolution: ParallelReferenceResolution *
         captureIdentifiersWhenParsing: bool *
         getSource: (string -> Async<ISourceText option>) option *
-        useChangeNotifications: bool *
-        useSyntaxTreeCache: bool ->
+        useChangeNotifications: bool ->
             BackgroundCompiler
 
     static member ActualCheckFileCount: int

src/Compiler/Service/BackgroundCompiler.fsi

@@ -888,7 +888,6 @@ type IncrementalBuilderInitialState =
         defaultTimeStamp: DateTime
         mutable isImportsInvalidated: bool
         useChangeNotifications: bool
-        useSyntaxTreeCache: bool
     }
 
     static member Create
@@ -910,8 +909,7 @@ type IncrementalBuilderInitialState =
 #endif
             allDependencies,
             defaultTimeStamp: DateTime,
-            useChangeNotifications: bool,
-            useSyntaxTreeCache
+            useChangeNotifications: bool
         ) =
 
         let initialState =
@@ -937,7 +935,6 @@ type IncrementalBuilderInitialState =
                 defaultTimeStamp = defaultTimeStamp
                 isImportsInvalidated = false
                 useChangeNotifications = useChangeNotifications
-                useSyntaxTreeCache = useSyntaxTreeCache
             }
 #if !NO_TYPEPROVIDERS
         importsInvalidatedByTypeProvider.Publish.Add(fun () -> initialState.isImportsInvalidated <- true)
@@ -1409,8 +1406,7 @@ type IncrementalBuilder(initialState: IncrementalBuilderInitialState, state: Inc
             parallelReferenceResolution,
             captureIdentifiersWhenParsing,
             getSource,
-            useChangeNotifications,
-            useSyntaxTreeCache
+            useChangeNotifications
         ) =
 
       let useSimpleResolutionSwitch = "--simpleresolution"
@@ -1652,8 +1648,7 @@ type IncrementalBuilder(initialState: IncrementalBuilderInitialState, state: Inc
 #endif
                     allDependencies,
                     defaultTimeStamp,
-                    useChangeNotifications,
-                    useSyntaxTreeCache
+                    useChangeNotifications
                 )
 
             let builder = IncrementalBuilder(initialState, IncrementalBuilderState.Create(initialState))

src/Compiler/Service/IncrementalBuild.fs

@@ -296,8 +296,7 @@ type internal IncrementalBuilder =
         parallelReferenceResolution: ParallelReferenceResolution *
         captureIdentifiersWhenParsing: bool *
         getSource: (string -> Async<ISourceText option>) option *
-        useChangeNotifications: bool *
-        useSyntaxTreeCache: bool ->
+        useChangeNotifications: bool ->
             Async<IncrementalBuilder option * FSharpDiagnostic[]>
 
 /// Generalized Incremental Builder. This is exposed only for unit testing purposes.

src/Compiler/Service/IncrementalBuild.fsi

@@ -326,8 +326,7 @@ type internal TransparentCompiler
         parallelReferenceResolution,
         captureIdentifiersWhenParsing,
         getSource: (string -> Async<ISourceText option>) option,
-        useChangeNotifications,
-        useSyntaxTreeCache
+        useChangeNotifications
     ) as self =
 
     let documentSource =
@@ -374,8 +373,7 @@ type internal TransparentCompiler
             parallelReferenceResolution,
             captureIdentifiersWhenParsing,
             getSource,
-            useChangeNotifications,
-            useSyntaxTreeCache
+            useChangeNotifications
         )
         :> IBackgroundCompiler
 

src/Compiler/Service/TransparentCompiler.fs

@@ -155,8 +155,7 @@ type internal TransparentCompiler =
         parallelReferenceResolution: ParallelReferenceResolution *
         captureIdentifiersWhenParsing: bool *
         getSource: (string -> Async<ISourceText option>) option *
-        useChangeNotifications: bool *
-        useSyntaxTreeCache: bool ->
+        useChangeNotifications: bool ->
             TransparentCompiler
 
     member FindReferencesInFile:

src/Compiler/Service/TransparentCompiler.fsi

@@ -125,7 +125,6 @@ type FSharpChecker
         captureIdentifiersWhenParsing,
         getSource,
         useChangeNotifications,
-        useSyntaxTreeCache,
         useTransparentCompiler
     ) =
 
@@ -144,8 +143,7 @@ type FSharpChecker
                 parallelReferenceResolution,
                 captureIdentifiersWhenParsing,
                 getSource,
-                useChangeNotifications,
-                useSyntaxTreeCache
+                useChangeNotifications
             )
             :> IBackgroundCompiler
         else
@@ -162,8 +160,7 @@ type FSharpChecker
                 parallelReferenceResolution,
                 captureIdentifiersWhenParsing,
                 getSource,
-                useChangeNotifications,
-                useSyntaxTreeCache
+                useChangeNotifications
             )
             :> IBackgroundCompiler
 
@@ -209,7 +206,6 @@ type FSharpChecker
             ?parallelReferenceResolution: bool,
             ?captureIdentifiersWhenParsing: bool,
             ?documentSource: DocumentSource,
-            ?useSyntaxTreeCache: bool,
             ?useTransparentCompiler: bool
         ) =
 
@@ -238,8 +234,6 @@ type FSharpChecker
             | Some(DocumentSource.Custom _) -> true
             | _ -> false
 
-        let useSyntaxTreeCache = defaultArg useSyntaxTreeCache true
-
         if keepAssemblyContents && enablePartialTypeChecking then
             invalidArg "enablePartialTypeChecking" "'keepAssemblyContents' and 'enablePartialTypeChecking' cannot be both enabled."
 
@@ -261,7 +255,6 @@ type FSharpChecker
              | Some(DocumentSource.Custom f) -> Some f
              | _ -> None),
             useChangeNotifications,
-            useSyntaxTreeCache,
             useTransparentCompiler
         )