Skip to content

Commit 8a38c46

Browse files
dellis1972jonpryor
authored andcommitted
[Xamarin.Android.Build.Tasks] VS hangs/freezes when opening solutions containing Android Bindings Libraries that reference other libraries, during GetAdditionalResourcesFromAssemblies.Execute() (#28)
Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=40982 The Binding targets had the same issue as the normal Common targets for android projects. Commit d300845 added a new target to set $(DesignTimeBuild) to false if it was not set. This way when Visual studio does an intellisense build we do not attempt to download additional resources. This commit makes the same changes to the Bindings targets.
1 parent 4821159 commit 8a38c46

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

src/Xamarin.Android.Build.Tasks/Xamarin.Android.Bindings.targets

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ Copyright (C) 2012 Xamarin Inc. All rights reserved.
118118

119119
<PropertyGroup>
120120
<BuildDependsOn>
121+
_SetupDesignTimeBuildForBuild;
121122
AddLibraryJarsToBind;
122123
$(BuildDependsOn);
123124
BuildDocumentation;
@@ -274,6 +275,12 @@ Copyright (C) 2012 Xamarin Inc. All rights reserved.
274275
</CreateProperty>
275276
</Target>
276277

278+
<Target Name="_SetupDesignTimeBuildForBuild">
279+
<PropertyGroup>
280+
<DesignTimeBuild Condition=" '$(DesignTimeBuild)' == '' ">false</DesignTimeBuild>
281+
</PropertyGroup>
282+
</Target>
283+
277284
<Target Name="_BuildAdditionalResourcesCache"
278285
Inputs="@(ReferencePath);@(ReferenceDependencyPaths)"
279286
Outputs="$(_AndroidResourcePathsCache)"
@@ -283,6 +290,7 @@ Copyright (C) 2012 Xamarin Inc. All rights reserved.
283290
AndroidNdkDirectory="$(_AndroidNdkDirectory)"
284291
Assemblies="@(ReferencePath);@(ReferenceDependencyPaths)"
285292
CacheFile="$(IntermediateOutputPath)resourcepaths.cache"
293+
Condition=" '$(DesignTimeBuild)' != 'true' "
286294
/>
287295
</Target>
288296

0 commit comments

Comments
 (0)