Skip to content

Commit 43243b4

Browse files
authored
Bump to xamarin/Java.Interop/main@79744f61 (#6436)
Changes: dotnet/java-interop@974ad32...79744f6 * dotnet/java-interop@79744f61: [generator] Fix for fixing invalid annotation XML. (#897) * dotnet/java-interop@220b87fb: [tests] rework JavaObjectTest, use FinalizerHelper from mono/mono (#899) * dotnet/java-interop@f658ab26: [generator] Add Java.Interop.Tools.JavaTypeSystem (#849) Add `Java.Interop.Tools.JavaTypeSystem.csproj` to `Xamarin.Android.sln`, and add `Java.Interop.Tools.JavaTypeSystem.dll` to the installers. Add a temporary MSBuild property `$(_AndroidUseJavaLegacyResolver)`, which when set to `true` will cause `generator` to use the legacy Java type resolver (`ApiXmlAdjuster`) instead of the new `JavaTypeSystem` one, in case there are unexpected issues.
1 parent f9d86ae commit 43243b4

5 files changed

Lines changed: 16 additions & 1 deletion

File tree

Xamarin.Android.sln

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,8 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "tmt", "tools\tmt\tmt.csproj
150150
EndProject
151151
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "assembly-store-reader", "tools\assembly-store-reader\assembly-store-reader.csproj", "{DA50FC92-7FE7-48B5-BDB6-CDA57B37BB51}"
152152
EndProject
153+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Java.Interop.Tools.JavaTypeSystem", "external\Java.Interop\src\Java.Interop.Tools.JavaTypeSystem\Java.Interop.Tools.JavaTypeSystem.csproj", "{4EFCED6E-9A6B-453A-94E4-CE4B736EC684}"
154+
EndProject
153155
Global
154156
GlobalSection(SharedMSBuildProjectFiles) = preSolution
155157
src\Xamarin.Android.NamingCustomAttributes\Xamarin.Android.NamingCustomAttributes.projitems*{3f1f2f50-af1a-4a5a-bedb-193372f068d7}*SharedItemsImports = 5
@@ -414,6 +416,10 @@ Global
414416
{DA50FC92-7FE7-48B5-BDB6-CDA57B37BB51}.Debug|AnyCPU.Build.0 = Debug|anycpu
415417
{DA50FC92-7FE7-48B5-BDB6-CDA57B37BB51}.Release|AnyCPU.ActiveCfg = Release|anycpu
416418
{DA50FC92-7FE7-48B5-BDB6-CDA57B37BB51}.Release|AnyCPU.Build.0 = Release|anycpu
419+
{4EFCED6E-9A6B-453A-94E4-CE4B736EC684}.Debug|AnyCPU.ActiveCfg = Debug|Any CPU
420+
{4EFCED6E-9A6B-453A-94E4-CE4B736EC684}.Debug|AnyCPU.Build.0 = Debug|Any CPU
421+
{4EFCED6E-9A6B-453A-94E4-CE4B736EC684}.Release|AnyCPU.ActiveCfg = Release|Any CPU
422+
{4EFCED6E-9A6B-453A-94E4-CE4B736EC684}.Release|AnyCPU.Build.0 = Release|Any CPU
417423
EndGlobalSection
418424
GlobalSection(SolutionProperties) = preSolution
419425
HideSolutionNode = FALSE
@@ -482,6 +488,7 @@ Global
482488
{1A273ED2-AE84-48E9-9C23-E978C2D0CB34} = {864062D3-A415-4A6F-9324-5820237BA058}
483489
{DA50FC92-7FE7-48B5-BDB6-CDA57B37BB51} = {864062D3-A415-4A6F-9324-5820237BA058}
484490
{1FED3F23-1175-42AA-BE87-EF1E8DB52F8B} = {04E3E11E-B47D-4599-8AFC-50515A95E715}
491+
{4EFCED6E-9A6B-453A-94E4-CE4B736EC684} = {864062D3-A415-4A6F-9324-5820237BA058}
485492
EndGlobalSection
486493
GlobalSection(ExtensibilityGlobals) = postSolution
487494
SolutionGuid = {53A1F287-EFB2-4D97-A4BB-4A5E145613F6}

build-tools/installers/create-installers.targets

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,8 @@
148148
<_MSBuildFiles Include="$(MSBuildSrcDir)\Java.Interop.Tools.JavaCallableWrappers.pdb" />
149149
<_MSBuildFiles Include="$(MSBuildSrcDir)\Java.Interop.Tools.JavaSource.dll" />
150150
<_MSBuildFiles Include="$(MSBuildSrcDir)\Java.Interop.Tools.JavaSource.pdb" />
151+
<_MSBuildFiles Include="$(MSBuildSrcDir)\Java.Interop.Tools.JavaTypeSystem.dll" />
152+
<_MSBuildFiles Include="$(MSBuildSrcDir)\Java.Interop.Tools.JavaTypeSystem.pdb" />
151153
<_MSBuildFiles Include="$(MSBuildSrcDir)\Java.Runtime.Environment.dll" />
152154
<_MSBuildFiles Include="$(MSBuildSrcDir)\Java.Runtime.Environment.pdb" />
153155
<_MSBuildFiles Include="$(MSBuildSrcDir)\Java.Runtime.Environment.dll.config" Condition=" '$(HostOS)' != 'Windows' " />

external/Java.Interop

src/Xamarin.Android.Build.Tasks/MSBuild/Xamarin/Android/Xamarin.Android.Bindings.Core.targets

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ It is shared between "legacy" binding projects and .NET 5 projects.
8080
EnableBindingNestedInterfaceTypes="$(AndroidBoundInterfacesContainTypes)"
8181
EnableBindingInterfaceConstants="$(AndroidBoundInterfacesContainConstants)"
8282
Nullable="$(Nullable)"
83+
UseJavaLegacyResolver="$(_AndroidUseJavaLegacyResolver)"
8384
/>
8485

8586
<!-- Write a flag so we won't redo this target if nothing changed -->

src/Xamarin.Android.Build.Tasks/Tasks/Generator.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,8 @@ public class BindingsGenerator : AndroidDotnetToolTask
5959
public ITaskItem[] JavadocXml { get; set; }
6060
public string JavadocVerbosity { get; set; }
6161

62+
public bool UseJavaLegacyResolver { get; set; }
63+
6264
private List<Tuple<string, string>> transform_files = new List<Tuple<string,string>> ();
6365

6466
public override bool RunTask ()
@@ -198,6 +200,9 @@ protected override string GenerateCommandLineCommands ()
198200
WriteLine (sw, $"\"--with-javadoc-xml={Path.GetFullPath (xml.ItemSpec)}\"");
199201
}
200202
}
203+
204+
if (UseJavaLegacyResolver)
205+
WriteLine (sw, "--use-legacy-java-resolver=true");
201206
}
202207

203208
cmd.AppendSwitch (ApiXmlInput);

0 commit comments

Comments
 (0)