Address bot review: exit code check, typed catch, shell doc

- ListAvdNamesAsync: check exit code from emulator -list-avds
- TryKillProcess: change bare catch to catch(Exception ex) with logger
- TryKillProcess: make instance method to access logger field
- RunShellCommandAsync: add XML doc warning about shell interpretation

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: rmarinho

src/Xamarin.Android.Tools.AndroidSdk/Runners/AdbRunner.cs

@@ -161,6 +161,11 @@ public async Task StopEmulatorAsync (string serial, CancellationToken cancellati
 	/// Runs a shell command on a device via 'adb -s <serial> shell <command>'.
 	/// Returns the full stdout output trimmed, or <c>null</c> on failure.
 	/// </summary>
+	/// <remarks>
+	/// The <paramref name="command"/> is passed as a single argument to <c>adb shell</c>,
+	/// which means the device's shell interprets it (shell expansion, pipes, semicolons are active).
+	/// Do not pass untrusted or user-supplied input without proper validation.
+	/// </remarks>
 	public virtual async Task<string?> RunShellCommandAsync (string serial, string command, CancellationToken cancellationToken = default)
 	{
 		using var stdout = new StringWriter ();

src/Xamarin.Android.Tools.AndroidSdk/Runners/EmulatorRunner.cs

@@ -97,10 +97,12 @@ public Process LaunchAvd (string avdName, bool coldBoot = false, IEnumerable<str
 	public async Task<IReadOnlyList<string>> ListAvdNamesAsync (CancellationToken cancellationToken = default)
 	{
 		using var stdout = new StringWriter ();
+		using var stderr = new StringWriter ();
 		var psi = ProcessUtils.CreateProcessStartInfo (emulatorPath, "-list-avds");
 
 		logger?.Invoke (TraceLevel.Verbose, "Running: emulator -list-avds");
-		await ProcessUtils.StartProcess (psi, stdout, null, cancellationToken, environmentVariables).ConfigureAwait (false);
+		var exitCode = await ProcessUtils.StartProcess (psi, stdout, stderr, cancellationToken, environmentVariables).ConfigureAwait (false);
+		ProcessUtils.ThrowIfFailed (exitCode, "emulator -list-avds", stderr);
 
 		return ParseListAvdsOutput (stdout.ToString ());
 	}
@@ -243,16 +245,17 @@ public async Task<EmulatorBootResult> BootAvdAsync (
 		return null;
 	}
 
-	static void TryKillProcess (Process process)
+	void TryKillProcess (Process process)
 	{
 		try {
 #if NET5_0_OR_GREATER
 			process.Kill (entireProcessTree: true);
 #else
 			process.Kill ();
 #endif
-		} catch {
+		} catch (Exception ex) {
 			// Best-effort: process may have already exited
+			logger?.Invoke (TraceLevel.Verbose, $"Failed to stop emulator process: {ex.Message}");
 		} finally {
 			process.Dispose ();
 		}