Make LogBox render through SurfaceRegistry

Summary:
LogBox was using AppRegistry to render on to the screen. Switch LogBox over to using SurfaceRegistry instead.

Changelog: [Internal]

Reviewed By: sshic

Differential Revision: D37223641

fbshipit-source-id: 59001ad290c1e2c2f14828d38a96f48bd1ab39ca

Author: RSNara

Libraries/ReactNative/AppRegistry.js

@@ -338,19 +338,22 @@ const AppRegistry = {
   },
 };
 
-BatchedBridge.registerCallableModule('AppRegistry', AppRegistry);
-
-if (__DEV__) {
-  const LogBoxInspector = require('../LogBox/LogBoxInspectorContainer').default;
-  AppRegistry.registerComponent('LogBox', () => LogBoxInspector);
-} else {
-  AppRegistry.registerComponent(
-    'LogBox',
-    () =>
-      function NoOp() {
-        return null;
-      },
-  );
+if (!(global.RN$Bridgeless === true)) {
+  BatchedBridge.registerCallableModule('AppRegistry', AppRegistry);
+
+  if (__DEV__) {
+    const LogBoxInspector =
+      require('../LogBox/LogBoxInspectorContainer').default;
+    AppRegistry.registerComponent('LogBox', () => LogBoxInspector);
+  } else {
+    AppRegistry.registerComponent(
+      'LogBox',
+      () =>
+        function NoOp() {
+          return null;
+        },
+    );
+  }
 }
 
 module.exports = AppRegistry;

ReactCommon/react/renderer/uimanager/SurfaceRegistryBinding.cpp

@@ -25,8 +25,7 @@ void SurfaceRegistryBinding::startSurface(
   parameters["initialProps"] = initalProps;
   parameters["fabric"] = true;
 
-  if (moduleName != "LogBox" &&
-      runtime.global().hasProperty(runtime, "RN$SurfaceRegistry")) {
+  if (runtime.global().hasProperty(runtime, "RN$SurfaceRegistry")) {
     auto registry =
         runtime.global().getPropertyAsObject(runtime, "RN$SurfaceRegistry");
     auto method = registry.getPropertyAsFunction(runtime, "renderSurface");
@@ -59,8 +58,7 @@ void SurfaceRegistryBinding::setSurfaceProps(
   parameters["initialProps"] = initalProps;
   parameters["fabric"] = true;
 
-  if (moduleName != "LogBox" &&
-      runtime.global().hasProperty(runtime, "RN$SurfaceRegistry")) {
+  if (runtime.global().hasProperty(runtime, "RN$SurfaceRegistry")) {
     auto registry =
         runtime.global().getPropertyAsObject(runtime, "RN$SurfaceRegistry");
     auto method = registry.getPropertyAsFunction(runtime, "setSurfaceProps");