Skip to content

Update AppOptions to include script* attributes #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
craigbeck merged 2 commits into from
Oct 24, 2024
Merged

Update AppOptions to include script* attributes #647

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f6b714
Update AppOptions to include script* attributes referenced by AppForS…
craigbeck Oct 24, 2024
5e73279
Comment AppOptions attributes
craigbeck Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/App.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,11 @@ export function createAppPage(derby): typeof Page {

export interface AppOptions {
appMetadata?: Record<string, string>,
scriptHash?: string,
scriptBaseUrl?: string,
scriptCrossOrigin?: boolean,
scriptHash?: string;
scriptMapBaseUrl?: string,
[key: string]: unknown,
}

type OnRouteCallback = (this: Page, page: Page, model: Model, params: PageParams, done?: () => void) => void;
Expand Down
4 changes: 2 additions & 2 deletions src/AppForServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

import * as racer from 'racer';

import { App } from './App';
import { App, AppOptions } from './App';
import { type Derby } from './Derby';
import { type StyleCompilerOptions } from './files';
import { PageForServer } from './PageForServer';
Expand Down Expand Up @@ -79,7 +79,7 @@ export class AppForServer extends App {
watchFiles: boolean;
router: any;

constructor(derby: Derby, name: string, filename: string, options) {
constructor(derby: Derby, name: string, filename: string, options?: AppOptions) {
super(derby, name, filename, options);
this._init(options);
}
Expand Down
Loading