Skip to content

Commit 36dce21

Browse files
Fix type hierarchy tests (#11)
* Remove covariant tests * Fix type hierarchy tests to override the right method * Remove DebuggerBreak
1 parent 4fb47b9 commit 36dce21

2 files changed

Lines changed: 1499 additions & 1738 deletions

File tree

src/tests/Loader/classloader/StaticVirtualMethods/TypeHierarchy/Generator/Program.cs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ public static IEnumerable<TestScenario> GetScenarios()
139139
foreach (string baseTypeInstantiationOnDerivedType in possibleBaseTypeInstantiationOnDerivedType)
140140
{
141141
string interfaceTypeInstantiationOnDerivedType = ApplyGenericSubstitution(interfaceTypeInstantiationOnBaseType, baseTypeInstantiationOnDerivedType);
142-
string derivedTypeReturnType = ApplyGenericSubstitution(baseTypeReturnType, interfaceTypeInstantiationOnDerivedType);
142+
string derivedTypeReturnType = ApplyGenericSubstitution(interfaceReturnType, interfaceTypeInstantiationOnDerivedType);
143143

144144
List<string> possibleDerivedTypeInstantiation = new List<string>();
145145
if (derivedTypeGenericParams == "")
@@ -162,9 +162,8 @@ public static IEnumerable<TestScenario> GetScenarios()
162162
if (baseTypeReturnType == "string")
163163
{
164164
covariantScenarios++;
165-
// This isn't a good place for extensive covariant return testing
166-
if ((covariantScenarios % 20) != 0)
167-
continue;
165+
// We decided covariant scenarios aren't supported
166+
continue;
168167
}
169168
yield return new TestScenario(scenarioIndex++,
170169
interfaceReturnType,

0 commit comments

Comments
 (0)