feat(data type): ArrayType support inner dataType#5049
Merged
bohutang merged 1 commit intodatabendlabs:mainfrom May 8, 2022
Merged
feat(data type): ArrayType support inner dataType#5049bohutang merged 1 commit intodatabendlabs:mainfrom
bohutang merged 1 commit intodatabendlabs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Contributor
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
sundy-li
reviewed
Apr 25, 2022
41186a4 to
1eabcfa
Compare
sundy-li
reviewed
May 7, 2022
|
|
||
| select * from t12; | ||
|
|
||
| select '==Array(String) Nullable=='; |
Member
There was a problem hiding this comment.
I think we don't accept Array(String null), so tests should be covered about this type.
Member
Author
There was a problem hiding this comment.
CREATE TABLE IF NOT EXISTS t16(id Int, arr Array(String Null)) Engine = Memory; -- {ErrorCode 1005}will parse error, we can't test this case in the stateless test.
Member
|
@mergify update |
Contributor
✅ Branch has been successfully updated |
c895c8f to
fbe9978
Compare
Member
|
Oops, CI failure: https://github.com/datafuselabs/databend/runs/6333086848?check_suite_focus=true#step:3:437 |
sundy-li
approved these changes
May 7, 2022
Member
|
Impressive Pr, this may be a conflict with #5167, cc @zhang2014 After merging it, |
55 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
ArrayType support inner dataType
Changelog
Related Issues
Fixes #4974