rpc: deprecate argument for defining scheme type in bls generate

Author: kwvg

doc/release-notes-6723.md

@@ -4,3 +4,6 @@ Updated RPCs
 * The RPCs `protx register_legacy`, `protx register_fund_legacy`, `protx register_prepare_legacy` and
   `protx update_registrar_legacy` have been deprecated in Dash Core v23 and may be removed in a future version
   They can be re-enabled with the runtime argument `-deprecatedrpc=legacy_mn`.
+
+* The argument `legacy` in `bls generate` has been deprecated in Dash Core v23 and may be ignored in a future version.
+  It can be re-enabled with the runtime argument `deprecatedrpc=legacy_mn`.

src/rpc/evo.cpp

@@ -1713,7 +1713,7 @@ static RPCHelpMan bls_generate()
         "bls generate",
         "\nReturns a BLS secret/public key pair.\n",
         {
-            {"legacy", RPCArg::Type::BOOL, RPCArg::Default{false}, "Set it true if need in legacy BLS scheme"},
+            {"legacy", RPCArg::Type::BOOL, RPCArg::Default{false}, "(DEPRECATED, can be set if -deprecatedrpc=legacy_mn is passed) Set true to use legacy BLS scheme"},
         },
         RPCResult{RPCResult::Type::OBJ,
                   "",
@@ -1727,6 +1727,9 @@ static RPCHelpMan bls_generate()
             sk.MakeNewKey();
             bool bls_legacy_scheme{false};
             if (!request.params[0].isNull()) {
+                if (!IsDeprecatedRPCEnabled("legacy_mn")) {
+                    throw std::runtime_error("DEPRECATED: Pass config option -deprecatedrpc=legacy_mn to set this argument");
+                }
                 bls_legacy_scheme = ParseBoolV(request.params[0], "bls_legacy_scheme");
             }
             UniValue ret(UniValue::VOBJ);

src/test/rpc_tests.cpp

@@ -41,6 +41,9 @@ class HasJSON
 class RPCTestingSetup : public TestingSetup
 {
 public:
+    RPCTestingSetup()
+        : TestingSetup(CBaseChainParams::MAIN, {"-deprecatedrpc=legacy_mn"}) {}
+
     UniValue TransformParams(const UniValue& params, std::vector<std::string> arg_names);
     UniValue CallRPC(std::string args);
 };