[dartdevc] Remove ability to run analyzer based DDC

This is the first step in deleting legacy DDC!
* Default all invocations of DDC to run the kernel version.
* Disable all tests that run analyzer DDC.
* Detect the most likely case when invoked with an analyzer
  summary and print instruction to update build_web_compilers
  dependency.

I will follow up with deletions, and a rename of the test configurations/
builders to reclaim the names (ddc vs ddk, dartdevc vs dartdevk).

Issue #38777

Change-Id: I1477f0274b6b7f345a5e19d2b3f93797c454a09e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127067
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Mark Zhou <markzipan@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>

Author: nshahan

pkg/dev_compiler/lib/src/compiler/shared_command.dart

@@ -4,13 +4,11 @@
 
 import 'dart:async';
 import 'dart:io';
-import 'package:analyzer/src/generated/engine.dart' show AnalysisEngine;
 import 'package:args/args.dart';
 import 'package:front_end/src/api_unstable/ddc.dart'
     show InitializedCompilerState, parseExperimentalArguments;
 import 'package:path/path.dart' as p;
 import 'module_builder.dart';
-import '../analyzer/command.dart' as analyzer_compiler;
 import '../analyzer/driver.dart' show CompilerAnalysisDriver;
 import '../kernel/command.dart' as kernel_compiler;
 
@@ -400,33 +398,31 @@ Future<CompilerResult> compile(ParsedArguments args,
     throw ArgumentError(
         'previousResult requires --batch or --bazel_worker mode/');
   }
-  if (args.isKernel) {
-    return kernel_compiler.compile(args.rest,
-        compilerState: previousResult?.kernelState,
-        isWorker: args.isWorker,
-        useIncrementalCompiler: args.useIncrementalCompiler,
-        inputDigests: inputDigests);
-  } else {
-    var result = analyzer_compiler.compile(args.rest,
-        compilerState: previousResult?.analyzerState);
-    if (args.isBatchOrWorker) {
-      AnalysisEngine.instance.clearCaches();
-    }
-    return Future.value(result);
+
+  // TODO(38777) Cleanup when we delete all the DDC code.
+  if (!args.isKernel) {
+    throw ArgumentError(
+        'Compiling with analyzer based DDC is no longer supported.');
   }
+
+  return kernel_compiler.compile(args.rest,
+      compilerState: previousResult?.kernelState,
+      isWorker: args.isWorker,
+      useIncrementalCompiler: args.useIncrementalCompiler,
+      inputDigests: inputDigests);
 }
 
 /// The result of a single `dartdevc` compilation.
 ///
-/// Typically used for exiting the proceess with [exitCode] or checking the
+/// Typically used for exiting the process with [exitCode] or checking the
 /// [success] of the compilation.
 ///
-/// For batch/worker compilations, the [compilerState] provides an opprotunity
+/// For batch/worker compilations, the [compilerState] provides an opportunity
 /// to reuse state from the previous run, if the options/input summaries are
-/// equiavlent. Otherwise it will be discarded.
+/// equivalent. Otherwise it will be discarded.
 class CompilerResult {
   /// Optionally provides the front_end state from the previous compilation,
-  /// which can be passed to [compile] to potentially speeed up the next
+  /// which can be passed to [compile] to potentially speed up the next
   /// compilation.
   ///
   /// This field is unused when using the Analyzer-backend for DDC.
@@ -437,6 +433,7 @@ class CompilerResult {
   /// compilation.
   ///
   /// This field is unused when using the Kernel-backend for DDC.
+  // TODO(38777) Cleanup when we delete all the DDC code.
   final CompilerAnalysisDriver analyzerState;
 
   /// The process exit code of the compiler.
@@ -454,7 +451,7 @@ class CompilerResult {
   /// [exitCode] == 0).
   bool get success => exitCode == 0;
 
-  /// Whether the compiler crashed (i.e. threw an unhandled exeception,
+  /// Whether the compiler crashed (i.e. threw an unhandled exception,
   /// typically indicating an internal error in DDC itself or its front end).
   bool get crashed => exitCode == 70;
 }
@@ -506,7 +503,7 @@ class ParsedArguments {
   ParsedArguments._(this.rest,
       {this.isBatch = false,
       this.isWorker = false,
-      this.isKernel = false,
+      this.isKernel = true,
       this.reuseResult = false,
       this.useIncrementalCompiler = false});
 
@@ -525,7 +522,7 @@ class ParsedArguments {
     var newArgs = <String>[];
     bool isWorker = false;
     bool isBatch = false;
-    bool isKernel = false;
+    bool isKernel = true;
     bool reuseResult = false;
     bool useIncrementalCompiler = false;
 

pkg/dev_compiler/lib/src/kernel/command.dart

@@ -116,6 +116,16 @@ Future<CompilerResult> _compile(List<String> args,
   try {
     argResults = argParser.parse(filterUnknownArguments(args, argParser));
   } on FormatException catch (error) {
+    if (args.any((arg) => arg.contains('ddc_sdk.sum'))) {
+      print('Compiling with analyzer based DDC is no longer supported.\n');
+      print('The most likely reason you are seeing this message is due to an '
+          'old version of build_web_compilers.');
+      print('Update your package pubspec.yaml to depend on a newer version of '
+          'build_web_compilers:\n\n'
+          'dev_dependency:\n'
+          '  build_web_compilers: ^2.0.0\n');
+      return CompilerResult(64);
+    }
     print(error);
     print(_usageMessage(argParser));
     return CompilerResult(64);

pkg/dev_compiler/test/worker/worker_test.dart

@@ -17,14 +17,7 @@ Directory tmp = Directory.systemTemp.createTempSync('ddc_worker_test');
 File file(String path) => File(join(tmp.path, joinAll(path.split('/'))));
 
 void main() {
-  runTests(false);
-  runTests(true);
-}
-
-void runTests(bool isKernel) {
-  String mode = isKernel ? 'DDK' : 'DDC';
-  List<String> baseArgs = isKernel ? ['-k'] : [];
-  String ext = isKernel ? 'dill' : 'sum';
+  List<String> baseArgs = [];
   final binDir = dirname(Platform.resolvedExecutable);
   // Note, the bots use the dart binary in the top-level build directory.
   // On windows, this is a .bat file.
@@ -33,7 +26,7 @@ void runTests(bool isKernel) {
       ? join(binDir, dartdevc)
       : join(binDir, 'dart-sdk', 'bin', dartdevc);
   final executableArgs = <String>[];
-  group('$mode: Hello World', () {
+  group('DDC: Hello World', () {
     final argsFile = file('hello_world.args');
     final inputDartFile = file('hello_world.dart');
     final outputJsFile = file('out/hello_world.js');
@@ -165,16 +158,16 @@ void runTests(bool isKernel) {
     });
   });
 
-  group('$mode: Hello World with Summaries', () {
+  group('DDC: Hello World with Summaries', () {
     final greetingDart = file('greeting.dart');
     final helloDart = file('hello.dart');
 
     final greetingJS = file('greeting.js');
-    final greetingSummary = file('greeting.$ext');
+    final greetingSummary = file('greeting.dill');
     final helloJS = file('hello_world.js');
 
     final greeting2JS = file('greeting2.js');
-    final greeting2Summary = file('greeting2.$ext');
+    final greeting2Summary = file('greeting2.dill');
 
     setUp(() {
       greetingDart.writeAsStringSync('String greeting = "hello";');
@@ -285,7 +278,7 @@ void runTests(bool isKernel) {
     });
   });
 
-  group('$mode: Error handling', () {
+  group('DDC: Error handling', () {
     final badFileDart = file('bad.dart');
     final badFileJs = file('bad.js');
 
@@ -325,7 +318,7 @@ void runTests(bool isKernel) {
     });
   });
 
-  group('$mode: Parts', () {
+  group('DDC: Parts', () {
     final partFile = file('greeting.dart');
     final libraryFile = file('hello.dart');
 
@@ -381,27 +374,6 @@ void runTests(bool isKernel) {
       expect(result.exitCode, 0);
       expect(outJS.existsSync(), isTrue);
     });
-
-    if (!isKernel) {
-      // TODO(vsm): Consider dropping this test.  Kernel behavior is better.
-      test('part without library is silently ignored', () {
-        var result = Process.runSync(
-            executable,
-            executableArgs +
-                baseArgs +
-                [
-                  '--no-summarize',
-                  '--no-source-map',
-                  '-o',
-                  outJS.path,
-                  partFile.path,
-                ]);
-        expect(result.stdout, isEmpty);
-        expect(result.stderr, isEmpty);
-        expect(result.exitCode, 0);
-        expect(outJS.existsSync(), isTrue);
-      });
-    }
   });
 }
 

pkg/dev_compiler/tool/ddb

@@ -28,7 +28,7 @@ void main(List<String> args) async {
   var parser = ArgParser()
     ..addFlag('help', abbr: 'h', help: 'Display this message.')
     ..addFlag('kernel',
-        abbr: 'k', help: 'Compile with the new kernel-based front end.')
+        abbr: 'k', help: 'Ignored. The kernel based DDC is always used.')
     ..addMultiOption('summary',
         abbr: 's',
         help: 'summary file(s) of imported libraries, optionally\n'
@@ -44,9 +44,7 @@ void main(List<String> args) async {
     ..addOption('vm-service-port',
         help: 'Specify the observatory port. Implied --observe.')
     ..addFlag('summarize-text',
-        help: 'Emit API summary in a .js.txt file.\n'
-            'Ignored when not passed with --kernel.',
-        defaultsTo: false)
+        help: 'Emit API summary in a .js.txt file.', defaultsTo: false)
     ..addOption('runtime',
         abbr: 'r',
         help: 'Platform to run on (node|d8|chrome).  Default is node.',
@@ -65,10 +63,8 @@ void main(List<String> args) async {
         defaultsTo: 'all')
     ..addOption('compile-vm-options',
         help: 'DART_VM_OPTIONS for the compilation VM.')
-    ..addOption('packages',
-        help: 'Where to find a package spec file.')
-    ..addOption('out',
-        help: 'Output file.');
+    ..addOption('packages', help: 'Where to find a package spec file.')
+    ..addOption('out', help: 'Output file.');
 
   var options = parser.parse(args);
   if (options['help'] as bool) {
@@ -85,7 +81,6 @@ void main(List<String> args) async {
   var debug = options['debug'] as bool ||
       options['observe'] as bool ||
       options.wasParsed('vm-service-port');
-  var kernel = options['kernel'] as bool;
   var summarizeText = options['summarize-text'] as bool;
   var binary = options['binary'] as String;
   var experiments = options['enable-experiment'] as List;
@@ -99,9 +94,7 @@ void main(List<String> args) async {
   var out = (options['out'] as String) ?? p.setExtension(entry, '.js');
   var libRoot = p.dirname(entry);
   var basename = p.basenameWithoutExtension(entry);
-  var libname = kernel
-      ? p.relative(p.withoutExtension(entry)).replaceAll('/', '__')
-      : basename;
+  var libname = p.relative(p.withoutExtension(entry)).replaceAll('/', '__');
   libname = libname.replaceAll('-', '_');
 
   // By default (no `-d`), we use the `dartdevc` binary on the user's path to
@@ -178,22 +171,17 @@ void main(List<String> args) async {
     var buildDir = p.join(sdkRoot, Platform.isMacOS ? 'xcodebuild' : 'out');
     dartSdk = p.join(buildDir, 'ReleaseX64', 'dart-sdk');
   }
-  var suffix = kernel ? p.join('kernel', mod) : mod;
+  var suffix = p.join('kernel', mod);
   sdkJsPath = p.join(dartSdk, 'lib', 'dev_compiler', suffix);
   requirePath = sdkJsPath;
-  ddcSdk = p.join(
-      dartSdk, 'lib', '_internal', kernel ? 'ddc_sdk.dill' : 'ddc_sdk.sum');
+  ddcSdk = p.join(dartSdk, 'lib', '_internal', 'ddc_sdk.dill');
 
   if (compile) {
     var ddcArgs = [
-      if (kernel) '--kernel',
-      if (kernel && summarizeText)
-        '--summarize-text',
+      '--kernel',
+      if (summarizeText) '--summarize-text',
       '--modules=$mod',
       '--dart-sdk-summary=$ddcSdk',
-      // TODO(nshahan) Cleanup when we settle on using or removing library-root.
-      if (!kernel)
-        '--library-root=$libRoot',
       for (var summary in summaries) '--summary=$summary',
       for (var experiment in experiments) '--enable-experiment=$experiment',
       if (options['packages'] != null) '--packages=${options['packages']}',

sdk/BUILD.gn

@@ -691,72 +691,15 @@ copy("copy_dev_compiler_summary") {
   deps = [
     ":copy_libraries",
     "../utils/dartdevc:dartdevc_platform",
-    "../utils/dartdevc:dartdevc_sdk",
   ]
-  gen_dir = get_label_info("../utils/dartdevc:dartdevc_sdk", "target_gen_dir")
   sources = [
-    # TODO(vsm): Remove post CFE.
-    "$gen_dir/ddc_sdk.sum",
     "$root_out_dir/ddc_sdk.dill",
   ]
   outputs = [
     "$root_out_dir/dart-sdk/lib/_internal/{{source_file_part}}",
   ]
 }
 
-# TODO(vsm): Remove the old non-CFE versions of the SDK once we've completed
-# DDC to Kernel (DDK) migration.
-
-# This rule copies DDC's JS SDK and require.js to lib/dev_compiler/amd.
-copy("copy_dev_compiler_js_amd") {
-  visibility = [ ":copy_dev_compiler_js" ]
-  deps = [
-    "../utils/dartdevc:dartdevc_sdk",
-  ]
-  gen_dir = get_label_info("../utils/dartdevc:dartdevc_sdk", "target_gen_dir")
-  sources = [
-    "$gen_dir/js/amd/dart_sdk.js",
-    "$gen_dir/js/amd/dart_sdk.js.map",
-    "../third_party/requirejs/require.js",
-  ]
-  outputs = [
-    "$root_out_dir/dart-sdk/lib/dev_compiler/amd/{{source_file_part}}",
-  ]
-}
-
-# This rule copies DDC's JS SDK and run.js to lib/dev_compiler/common.
-copy("copy_dev_compiler_js_common") {
-  visibility = [ ":copy_dev_compiler_js" ]
-  deps = [
-    "../utils/dartdevc:dartdevc_sdk",
-  ]
-  gen_dir = get_label_info("../utils/dartdevc:dartdevc_sdk", "target_gen_dir")
-  sources = [
-    "$gen_dir/js/common/dart_sdk.js",
-    "$gen_dir/js/common/dart_sdk.js.map",
-    "../pkg/dev_compiler/lib/js/common/run.js",
-  ]
-  outputs = [
-    "$root_out_dir/dart-sdk/lib/dev_compiler/common/{{source_file_part}}",
-  ]
-}
-
-# This rule copies DDC's JS SDK to lib/dev_compiler/es6.
-copy("copy_dev_compiler_js_es6") {
-  visibility = [ ":copy_dev_compiler_js" ]
-  deps = [
-    "../utils/dartdevc:dartdevc_sdk",
-  ]
-  gen_dir = get_label_info("../utils/dartdevc:dartdevc_sdk", "target_gen_dir")
-  sources = [
-    "$gen_dir/js/es6/dart_sdk.js",
-    "$gen_dir/js/es6/dart_sdk.js.map",
-  ]
-  outputs = [
-    "$root_out_dir/dart-sdk/lib/dev_compiler/es6/{{source_file_part}}",
-  ]
-}
-
 # This rule copies DDK's JS SDK and require.js to lib/dev_compiler/kernel/amd.
 copy("copy_dev_compiler_js_amd_kernel") {
   visibility = [ ":copy_dev_compiler_js" ]
@@ -817,11 +760,8 @@ group("copy_dev_compiler_js") {
     ":copy_dev_compiler_tools",
   ]
   public_deps = [
-    ":copy_dev_compiler_js_amd",
     ":copy_dev_compiler_js_amd_kernel",
-    ":copy_dev_compiler_js_common",
     ":copy_dev_compiler_js_common_kernel",
-    ":copy_dev_compiler_js_es6",
     ":copy_dev_compiler_js_es6_kernel",
   ]
 }