Skip to content

Conversation

@cristan
Copy link
Contributor

@cristan cristan commented Oct 11, 2019

This makes a crash in case of an invalid font a lot nicer. Instead of a NullPointerException, you'll get a more descriptive IOException "Could not get hhea table".

Old stacktrace:

com.openhtmltopdf.load INFO:: Loading font(noto) from InputStream supplier now.
java.lang.NullPointerException
	at org.apache.fontbox.ttf.HorizontalMetricsTable.read(HorizontalMetricsTable.java:53)
	at org.apache.fontbox.ttf.TrueTypeFont.readTable(TrueTypeFont.java:353)
	at org.apache.fontbox.ttf.TTFParser.parseTables(TTFParser.java:173)
	at org.apache.fontbox.ttf.TTFParser.parse(TTFParser.java:150)
	at org.apache.fontbox.ttf.TTFParser.parse(TTFParser.java:106)
	at org.apache.pdfbox.pdmodel.font.PDType0Font.load(PDType0Font.java:94)
	at com.openhtmltopdf.pdfboxout.PdfBoxFontResolver$FontDescription.realizeFont(PdfBoxFontResolver.java:763)
	at com.openhtmltopdf.pdfboxout.PdfBoxFontResolver$FontDescription.getFontMetrics(PdfBoxFontResolver.java:828)
	at com.openhtmltopdf.pdfboxout.PdfBoxTextRenderer.getFSFontMetrics(PdfBoxTextRenderer.java:76)
	at com.openhtmltopdf.layout.LayoutContext.getFSFontMetrics(LayoutContext.java:425)
	at com.openhtmltopdf.css.style.CalculatedStyle.getFSFontMetrics(CalculatedStyle.java:771)
	at com.openhtmltopdf.css.style.CalculatedStyle.getLineHeight(CalculatedStyle.java:464)
	at com.openhtmltopdf.layout.InlineBoxing.layoutContent(InlineBoxing.java:96)
	at com.openhtmltopdf.render.BlockBox.layoutInlineChildren(BlockBox.java:1194)
	at com.openhtmltopdf.render.BlockBox.layoutChildren(BlockBox.java:1175)
	at com.openhtmltopdf.render.BlockBox.layout(BlockBox.java:1032)
	at com.openhtmltopdf.render.BlockBox.layout(BlockBox.java:947)
	at com.openhtmltopdf.layout.BlockBoxing.layoutBlockChild0(BlockBoxing.java:321)
	at com.openhtmltopdf.layout.BlockBoxing.layoutBlockChild(BlockBoxing.java:299)
	at com.openhtmltopdf.layout.BlockBoxing.layoutContent(BlockBoxing.java:90)
	at com.openhtmltopdf.render.BlockBox.layoutChildren(BlockBox.java:1178)
	at com.openhtmltopdf.render.BlockBox.layout(BlockBox.java:1032)
	at com.openhtmltopdf.render.BlockBox.layout(BlockBox.java:947)
	at com.openhtmltopdf.layout.BlockBoxing.layoutBlockChild0(BlockBoxing.java:321)
	at com.openhtmltopdf.layout.BlockBoxing.layoutBlockChild(BlockBoxing.java:299)
	at com.openhtmltopdf.layout.BlockBoxing.layoutContent(BlockBoxing.java:90)
	at com.openhtmltopdf.render.BlockBox.layoutChildren(BlockBox.java:1178)
	at com.openhtmltopdf.render.BlockBox.layout(BlockBox.java:1032)
	at com.openhtmltopdf.render.BlockBox.layout(BlockBox.java:947)
	at com.openhtmltopdf.pdfboxout.PdfBoxRenderer.layout(PdfBoxRenderer.java:335)
	at com.openhtmltopdf.pdfboxout.PdfRendererBuilder.run(PdfRendererBuilder.java:40)

This makes a crash in case of an invalid font a lot nicer. Instead of a NullPointerException, you'll get a more descriptive IOException "Could not get hhea table".
rototor added a commit to rototor/openhtmltopdf that referenced this pull request Oct 12, 2019
And while we are at it, we should also update PDFBox itself. But this is redundant with danfickle#394.
@danfickle danfickle merged commit 77f1871 into danfickle:open-dev-v1 Oct 13, 2019
@danfickle
Copy link
Owner

Thanks a lot @cristan.

@cristan cristan deleted the patch-1 branch October 14, 2019 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants