-
-
Notifications
You must be signed in to change notification settings - Fork 127
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Fiddle at https://jsfiddle.net/2f6uzmb5/6/
Steps to reproduce:
- Import Goober “the old-school way” e.g. with
<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/goober.umd.js" />
- Set
window.targetto something that internal functiongetSheet()won't like - Call
css()
Expected result: css() should return a fresh CSS class name.
Actual result:
TypeError: e.querySelector is not a function
(where e is presumably the minified variable that holds window.target inside getSheet())
From reading the relevant source code, it looks like setting any of window.p, window.g, window.o or window.k could also result in funny behavior.
This doesn't happen in a modern (ESM) environment, as they dropped the idea of squeezing the global object into this-less function calls.
jluxenberg
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working